fdf69ff21a
net: move max/max-outbound to CConnman
2016-09-08 12:24:06 -04:00
8a593694b1
net: move semOutbound to CConnman
2016-09-08 12:24:06 -04:00
bd72937dc4
net: move nLocalServices/nRelevantServices to CConnman
...
These are in-turn passed to CNode at connection time. This allows us to offer
different services to different peers (or test the effects of doing so).
2016-09-08 12:24:06 -04:00
be9c796dc5
net: move SendBufferSize/ReceiveFloodSize to CConnman
2016-09-08 12:24:06 -04:00
63cafa6329
net: move send/recv statistics to CConnman
2016-09-08 12:24:06 -04:00
adf5d4c2e4
net: SocketSendData returns written size
2016-09-08 12:24:06 -04:00
ee44fa9576
net: move messageHandlerCondition to CConnman
2016-09-08 12:24:06 -04:00
960cf2e405
net: move nLocalHostNonce to CConnman
...
This behavior seems to have been quite racy and broken.
Move nLocalHostNonce into CNode, and check received nonces against all
non-fully-connected nodes. If there's a match, assume we've connected
to ourself.
2016-09-08 12:24:06 -04:00
551e0887db
net: move nLastNodeId to CConnman
2016-09-08 12:24:06 -04:00
6c19d92361
net: move whitelist functions into CConnman
2016-09-08 12:24:06 -04:00
53347f0cb9
net: create generic functor accessors and move vNodes to CConnman
2016-09-08 12:24:06 -04:00
c0569c7fa1
net: Add most functions needed for vNodes to CConnman
2016-09-08 12:12:58 -04:00
8ae2dac1c6
net: move added node functions to CConnman
2016-09-08 12:12:58 -04:00
502dd3a8a0
net: Add oneshot functions to CConnman
2016-09-08 12:12:57 -04:00
a0f3d3cdad
net: move ban and addrman functions into CConnman
2016-09-08 12:12:57 -04:00
aaf018e3b7
net: handle nodesignals in CConnman
2016-09-08 12:06:24 -04:00
b1a5f43208
net: move OpenNetworkConnection into CConnman
2016-09-08 12:06:24 -04:00
02137f11e2
net: Move socket binding into CConnman
2016-09-08 12:06:24 -04:00
5b446dd5b1
net: Pass CConnection to wallet rather than using the global
2016-09-08 12:04:35 -04:00
8d58c4d81f
net: Pass CConnman around as needed
2016-09-08 12:04:35 -04:00
d7349ca50d
net: Add rpc error for missing/disabled p2p functionality
2016-09-08 12:04:35 -04:00
cd16f48028
net: Create CConnman to encapsulate p2p connections
2016-09-08 12:04:35 -04:00
d93b14dc5d
net: move CBanDB and CAddrDB out of net.h/cpp
...
This will eventually solve a circular dependency
2016-09-08 12:03:22 -04:00
531214fb10
gui: add NodeID to the peer table
2016-09-08 12:03:22 -04:00
ddc308068d
Merge #8671 : Minimal fix to slow prevector tests as stopgap measure
...
f71d4a3
2016-09-08 11:12:50 +02:00
ec81881b86
Performance Regression Fix: Pre-Allocate txChanged vector
2016-09-07 20:10:50 -04:00
ec139a5621
Merge #8673 : Trivial: Fix obvious assignment/equality error in test
...
426e7bc
2016-09-07 19:36:43 +02:00
d6a5dc4a2e
add waitfornewblock/waitforblock/waitforblockheight rpcs and use them for tests
...
waitfornewblock waits until a new block is received, or the timeout expires, then
returns the current block height/hash.
waitforblock waits for a specific blockhash, or until the timeout expires, then
returns the current block height/hash. If the target blockhash is the current
tip, it will return immediately.
waitforblockheight waits until the tip has reached a certain height or higher,
then returns the current height and hash.
waitforblockheight is used to avoid polling in the rpc tests.
2016-09-07 12:46:01 -04:00
04802930d4
[Qt][CoinControl] fix UI bug that could result in paying unexpected fee
2016-09-07 16:05:27 +02:00
125b946cb4
Do not shadow upper local variable 'send', prevent -Wshadow compiler warning.
2016-09-07 13:45:13 +02:00
5b2ea29cf4
Merge #8594 : Do not add random inbound peers to addrman.
...
eb3596f
2016-09-07 13:19:53 +02:00
e2a1a1ee89
Merge #8606 : Fix some locks
...
144ed76
2016-09-07 13:10:10 +02:00
c015634400
qt: Adding transaction size to transaction details window
2016-09-06 22:31:36 +02:00
fdf82fba31
Adding method GetTotalSize() to CTransaction
...
GetTotalSize() returns the total transaction size (including witness) in
bytes.
2016-09-06 22:30:30 +02:00
426e7bce0e
Fix obvious assignment/equality error in test
2016-09-06 16:22:13 -04:00
f71d4a3786
Minimal fix to slow prevector tests as stopgap measure
2016-09-06 16:19:25 -04:00
d077f43f7e
Merge #8663 : trivial: remove unnecessary variable fDaemon
...
ff2ed7a
2016-09-06 15:20:08 +02:00
34521e4d7d
Do not store witness txn in rejection cache
2016-09-05 17:48:56 +02:00
e82fb872ff
Merge #8651 : Predeclare PrecomputedTransactionData as struct
...
4424af5
2016-09-05 13:30:09 +02:00
c40b034327
Clear witness with vin/vout in CWallet::CreateTransaction()
2016-09-04 20:09:13 -04:00
ff2ed7a5bc
trivial: remove unnecessary variable fDaemon
2016-09-04 11:42:07 -04:00
cbe9ae8c69
Merge #8466 : [Trivial] Do not shadow variables in networking code
...
b7c349d
2016-09-02 12:51:56 +02:00
381d0ddc8a
Merge #8449 : [Trivial] Do not shadow local variable, cleanup
...
a159f25cce3024
2016-09-02 12:25:59 +02:00
4424af5190
Predeclare PrecomputedTransactionData as sturct
2016-09-02 11:43:06 +02:00
6f939c9080
Merge #8629 : C++11: s/boost::scoped_ptr/std::unique_ptr/
...
cdd79eb
2016-09-02 09:56:33 +02:00
cdd79eb70f
C++11: s/boost::scoped_ptr/std::unique_ptr/
2016-09-01 19:05:07 +02:00
854f1af22e
Make the dummy argument to getaddednodeinfo optional
2016-09-01 16:27:30 +02:00
f061415d12
Merge #8638 : rest.cpp: change HTTP_INTERNAL_SERVER_ERROR to HTTP_BAD_REQUEST
...
f012a85
2016-09-01 15:58:43 +02:00
0e563d89c0
Merge #8472 : Do not shadow LOCK's criticalblock variable for LOCK inside LOCK
...
33d15a3
2016-09-01 14:42:00 +02:00
19b0f33de0
Merge #8524 : Precompute sighashes
...
35fe039ab48c5ed2c5d04
2016-09-01 12:20:43 +02:00
f012a857f5
rest.cpp: change HTTP_INTERNAL_SERVER_ERROR to HTTP_BAD_REQUEST
2016-09-01 22:12:19 +12:00
84decb54f2
Merge #8612 : Check for compatibility with download in FindNextBlocksToDownload
...
887919c
2016-08-31 17:59:56 +02:00
abc677c9a9
Merge #8191 : Do not shadow variables in src/wallet
...
b175cb7
2016-08-31 16:40:29 +02:00
5cac8b123e
Merge #8291 : [util] CopyrightHolders: Check for untranslated substitution
...
33336e1
2016-08-31 16:17:00 +02:00
b175cb755b
Do not shadow variables.
2016-08-31 16:16:05 +02:00
0c8875d23b
Merge #8163 : Do not shadow global RPC table variable (tableRPC)
...
de1bbe3
2016-08-31 16:07:58 +02:00
df3f12d409
Merge #8626 : Berkeley DB v6 compatibility fix
...
323a5fe
2016-08-31 14:42:45 +02:00
2b23dbaee5
Merge #8611 : Reduce default number of blocks to check at startup
...
203f212
2016-08-30 13:38:42 +02:00
323a5fe06a
Berkeley DB v6 compatibility fix
...
Fixes building error looking like this:
CXX wallet/libbitcoin_wallet_a-db.o
wallet/db.cpp: In member function ‘void CDBEnv::EnvShutdown()’:
wallet/db.cpp:46:16: error: call of overloaded ‘DbEnv(int)’ is ambiguous
DbEnv(0).remove(strPath.c_str(), 0);
^
wallet/db.cpp:46:16: note: candidates are:
In file included from wallet/db.h:21:0,
from wallet/db.cpp:6:
/usr/include/db_cxx.h:916:2: note: DbEnv::DbEnv(const DbEnv&)
DbEnv(const DbEnv &);
^
/usr/include/db_cxx.h:518:2: note: DbEnv::DbEnv(DB_ENV)
DbEnv(DB_ENV *dbenv);
^
/usr/include/db_cxx.h:516:2: note: DbEnv::DbEnv(u_int32_t)
DbEnv(u_int32_t flags);
^
Makefile:5780: recipe for target 'wallet/libbitcoin_wallet_a-db.o' failed
make[2]: ** [wallet/libbitcoin_wallet_a-db.o] Error 1
2016-08-30 09:00:55 +03:00
01680195f8
Merge #8564 : [Wallet] remove unused code/conditions in ReadAtCursor
...
beef966
2016-08-29 16:16:23 +02:00
a5bb6387f7
Merge #8607 : [doc] Fix doxygen off-by-one comments, fix typos
...
fafe7b3fa27c0afabfd5d67a5502
2016-08-28 16:06:03 +02:00
05e1c85fb6
Merge #8573 : Set jonasschnellis dns-seeder filter flag
...
40a95cf
2016-08-28 13:17:30 +02:00
203f2121be
Reduce default number of blocks to check at startup
2016-08-27 15:28:20 +02:00
887919c7b7
Check for compatibility with download in FindNextBlocksToDownload
2016-08-26 21:44:44 +02:00
144ed76ea0
Fix some locks
...
This makes sure that cs_filter is never held while taking cs_main
or CNode::cs_vSend.
2016-08-26 21:11:57 +02:00
35fe0393f2
Rename to PrecomputedTransactionData
2016-08-26 18:44:10 +02:00
9a0ed08b40
Merge #8109 : Do not shadow member variables
...
ff8d279
2016-08-26 18:13:22 +02:00
12892dbb9f
Merge #8590 : Remove unused variables
...
fa6dc9f
2016-08-26 13:24:12 +02:00
05fa823bf6
wallet: Add BIP125 comment for MAXINT-1/-2 behavior
2016-08-26 12:57:28 +02:00
152f45ba58
Add option to opt into full-RBF when sending funds
2016-08-26 12:10:42 +02:00
65837375d9
Merge #8581 : [wallet] rpc: Drop misleading option
...
fab5ecb
2016-08-26 11:21:55 +02:00
c19f8a4a77
Merge #8583 : Show XTHIN in GUI
...
4c3e2cb
2016-08-26 11:20:36 +02:00
6c9f1b8c24
Merge #8561 : Show "end" instead of many zeros when getheaders request received with a hashStop of Null
...
259ee09
2016-08-26 10:04:26 +02:00
eb3596f7c2
Do not add random inbound peers to addrman.
...
We should learn about new peers via address messages.
An inbound peer connecting to us tells us nothing about
its ability to accept incoming connections from us, so
we shouldn't assume that we can connect to it based on
this.
The vast majority of nodes on the network do not accept
incoming connections, adding them will only slow down
the process of making a successful connection in the
future.
Nodes which have configured themselves to not announce would prefer we
not violate their privacy by announcing them in GETADDR responses.
2016-08-25 23:48:59 +00:00
53f8f226bd
Merge #8462 : Move AdvertiseLocal debug output to net category
...
f13c1ba
2016-08-25 15:15:16 +02:00
de1bbe3b78
Do not shadow global RPC table variable (tableRPC)
2016-08-25 15:02:26 +02:00
fa6dc9f0e5
Remove unused variables
2016-08-25 14:59:38 +02:00
0606f95b1e
Merge #7579 : [Qt] show network/chain errors in the GUI
...
2f32c82
2016-08-25 14:55:26 +02:00
d26234a9e2
Merge #8487 : Persist the datadir after option reset
...
57acb8215df3c1
2016-08-25 11:42:57 +02:00
95a983d56d
Merge #8578 : [test] Remove unused code
...
fa1cf9e
2016-08-25 11:00:21 +02:00
026c6edac9
Merge #8282 : net: Feeler connections to increase online addrs in the tried table.
...
dbb1f64
2016-08-25 10:48:24 +02:00
4c3e2cb2df
Show XTHIN in GUI
2016-08-25 09:22:46 +07:00
fa1cf9e7b8
[test] Remove unused code
2016-08-24 20:21:31 +02:00
fab5ecb771
[wallet] rpc: Drop misleading option
2016-08-24 19:28:04 +02:00
57acb82e70
Load choose datadir dialog after options reset
2016-08-24 09:40:48 -04:00
62a5a8a018
Merge #8463 : [qt] Remove Priority from coincontrol dialog
...
fa8dd78
2016-08-24 13:58:43 +02:00
21857d2bf7
Merge #8450 : [Test] Replace rpc_wallet_tests.cpp with python RPC unit tests
...
957833325400c4
2016-08-24 12:10:42 +02:00
fa8dd785a2
[qt] Remove Priority from coincontrol dialog
2016-08-24 11:37:30 +02:00
f12d2b5a8a
Merge #8560 : Trivial: Fix two VarInt examples in serialize.h
...
7bd5ff4
2016-08-24 10:42:08 +02:00
f9167003d9
Merge #8445 : Move CWallet::setKeyPool to private section of CWallet.
...
8680d3ae86eb71
2016-08-24 10:33:16 +02:00
40a95cfd8f
Set jonasschnellis dns-seeder filter flag
2016-08-24 09:06:56 +02:00
dbb1f640e6
Added feeler connections increasing good addrs in the tried table.
...
Tests if addresses are online or offline by briefly connecting to them. These short lived connections are referred to as feeler connections. Feeler connections are designed to increase the number of fresh online addresses in tried by selecting and connecting to addresses in new. One feeler connection is attempted on average once every two minutes.
This change was suggested as Countermeasure 4 in
Eclipse Attacks on Bitcoin’s Peer-to-Peer Network, Ethan Heilman,
Alison Kendler, Aviv Zohar, Sharon Goldberg. ePrint Archive Report
2015/263. March 2015.
2016-08-23 16:26:42 -04:00
beef966e36
[Wallet] remove unused code/conditions in ReadAtCursor
2016-08-23 15:36:23 +02:00
15860448d3
[Qt] RPC-Console: support nested commands and simple value queries
...
Commands can be executed with bracket syntax, example: `getwalletinfo()`.
Commands can be nested, example: `sendtoaddress(getnewaddress(), 10)`.
Simple queries are possible: `listunspent()[0][txid]`
Object values are accessed with a non-quoted string, example: [txid].
Fully backward compatible.
`generate 101` is identical to `generate(101)`
Result value queries indicated with `[]` require the new brackets syntax.
Comma as argument separator is now also possible: `sendtoaddress,<address>,<amount>`
Space as argument separator works also with the bracket syntax, example: `sendtoaddress(getnewaddress() 10)
No dept limitation, complex commands are possible:
`decoderawtransaction(getrawtransaction(getblock(getbestblockhash())[tx][0]))[vout][0][value]`
2016-08-23 15:32:39 +02:00
259ee09f88
Show "end" instead of many zeros when getheaders request received with a hashStop of Null.
2016-08-23 13:14:07 +07:00
7bd5ff4623
Trivial: Fix two VarInt examples in serialize.h
2016-08-22 20:49:36 -04:00
41d8e78f94
Merge #8539 : CDB: fix debug output
...
fab2e26
2016-08-22 16:40:08 +02:00
fa27c0a2c4
[doc] Fix typos in comments, doxygen: Fix comment syntax
2016-08-22 10:51:41 +02:00
67a55025a1
init: Fix typo in help message for -whitelistforcerelay
...
Reported by pryds on Transifex in the Danish translation.
2016-08-22 10:51:13 +02:00
37e77c106c
Merge #8554 : trivial: remove unused variable
...
4207630
2016-08-22 10:36:37 +02:00
Cory Fields
MarcoFalke
Jeremy Rubin
Jonas Schnelli
Pavel Janík
Pieter Wuille
Hampus Sjöberg
Wladimir J. van der Laan
Suhas Daftuar
mruddy
Jorge Timón
djpnewton
Alexey Vesnin
Peter Todd
Gregory Maxwell
R E Broadley
Andrew Chow
Ethan Heilman
Christian Barcenas