b04f301c8e
Have bitcoind recommend a secure RPC password. Increase invalid password delay.
...
Help users avoid insecure configurations a bit by recommending a
secure RPC password and increasing the incorrect password delay.
This may open up a RPC DOS for users with exposed RPC ports and
short passwords. Since users shouldn't have exposed RPC ports OR
short passwords, the DOS risk is preferable to the compromise
risk.
Also logs the client IP address for incorrect attempts.
2012-02-05 02:58:35 -05:00
5d1b8f1725
Avoid advertising the node's address when it is not listening or IsInitialBlockDownload().
...
This also avoids flushing setAddrKnown until 24 hours has passed,
and avoids contacting the external IP services when not listening.
Advertising non-listening nodes is just addr message spam.
It doesn't help the network, in fact it hurts the network,
and it also hurts user's privacy.
Advertising far out of sync nodes doesn't help the network—
they can't even forward (most) transactions and wastes nodes
outbound slots.
2012-02-01 18:08:03 -05:00
d2291cce92
Remove loose amp; from Portugese translation (issue #701 )
2012-02-01 20:14:13 +01:00
8beb917c6c
Allow -upnp to override setting in wallet (and simplify logic a bit)
2012-02-01 13:24:15 -05:00
177dbcaace
Fix UPnP by reannouncing every 20 minutes.
2012-01-31 17:42:15 -05:00
c52296a73e
Testnet difficulty calculation changes, to take effect Feb 15 2012
...
Allow mining of min-difficulty blocks if 20 minutes have gone by without mining a regular-difficulty block.
Normal rules apply every 2016 blocks, though, so there may be a very-slow-to-confirm block at the difficulty-adjustment blocks.
2012-01-31 13:20:01 -05:00
4477b17f15
Merge branch 'checkkeys' of https://github.com/sipa/bitcoin
2012-01-31 12:19:26 -05:00
68649bef93
CreateNewBlock was not adding in transaction fees.
2012-01-28 10:16:21 -05:00
2bc4fd609c
Bitcoin-Qt signmessage GUI (pull request #582 )
2012-01-27 08:41:55 +01:00
91f43a33f8
Full checking of all loaded keys
2012-01-26 19:26:43 +01:00
70f55355e2
Merge pull request #593 (Full URL Support in bitcoin-qt)
2012-01-26 19:00:02 +01:00
4c932cca6f
Merge pull request #782 from sipa/checkkeys
...
Check consistency of private keys
2012-01-25 05:43:44 -08:00
b6a35d2d52
Merge pull request #773 from gavinandresen/p2shSigOpCount
...
Simplify counting of P2SH sigops to match BIP 16
2012-01-25 05:21:20 -08:00
b25cc627a3
Check consistency of private keys
...
Reported by onlineproof on IRC: Bitcoin does not verify whether private
keys and public keys correspond, when loading a wallet.
2012-01-25 03:05:16 +01:00
341519523f
Support makefile.osx building test_bitcoin with dynamic boost
2012-01-23 15:58:06 -05:00
2a9b46cf4b
Merge branch 'bugfix_shared_boost_test' of https://github.com/luke-jr/bitcoin
2012-01-23 15:16:59 -05:00
34c69036da
Rename src/obj/test to src/obj-test to workaround bug in older GNU Make
2012-01-23 14:27:08 -05:00
a702ceaafc
Merge branch 'lockcontention' of https://github.com/TheBlueMatt/bitcoin
2012-01-23 13:15:43 -05:00
b8056dc5d0
Merge branch 'bugfix_areinpstd' of https://github.com/luke-jr/bitcoin
2012-01-23 13:09:34 -05:00
149f580c82
Only store transactions with missing inputs in the orphan pool.
...
All previous versions of bitcoin could store some types of
invalid transactions in the orphan-transaction list.
2012-01-23 12:54:32 -05:00
dc77dce07c
Fixed addmultisigaddress if looking up public keys from locked wallets.
2012-01-23 12:04:34 -05:00
ca9afa8401
Bugfix: Support building test_bitcoin with shared-object boost test framework
2012-01-23 11:37:48 -05:00
198fb229a4
Add DEBUG_LOCKCONTENTION, to warn each time a thread waits to lock.
...
If compiled with -DDEBUG_LOCKCONTENTION, Bitcoin will print to
debug.log each time a thread has to wait for a lock to continue.
2012-01-21 16:16:28 -05:00
575bdcde93
Sanitize AreInputsStandard slightly
...
Correct comment for why the check is unnecessary for coinbases
Move testnet check out, to AcceptToMemoryPool where everything else checks it
2012-01-20 21:00:08 -05:00
137d0685a4
Simplify counting of P2SH sigops to match BIP 16 (thanks to Matt Corallo for prompting this).
...
This also removes an un-needed sigops-per-byte check when accepting transactions to the memory pool (un-needed assuming only standard transactions are being accepted). And it only counts P2SH sigops after the switchover date.
2012-01-20 17:07:40 -05:00
1240a1b0a8
Back out spacing changes to json spirit code
2012-01-19 14:32:45 -05:00
7012b124bc
Merge branch 'updateseednodes' of https://github.com/nanotube/bitcoin
2012-01-19 14:23:49 -05:00
c55fd06b99
Merge branch 'tabs-to-space' of https://github.com/larsr/bitcoin
2012-01-19 14:22:26 -05:00
aacefd2795
Merge branch 'getmemorypool_blockflagstime' of https://github.com/forrestv/bitcoin
2012-01-19 14:14:41 -05:00
39f0d96860
Make transactions with extra data in their scriptSig's non-standard.
2012-01-19 13:30:54 -05:00
b2f76e9ded
Update seednodes, pick long-uptime nodes with version >= 0.4.0
2012-01-19 01:54:14 -05:00
06706ab8ef
Remove erroneous ":" in front of port in options dialog (introduced with network refactor)
2012-01-17 09:34:24 +01:00
be4d08b261
fix the build (port IP validation in options to network refactoring)
2012-01-17 09:27:03 +01:00
b2a967cd0b
Revert to global progress indication (see #753 )
2012-01-17 09:19:58 +01:00
c981d768b3
Fix handling of default ports
2012-01-17 02:12:35 +01:00
8498c59144
Merge branch 'keepnode' of https://github.com/TheBlueMatt/bitcoin
2012-01-16 16:45:43 -05:00
ab84512258
Added mintime and curtime to RPC getmemorypool
2012-01-14 19:23:37 -05:00
52a3d2635c
Separated COINBASE_FLAGS out into main.h and made RPC getmemorypool return it
2012-01-14 19:22:24 -05:00
29b7273153
*Clear all has a tooltip now *About dialog updated
2012-01-14 21:31:49 +02:00
b985efaac1
Replace tabs with four spaces to comply with coding standard in doc/coding.txt
2012-01-14 12:14:36 +01:00
9e8818ec9d
Remove base58 encoding from validateaddress/addmultisigaddress
...
base58-encoding of full/compressed public keys needs more thought; it probably makes sense to define a base58 encoding that includes a version byte and a checksum. So just support hex and bitcoin-address encodings for now.
2012-01-13 10:22:24 -05:00
4063460534
Refactor: needing to call ConnectInputs to process coinbase transactions was counter-intuitive
2012-01-13 10:22:24 -05:00
8d7849b6db
Refactored ConnectInputs, so valid-transaction-checks are done before ECDSA-verifying signatures.
2012-01-13 10:22:24 -05:00
922e8e2929
Replace OP_EVAL (BIP 12) with Pay-to-script-hash (BIP 16).
2012-01-13 10:22:23 -05:00
d11a58a2d3
Remove not-used-anywhere scriptPrereq from SignSignature()
2012-01-13 10:20:42 -05:00
f290a649f9
Merge branch 'getmininginfo' of https://github.com/luke-jr/bitcoin
2012-01-13 10:06:05 -05:00
10ba0a3efc
Minor code cleanup to use fHaveUPnP instead of #ifdef
2012-01-12 22:13:16 -05:00
b24e6e4d1b
Add -keepnode which attempts to -addnode and keep a connection open
2012-01-12 22:13:16 -05:00
a1de57a063
Compile with extra warnings turned on. And more makefile/code tidying up.
...
This turns on most gcc warnings, and removes some unused variables and other code that triggers warnings.
Exceptions are:
-Wno-sign-compare : triggered by lots of comparisons of signed integer to foo.size(), which is unsigned.
-Wno-char-subscripts : triggered by the convert-to-hex functions (I may fix this in a future commit).
2012-01-12 20:02:47 -05:00
340f0876ea
collect more info on tx pooling and block finding for getmininginfo
2012-01-12 19:47:39 -05:00
6950bb6200
Add new "getmininginfo" JSON-RPC method, with mining-only fields moved out of "getinfo"
2012-01-12 19:47:23 -05:00
025d495481
Remove broken Visual C++ makefile.vc, and removed annoying HEADERS= list from other makefiles
2012-01-12 16:55:44 -05:00
3f64fa1369
Merge pull request #743 from gavinandresen/blocknotify
...
-blocknotify : run a command when best-block changes
2012-01-12 06:31:25 -08:00
afcf6f974f
Merge pull request #649 from sipa/comprpubkey
...
Compressed pubkeys
2012-01-10 13:23:51 -08:00
b43eaa5508
Merge pull request #752 from luke-jr/qt_txnid
...
Qt: Show transaction ID in details
2012-01-10 11:51:55 -08:00
ebf9065c22
Qt: Show transaction ID in details
2012-01-10 13:25:05 -05:00
a4902c9e7c
Remove unused definition
2012-01-09 23:39:26 +01:00
2e555237d3
Merge pull request #746 from laanwj/tdesc_ro
...
make transaction description read-only (UI fix)
2012-01-09 07:59:18 -08:00
b3974ec9d4
Unit tests for EC key routines
...
This tests:
* creation of keys from base58-encoded strings
* extracting public keys and addresses
* compressed public keys
* compact signatures and key recovery
2012-01-09 15:18:19 +01:00
d4d9c734c3
Compact signatures with compressed pubkeys
2012-01-09 15:18:19 +01:00
11529c6e4f
Compressed pubkeys
...
This patch enabled compressed pubkeys when -compressedpubkeys is passed.
These are 33 bytes instead of 65, and require only marginally more CPU
power when verifying. Compressed pubkeys have a different corresponding
address, so it is determined at generation. When -compressedpubkeys is
given, all newly generated addresses will use a compressed key, while
older/other addresses keep using normal keys. Unpatched clients will
relay and verify these transactions.
2012-01-09 15:18:19 +01:00
67a42f929b
Network stack refactor
...
This introduces CNetAddr and CService, respectively wrapping an
(IPv6) IP address and an IP+port combination. This functionality used
to be part of CAddress, which also contains network flags and
connection attempt information. These extra fields are however not
always necessary.
These classes, along with logic for creating connections and doing
name lookups, are moved to netbase.{h,cpp}, which does not depend on
headers.h.
Furthermore, CNetAddr is mostly IPv6-ready, though IPv6
functionality is not yet enabled for the application itself.
2012-01-06 18:55:37 +01:00
7453497ee4
make transaction description read-only (UI fix)
2012-01-06 06:57:14 +01:00
7d145a0f59
Add support for opening bitcoin: URIs directly.
2012-01-05 00:29:28 -05:00
9a93c4c024
Automatically refocus on new SendCoinsEntrys and scroll to them.
2012-01-05 00:29:28 -05:00
f7a9a11391
Fix horrific performance found by gmaxwell.
2012-01-04 19:46:16 -05:00
d237f62c23
-blocknotify=command argument, implemented using system() and boost::thread
2012-01-03 15:48:59 -05:00
96d3bcb996
Merge pull request #731 from laanwj/txshowfix
...
Fix transaction type in UI
2012-01-03 09:24:54 -08:00
af8c56f8be
Merge branch 'getblock'
2012-01-03 12:16:56 -05:00
8677f9c751
I broke -testnet with my TOR option-parsing fixes.
2012-01-03 11:17:24 -05:00
112b0e97d4
Merge pull request #741 from laanwj/typo734fix
...
Fix typo (#734 )
2012-01-03 07:54:38 -08:00
73e86eedd5
Merge branch 'bugfix_multisig' of https://github.com/coderrr/bitcoin
2012-01-03 10:23:20 -05:00
daad9a9a71
Merge branch 'gitianfix' of https://github.com/TheBlueMatt/bitcoin
2012-01-03 10:22:24 -05:00
0fcf91ea1e
Fix issue #659 , and cleanup wallet/command-line argument handling a bit
2012-01-03 10:17:28 -05:00
ecaa91d1df
Fix typo ( #734 )
2012-01-03 11:57:24 +01:00
a75d7066b8
Fix some address-handling deadlocks
...
Made three critical blocks for cs_mapAddresses smaller, and moved
writing to the database out of them. This should also improve the
concurrency of the code.
2012-01-03 02:01:56 +01:00
6ec76ca09e
make sure IsMine only returns true when we own all keys
2012-01-03 06:24:52 +07:00
56c6e3696d
Fix transaction type in UI: not all tx'es with "from"/"to" field are necessarily IP tx'es
...
- Also, prepare for OP_EVAL by calling all transactions without bitcoin address "SendToOther"/"RecvFromOther",
(IP tx'es are so rare they can be put together with funky EV_EVAL scripts)
2011-12-28 11:14:05 +01:00
625b56de64
Merge branch 'opevalcountfix' of https://github.com/laanwj/bitcoin
2011-12-27 16:42:29 -05:00
6d6d392b22
Fixed OP_EVAL recursion unit test, checks for both infinite and exactly-3-deep recursion
2011-12-27 16:41:56 -05:00
89772f932a
Fix OP_EVAL recursion depth counting
2011-12-27 10:02:28 +01:00
61977f956c
Check all prevout.n if one transaction provides multiple inputs
2011-12-25 10:32:05 -05:00
60835d9627
assert condition in previous commit was backwards
2011-12-25 10:08:01 -05:00
6996a9d713
Check for valid prevout.n in FetchInputs.
...
IsStandardInputs could crash if given invalid input index.
2011-12-25 08:45:09 -05:00
56690a69d6
No reason to have any qrcode stuff in the bitcoind osx makefile.
2011-12-23 15:28:35 -08:00
fe358165e3
Be more conservative: check all transactions in blocks after last checkpoint.
2011-12-23 17:13:10 -05:00
8a53cb0b9d
New RPC commands: getblockhash and getblock
2011-12-23 16:26:38 -05:00
c58e7d4e01
Copy amount to clipboard (implements #657 )
...
- Also, unify similar code related to copying transaction fields to clipboard
2011-12-23 12:07:23 +01:00
c4a4a4b886
Add context menu for address book page (implements part 1 of issue #648 )
2011-12-23 12:07:23 +01:00
e073457191
Move HtmlEscape (escape for qt rich text controls) to qt gui utilities
2011-12-23 12:07:23 +01:00
c75abc9f7e
Comments update
2011-12-23 12:07:23 +01:00
96b1e085c3
Merge pull request #629 from sje397/master
...
QR Code generation via libqrencode
2011-12-23 02:50:28 -08:00
2e17ac83c6
Fix broken ExtractAddress (refactored, made callers check for addresses in keystore if they care)
2011-12-22 15:57:31 -05:00
ce336fdc21
Back out testnet default address change, it breaks accounts on old wallets.
2011-12-22 15:56:45 -05:00
bde280b9a4
Revert "Use standard C99 (and Qt) types for 64-bit integers"
...
This reverts commit 21d9f36781
2011-12-21 22:33:19 +01:00
21d9f36781
Use standard C99 (and Qt) types for 64-bit integers
2011-12-20 16:52:59 -05:00
781c06c0f5
Merge pull request #677 from luke-jr/minfee_modes
...
API: GetMinFee modes
2011-12-20 13:09:18 -08:00
595925592d
Merge branch 'op_eval'
2011-12-20 14:43:31 -05:00
f06e3e0ea6
Merge pull request #717 from TheBlueMatt/installerqtupgrade
...
Implement "Start on window system startup" on Win32 + Linux.
2011-12-20 11:42:53 -08:00
f18a119ac0
Implement "Start on window system startup" on Win32 + Linux.
2011-12-20 13:51:06 -05:00
77f21f1583
include util.h to get SecureString definition.
2011-12-20 12:21:47 -05:00
0e87f34bed
Include limits, not climints (using std::numeric_limits now)
2011-12-20 12:04:33 -05:00
387c8e3c5b
Merge pull request #673 from mndrix/less-time-data
...
Store fewer time samples
2011-12-20 08:55:55 -08:00
22123c85f3
Added QRCode generation functions via libqrencode. Switch on with USE_QRENCODE=1.
...
Amended build docs for Linux and OSX, and OSX makefile.
Added package 'qrencode' to gitian.yml
2011-12-20 22:11:24 +11:00
9ef7fa3447
Code cleanup: use ECDSA_size() instead of fixed 10,000 byte sig buffer, and explicity init static var
2011-12-19 19:10:34 -05:00
26ce92b352
Use std::numeric_limits<> for typesafe INT_MAX/etc
2011-12-19 19:10:34 -05:00
bd846c0e56
Cleanup: removed dead code, and use C99 typedefs for int64 (supported by all modern c++ compilers)
2011-12-19 19:10:34 -05:00
3528650560
Merge pull request #690 from runeksvendsen/qt-cmdline-options-parsing
...
When using Qt GUI, move parameter-parsing to start of qt/bitcoin.cpp:main()
2011-12-19 12:23:00 -08:00
bafb43d6c1
Merge branch 'txn_block_info' of https://github.com/luke-jr/bitcoin
2011-12-19 15:14:22 -05:00
9e470585b3
Update bitcoin address numbers for latest luke-jr/sipa scheme
2011-12-19 13:24:51 -05:00
be237c119e
Fix logic for IsChange() for send-to-self transactions.
2011-12-19 13:24:49 -05:00
2a45a494b0
Use block times for 'hard' OP_EVAL switchover, and refactored EvalScript
...
so it takes a flag for how to interpret OP_EVAL.
Also increased IsStandard size of scriptSigs to 500 bytes, so
a 3-of-3 multisig transaction IsStandard.
2011-12-19 13:24:48 -05:00
a0871afb2b
Interpret OP_EVAL as OP_NOP until Feb 1, 2012
2011-12-19 13:24:48 -05:00
fae3e2aab6
Disable addmultisigaddress if not testnet
2011-12-19 13:24:48 -05:00
d7062ef1bd
Put OP_EVAL string in coinbase of generated blocks
2011-12-19 13:24:48 -05:00
3ae65166b5
add key.o and rpcdump.o to makefile.linux-mingw
2011-12-19 19:20:53 +01:00
e679ec969c
OP_EVAL implementation
...
OP_EVAL is a new opcode that evaluates an item on the stack as a script.
It enables a new type of bitcoin address that needs an arbitrarily
complex script to redeem.
2011-12-19 12:40:19 -05:00
cc40ba2151
Global fixture to send output to console instead of debug.log
2011-12-19 12:40:19 -05:00
bf798734db
Support 3 new multisignature IsStandard transactions
...
Initial support for (a and b), (a or b), and 2-of-3 escrow
transactions (where a, b, and c are keys).
2011-12-19 12:40:19 -05:00
1466b8b78a
Rework unit tests so test_bitcoin.cpp does not #include them all
2011-12-19 12:39:47 -05:00
7e55c1ab65
Collapse no-op ExtractAddress/ExtractAddressInner
2011-12-19 12:39:47 -05:00
99a289f531
Merge pull request #574 from sipa/dumpprivkey
...
Dumpprivkey
2011-12-19 07:27:25 -08:00
fc90967876
Merge pull request #699 from laanwj/about_qt
...
Add "About Qt" menu option to show built-in Qt About dialog
2011-12-19 07:26:14 -08:00
1f3bc1c239
Merge pull request #707 from gavinandresen/BIP14
...
Implement BIP 14 : separate protocol version from client version
2011-12-19 07:25:16 -08:00
f8ded588a2
Implement BIP 14 : separate protocol version from client version
2011-12-19 10:24:23 -05:00
cd2b8832fd
Merge pull request #709 from luke-jr/newdnsseeds
...
New DNS seeds
2011-12-19 07:12:30 -08:00
95d888a6d1
Key import and export
...
Introduces two new RPC calls:
* dumpprivkey: retrieve the private key corresponding to an address
* importprivkey: add a private key to your wallet
The private key format is analoguous to the address format. It is
a 51-character base58-encoded string, that includes a version number
and a checksum.
Includes patch by mhanne:
* add optional account parameter for importprivkey, if omitted use default
2011-12-17 21:49:48 +01:00
30ab2c9c46
Preparations for key import/export
2011-12-17 21:49:48 +01:00
15a8590ecf
CBitcoinSecret added (base58 encoded privkey)
2011-12-17 21:49:48 +01:00
93db3fceac
Add GetSecret() and GetKeys() to CKeyStore
2011-12-17 21:49:47 +01:00
4c6e22953e
Make CWalletTx::pwallet private
2011-12-17 21:49:47 +01:00
cce16fdc68
Add blockhash and blockindex to transaction info
2011-12-16 19:05:41 -05:00
647734881c
Add my DNS seed domain
2011-12-16 18:34:47 -05:00
6e39e7c9b3
Move more newlines out of strings, and fix translations.
2011-12-16 17:13:45 -05:00
ab6c45372c
Merge branch 'fix-help-translations' of https://github.com/tcatm/bitcoin
2011-12-16 16:37:24 -05:00
8896c2d9d6
Bump version 0.5.99 (prep for pulling for version 0.6)
2011-12-16 12:31:59 -05:00
61a8c0569e
Add sipa's new dnsseed.
2011-12-16 11:30:36 -05:00
dbbf1d4a48
GetMinFee takes a mode parameter (GMF_{BLOCK,RELAY,SEND}) instead of fForRelay
2011-12-14 01:07:43 -05:00
a880b29cab
Bugfix: fForRelay should be false when deciding required fee to include in blocks
...
During the rushed transition from 0.01 BTC to 0.0005 BTC fees, we took the
approach of dropping the relay and block-inclusion fee to 0.0005 BTC
immediately, and only delayed adjusting the sending fee for the next release.
Afterward, the relay fee was lowered to 0.0001 BTC to avoid having the same
problem in the future. However, the block inclusion code was left setting
fForRelay to true! This fixes that, so the lower 0.0001 BTC allowance is (as
intended) only permitted for real relaying.
2011-12-14 01:06:21 -05:00
7ca47cece7
Fix status bar not displaying Alerts.
2011-12-13 15:29:17 -05:00
01ea41b203
Add "About Qt" menu option to show built-in Qt About dialog
...
- Most Qt programs do this, and it can be useful to find out what version of Qt was built against.
2011-12-13 17:35:17 +01:00
857aa73783
Enable wordwrap for long message in passphrase dialog
...
- Remove explicit resizing from constructor to prevent potential hang
2011-12-13 16:32:25 +01:00
43421af2e4
move \\n outside _() in --help
2011-12-13 06:46:37 +01:00
5491c310a6
Merge commit '7298ebb'
2011-12-12 15:03:16 -05:00
1d8b4cd544
added translations: pt_BR zh_CN
2011-12-12 20:56:34 +01:00
7ad4ca9c17
updated translations: es es_CL nb ru
2011-12-12 20:53:18 +01:00
ca287d66f2
Merge pull request #694 from luke-jr/restore_old_miniupnp_compat
...
Restore compatibility with miniupnpc 1.5 (without breaking miniupnp 1.6)
2011-12-12 11:32:48 -08:00
94b97046fd
Restore compatibility with miniupnpc 1.5 (without breaking miniupnp 1.6)
2011-12-10 11:52:50 -05:00
45198af2be
Prevent window from being shown momentarily when using -min
...
- In a previous patch, show() was added to all the page switcher functions. As the contructor calls showOverviewPage(), this means the window is shown in the constructor.
- This change prevents this by connecting show() to the signal instead.
2011-12-09 22:41:19 +01:00
4dba26620c
When using Qt GUI, move parameter-parsing to start of qt/bitcoin.cpp:main()
2011-12-09 19:19:27 +01:00
Gregory Maxwell
Wladimir J. van der Laan
Gavin Andresen
Matt Corallo
Luke Dashjr
Pieter Wuille
Daniel Folkinshteyn
Pieter Wuille
Forrest Voight
Janne Pulkkinen
Lars Rasmusson
coderrr
sje397
Nils Schneider
Rune K Svendsen