27a0ed8a0a
Hide tray icon in destructor, as deleting will let it linger until quit (on Ubuntu)
2012-02-19 12:07:07 +01:00
fcfd7ff8f8
Free pwalletdbEncryption after encryping wallet
...
Fixes a memory leak.
2012-02-18 15:44:34 +01:00
38067c18f8
Make compressed pubkeys require 0.6.0
2012-02-18 15:42:38 +01:00
9976cf070f
Move GenerateNewKey back to CWallet
2012-02-18 15:42:38 +01:00
0b807a417f
Add SetMinVersion to CWallet
2012-02-18 15:42:29 +01:00
e9a041c536
Merge pull request #862 from TheBlueMatt/warnings
...
Fix compilation warning.
2012-02-18 04:56:58 -08:00
a06113b0c5
Workaround for BN_bn2mpi reading/writing out of bounds
...
When OpenSSL's BN_bn2mpi is passed a buffer of size 4, valgrind
reports reading/writing one byte past it. I am unable to find
evidence of this behaviour in BN_bn2mpi's source code, so it may
be a spurious warning. However, this change is harmless, as only
the bignum with value 0 results in an mpi serialization of size 4.
2012-02-18 13:32:25 +01:00
2d36b60f92
Merge pull request #859 from laanwj/2012_02_guilanguagearg
...
Make it possible to set UI language from commandline (implements #678 )
2012-02-18 01:33:56 -08:00
db1a5609a0
Fix compilation warning.
2012-02-18 01:22:22 -05:00
17690ea5a7
Do show/showNormal only when needed.
2012-02-17 23:19:52 +01:00
328512876a
Merge pull request #854 from laanwj/2012_02_qtipc
...
Restructure IPC URL handling (fixes #851 )
2012-02-17 12:54:07 -08:00
d3a4b85670
Merge branch 'nolisten_bitcoin_conf_2' of https://github.com/dooglus/bitcoin
2012-02-17 13:50:40 -05:00
0a6b081cca
Merge branch 'testnetmining' of github.com:gavinandresen/bitcoin-git
2012-02-17 13:48:01 -05:00
25bc37f8a2
Merge branch 'threadid' of https://github.com/sipa/bitcoin
2012-02-17 13:40:42 -05:00
ec2ed58232
Merge pull request #834 from sje397/BackupWallet
...
Added 'Backup Wallet' menu option to GUI
2012-02-17 10:30:15 -08:00
72075edafb
Allow setting UI language from commandline (implements #678 )
2012-02-17 18:47:31 +01:00
f9f75f320e
Only fill in label from address book, if no label is filled in yet, fixes #840
2012-02-17 18:25:14 +01:00
a3f3e54eee
Change #ifdef GUI to #ifdef QT_GUI, GUI is not defined anymore...
2012-02-17 18:01:01 +01:00
bc5e6b9f21
On windows, show message box with help, as there is no stderr ( fixes #702 )
2012-02-17 17:55:46 +01:00
83d1d1a906
Hide window from taskbar when "minimize to tray" active by making window into Tool window
2012-02-17 17:14:02 +01:00
23b3cf9d10
Restructure IPC URL handling ( fixes #851 )
2012-02-17 15:32:51 +01:00
39231e9105
don't allow -daemon in bitcoin-qt (changes only #defines)
2012-02-17 14:47:56 +01:00
d3896211d2
fix typo in CNetAddr::IsRFC4843() ( fixes #850 )
2012-02-17 14:40:21 +01:00
d64e124cf4
Fix #846 . Allow negative options such as "nolisten=1" in bitcoin.conf as well as on the command line.
2012-02-16 12:08:58 -08:00
0f8cb5db73
Fix issue #848 : broken mining on testnet
2012-02-16 11:37:54 -05:00
b7c25e0c13
Merge pull request #843 from TheBlueMatt/qrcodedoc
...
Fix one compile-time warning and fix libqrcode linking in releases
2012-02-16 03:50:59 -08:00
c59881eaee
Symbolic names for threads
...
Introduce an enum threadId, and use symbolic indices when accessing
vnThreadsRunning.
2012-02-16 12:43:06 +01:00
999b4cacaf
Merge pull request #844 from sipa/shutdownfix
...
Several shutdown-related fixes
2012-02-16 03:34:11 -08:00
2030fc6bc2
Merge pull request #842 from sipa/checkaf
...
Do not create CAddress for invalid accepts
2012-02-16 03:31:14 -08:00
711d5038f5
Merge pull request #828 from sipa/fixwalletlock
...
Fix wallet locking locking
2012-02-16 03:30:26 -08:00
7dcd200489
Properly include $*_LIB_PATH in makefile.unix
2012-02-15 16:39:02 -05:00
32af6b16f1
Fix compilation warning.
2012-02-15 16:38:57 -05:00
cc201e01f8
Several shutdown-related fixes
...
* do not let vnThreadsRunning[1] go negative
* do not perform locking operations while vnThreadsRunning[1] is decreased
* check vnThreadsRunning[1] at exit
2012-02-15 21:17:15 +01:00
25ab17585e
Bugfix: do not create CAddress for invalid accepts
2012-02-15 20:56:29 +01:00
303a47c095
fix default suffixes in save dialog in GNOME, make it more clear that PNG is used (solves #833 )
2012-02-15 17:22:00 +01:00
c85c37acb1
increase BitcoinAddressValidator::MaxAddressLength from 34 to 35
...
needed for sending BIP16 transactions on test network through GUI
2012-02-15 17:09:47 +01:00
4efbda3f25
Added 'Backup Wallet' menu option
...
- icon from the LGPL Nuvola set (like the tick) - http://www.icon-king.com/projects/nuvola/
- include 'boost/version.hpp' in db.cpp so that the overwrite version of copy can be used
- catch exceptions in BackupWallet (e.g. filesystem_error thrown when trying to overwrite without the overwrite flag set)
- include db.h in walletmodel.cpp for BackupWallet function
- updated doc/assets-attribution.txt and contrib/debian/copyright with copyright info for new icon
2012-02-15 23:29:59 +11:00
1df182ff88
(trivial) regularize coding style
2012-02-15 13:14:16 +01:00
15b87b2ec4
Merge pull request #807 from TheBlueMatt/bip21
...
Add req- prefixes to comply with BIP21.
2012-02-12 05:52:34 -08:00
d27b4576f3
Add export action to file menu (as long as we have a file menu, export certainly should be there)
2012-02-12 12:54:33 +01:00
2aa3429899
Merge pull request #826 from laanwj/2012_02_fixminimizetotray
...
Fix Minimize to the tray instead of the taskbar (rework)
2012-02-12 01:49:18 -08:00
9f3de58d83
Merge pull request #817 from TheBlueMatt/dpiversionfix
...
Get ext. IP from UPnP, make sure addrMe IsRoutable() in version.
2012-02-11 15:14:02 -08:00
7c39b56c3b
Merge pull request #827 from sipa/fixencrypt
...
Fix wallet encryption with compressed pubkeys
2012-02-11 15:02:05 -08:00
aa625ed6ed
Extra wallet locking fixes
...
* Fix sign error in calculation of seconds to sleep
* Do not mix GetTime() (seconds) and Sleep() (milliseconds)
* Do not sleep forever if walletlock() is called
* Do locking within critical section
2012-02-11 21:59:39 +01:00
b0529ffd95
Fix wallet locking locking
2012-02-11 21:59:39 +01:00
88bc5f9485
Macros for manual critical sections
2012-02-11 21:59:33 +01:00
6af93ee2ea
Fix Minimize to the tray instead of the taskbar
2012-02-11 18:24:49 +01:00
cd5ee3bbb4
Fix wallet encryption with compressed pubkeys
2012-02-11 16:42:44 +01:00
402deef944
Fix #822
2012-02-11 15:25:42 +01:00
245484679a
Add Bitcoin-Qt test suite with some bitcoin: URL Tests to start.
2012-02-10 17:47:00 -05:00
cce89ead18
Add -req prefixes to comply with BIP21.
2012-02-10 17:44:52 -05:00
26d9e2c19d
Merge pull request #818 from laanwj/2012_02_win32_qtaccessible
...
Enable accessible widgets Qt module on win32
2012-02-10 09:31:21 -08:00
2e5a781c64
Enable accessible widgets Qt module on win32, so that people with screen readers such as NVDA can make sense of it.
2012-02-10 08:28:32 +01:00
baba6e7de2
Get ext. IP from UPnP, make sure addrMe IsRoutable() in version.
...
This fixes a potential bug where some NATs may replace the node's
interal IP with its external IP in version messages, causing
incorrect checksums when version messages begin being checksummed
on February 14, 2012.
2012-02-10 00:54:11 -05:00
74f28bf1fd
Fix #794 . Only remove transactions from memory pool when they're actually in the memory pool.
2012-02-09 05:21:41 -08:00
882164196e
Update all copyrights to 2012
2012-02-07 11:28:30 -05:00
6bf4253a68
Increase client version to 0.6
2012-02-07 11:22:09 -05:00
9d952d17bb
Look for flushwallet/listen/irc/dnsseed/upnp instead of noflushwallet/etc. And switch default for irc to 0.
2012-02-07 09:14:31 -05:00
3ad9f8a70f
New GetArg features: allow --, and booleans can be -foo or -nofoo
2012-02-07 09:14:31 -05:00
3ae0735553
Unit tests for the GetArg() methods
2012-02-07 09:14:31 -05:00
0b452dff5e
Merge branch 'standardScriptSigs' of github.com:gavinandresen/bitcoin-git
2012-02-07 09:04:56 -05:00
7bf8b7c25c
-bip16 option (default: 1) to support / not support BIP 16. And bumped default BIP16 switchover date from Feb 15 to Mar 1
2012-02-06 16:27:05 -05:00
0b9a05a2bc
Merge branch 'rpcpassword' of https://github.com/gmaxwell/bitcoin
2012-02-06 15:10:30 -05:00
30999ec6f9
Merge branch 'decomposetransfix' of https://github.com/laanwj/bitcoin
2012-02-06 14:50:59 -05:00
ab07866c8d
Restructure credit transaction decomposition (solves issue #689 )
...
When a transaction has multiple outputs that go to the wallet, list these
as multiple transactions in the UI. This is also applied to generated
(coinbase) transactions. Also makes the code shorter and easier
to understand.
2012-02-06 18:13:01 +01:00
9d4b05c0dc
fetch translations from transifex
...
* fixes issue #742
* new translations: cs_CZ fa fi fr_FR hr pl ro_RO sv tr
2012-02-05 16:40:27 +01:00
f69b82e78a
Change up/down increment in UI to 0.001 BTC (issue #760 )
2012-02-05 12:15:16 +01:00
b04f301c8e
Have bitcoind recommend a secure RPC password. Increase invalid password delay.
...
Help users avoid insecure configurations a bit by recommending a
secure RPC password and increasing the incorrect password delay.
This may open up a RPC DOS for users with exposed RPC ports and
short passwords. Since users shouldn't have exposed RPC ports OR
short passwords, the DOS risk is preferable to the compromise
risk.
Also logs the client IP address for incorrect attempts.
2012-02-05 02:58:35 -05:00
5d1b8f1725
Avoid advertising the node's address when it is not listening or IsInitialBlockDownload().
...
This also avoids flushing setAddrKnown until 24 hours has passed,
and avoids contacting the external IP services when not listening.
Advertising non-listening nodes is just addr message spam.
It doesn't help the network, in fact it hurts the network,
and it also hurts user's privacy.
Advertising far out of sync nodes doesn't help the network—
they can't even forward (most) transactions and wastes nodes
outbound slots.
2012-02-01 18:08:03 -05:00
d2291cce92
Remove loose amp; from Portugese translation (issue #701 )
2012-02-01 20:14:13 +01:00
8beb917c6c
Allow -upnp to override setting in wallet (and simplify logic a bit)
2012-02-01 13:24:15 -05:00
177dbcaace
Fix UPnP by reannouncing every 20 minutes.
2012-01-31 17:42:15 -05:00
c52296a73e
Testnet difficulty calculation changes, to take effect Feb 15 2012
...
Allow mining of min-difficulty blocks if 20 minutes have gone by without mining a regular-difficulty block.
Normal rules apply every 2016 blocks, though, so there may be a very-slow-to-confirm block at the difficulty-adjustment blocks.
2012-01-31 13:20:01 -05:00
4477b17f15
Merge branch 'checkkeys' of https://github.com/sipa/bitcoin
2012-01-31 12:19:26 -05:00
68649bef93
CreateNewBlock was not adding in transaction fees.
2012-01-28 10:16:21 -05:00
2bc4fd609c
Bitcoin-Qt signmessage GUI (pull request #582 )
2012-01-27 08:41:55 +01:00
91f43a33f8
Full checking of all loaded keys
2012-01-26 19:26:43 +01:00
70f55355e2
Merge pull request #593 (Full URL Support in bitcoin-qt)
2012-01-26 19:00:02 +01:00
4c932cca6f
Merge pull request #782 from sipa/checkkeys
...
Check consistency of private keys
2012-01-25 05:43:44 -08:00
b6a35d2d52
Merge pull request #773 from gavinandresen/p2shSigOpCount
...
Simplify counting of P2SH sigops to match BIP 16
2012-01-25 05:21:20 -08:00
b25cc627a3
Check consistency of private keys
...
Reported by onlineproof on IRC: Bitcoin does not verify whether private
keys and public keys correspond, when loading a wallet.
2012-01-25 03:05:16 +01:00
341519523f
Support makefile.osx building test_bitcoin with dynamic boost
2012-01-23 15:58:06 -05:00
2a9b46cf4b
Merge branch 'bugfix_shared_boost_test' of https://github.com/luke-jr/bitcoin
2012-01-23 15:16:59 -05:00
34c69036da
Rename src/obj/test to src/obj-test to workaround bug in older GNU Make
2012-01-23 14:27:08 -05:00
a702ceaafc
Merge branch 'lockcontention' of https://github.com/TheBlueMatt/bitcoin
2012-01-23 13:15:43 -05:00
b8056dc5d0
Merge branch 'bugfix_areinpstd' of https://github.com/luke-jr/bitcoin
2012-01-23 13:09:34 -05:00
149f580c82
Only store transactions with missing inputs in the orphan pool.
...
All previous versions of bitcoin could store some types of
invalid transactions in the orphan-transaction list.
2012-01-23 12:54:32 -05:00
dc77dce07c
Fixed addmultisigaddress if looking up public keys from locked wallets.
2012-01-23 12:04:34 -05:00
ca9afa8401
Bugfix: Support building test_bitcoin with shared-object boost test framework
2012-01-23 11:37:48 -05:00
198fb229a4
Add DEBUG_LOCKCONTENTION, to warn each time a thread waits to lock.
...
If compiled with -DDEBUG_LOCKCONTENTION, Bitcoin will print to
debug.log each time a thread has to wait for a lock to continue.
2012-01-21 16:16:28 -05:00
575bdcde93
Sanitize AreInputsStandard slightly
...
Correct comment for why the check is unnecessary for coinbases
Move testnet check out, to AcceptToMemoryPool where everything else checks it
2012-01-20 21:00:08 -05:00
137d0685a4
Simplify counting of P2SH sigops to match BIP 16 (thanks to Matt Corallo for prompting this).
...
This also removes an un-needed sigops-per-byte check when accepting transactions to the memory pool (un-needed assuming only standard transactions are being accepted). And it only counts P2SH sigops after the switchover date.
2012-01-20 17:07:40 -05:00
1240a1b0a8
Back out spacing changes to json spirit code
2012-01-19 14:32:45 -05:00
7012b124bc
Merge branch 'updateseednodes' of https://github.com/nanotube/bitcoin
2012-01-19 14:23:49 -05:00
c55fd06b99
Merge branch 'tabs-to-space' of https://github.com/larsr/bitcoin
2012-01-19 14:22:26 -05:00
aacefd2795
Merge branch 'getmemorypool_blockflagstime' of https://github.com/forrestv/bitcoin
2012-01-19 14:14:41 -05:00
39f0d96860
Make transactions with extra data in their scriptSig's non-standard.
2012-01-19 13:30:54 -05:00
b2f76e9ded
Update seednodes, pick long-uptime nodes with version >= 0.4.0
2012-01-19 01:54:14 -05:00
06706ab8ef
Remove erroneous ":" in front of port in options dialog (introduced with network refactor)
2012-01-17 09:34:24 +01:00
be4d08b261
fix the build (port IP validation in options to network refactoring)
2012-01-17 09:27:03 +01:00
b2a967cd0b
Revert to global progress indication (see #753 )
2012-01-17 09:19:58 +01:00
c981d768b3
Fix handling of default ports
2012-01-17 02:12:35 +01:00
8498c59144
Merge branch 'keepnode' of https://github.com/TheBlueMatt/bitcoin
2012-01-16 16:45:43 -05:00
ab84512258
Added mintime and curtime to RPC getmemorypool
2012-01-14 19:23:37 -05:00
52a3d2635c
Separated COINBASE_FLAGS out into main.h and made RPC getmemorypool return it
2012-01-14 19:22:24 -05:00
29b7273153
*Clear all has a tooltip now *About dialog updated
2012-01-14 21:31:49 +02:00
b985efaac1
Replace tabs with four spaces to comply with coding standard in doc/coding.txt
2012-01-14 12:14:36 +01:00
9e8818ec9d
Remove base58 encoding from validateaddress/addmultisigaddress
...
base58-encoding of full/compressed public keys needs more thought; it probably makes sense to define a base58 encoding that includes a version byte and a checksum. So just support hex and bitcoin-address encodings for now.
2012-01-13 10:22:24 -05:00
4063460534
Refactor: needing to call ConnectInputs to process coinbase transactions was counter-intuitive
2012-01-13 10:22:24 -05:00
8d7849b6db
Refactored ConnectInputs, so valid-transaction-checks are done before ECDSA-verifying signatures.
2012-01-13 10:22:24 -05:00
922e8e2929
Replace OP_EVAL (BIP 12) with Pay-to-script-hash (BIP 16).
2012-01-13 10:22:23 -05:00
d11a58a2d3
Remove not-used-anywhere scriptPrereq from SignSignature()
2012-01-13 10:20:42 -05:00
f290a649f9
Merge branch 'getmininginfo' of https://github.com/luke-jr/bitcoin
2012-01-13 10:06:05 -05:00
10ba0a3efc
Minor code cleanup to use fHaveUPnP instead of #ifdef
2012-01-12 22:13:16 -05:00
b24e6e4d1b
Add -keepnode which attempts to -addnode and keep a connection open
2012-01-12 22:13:16 -05:00
a1de57a063
Compile with extra warnings turned on. And more makefile/code tidying up.
...
This turns on most gcc warnings, and removes some unused variables and other code that triggers warnings.
Exceptions are:
-Wno-sign-compare : triggered by lots of comparisons of signed integer to foo.size(), which is unsigned.
-Wno-char-subscripts : triggered by the convert-to-hex functions (I may fix this in a future commit).
2012-01-12 20:02:47 -05:00
340f0876ea
collect more info on tx pooling and block finding for getmininginfo
2012-01-12 19:47:39 -05:00
6950bb6200
Add new "getmininginfo" JSON-RPC method, with mining-only fields moved out of "getinfo"
2012-01-12 19:47:23 -05:00
025d495481
Remove broken Visual C++ makefile.vc, and removed annoying HEADERS= list from other makefiles
2012-01-12 16:55:44 -05:00
3f64fa1369
Merge pull request #743 from gavinandresen/blocknotify
...
-blocknotify : run a command when best-block changes
2012-01-12 06:31:25 -08:00
afcf6f974f
Merge pull request #649 from sipa/comprpubkey
...
Compressed pubkeys
2012-01-10 13:23:51 -08:00
b43eaa5508
Merge pull request #752 from luke-jr/qt_txnid
...
Qt: Show transaction ID in details
2012-01-10 11:51:55 -08:00
ebf9065c22
Qt: Show transaction ID in details
2012-01-10 13:25:05 -05:00
a4902c9e7c
Remove unused definition
2012-01-09 23:39:26 +01:00
2e555237d3
Merge pull request #746 from laanwj/tdesc_ro
...
make transaction description read-only (UI fix)
2012-01-09 07:59:18 -08:00
b3974ec9d4
Unit tests for EC key routines
...
This tests:
* creation of keys from base58-encoded strings
* extracting public keys and addresses
* compressed public keys
* compact signatures and key recovery
2012-01-09 15:18:19 +01:00
d4d9c734c3
Compact signatures with compressed pubkeys
2012-01-09 15:18:19 +01:00
11529c6e4f
Compressed pubkeys
...
This patch enabled compressed pubkeys when -compressedpubkeys is passed.
These are 33 bytes instead of 65, and require only marginally more CPU
power when verifying. Compressed pubkeys have a different corresponding
address, so it is determined at generation. When -compressedpubkeys is
given, all newly generated addresses will use a compressed key, while
older/other addresses keep using normal keys. Unpatched clients will
relay and verify these transactions.
2012-01-09 15:18:19 +01:00
67a42f929b
Network stack refactor
...
This introduces CNetAddr and CService, respectively wrapping an
(IPv6) IP address and an IP+port combination. This functionality used
to be part of CAddress, which also contains network flags and
connection attempt information. These extra fields are however not
always necessary.
These classes, along with logic for creating connections and doing
name lookups, are moved to netbase.{h,cpp}, which does not depend on
headers.h.
Furthermore, CNetAddr is mostly IPv6-ready, though IPv6
functionality is not yet enabled for the application itself.
2012-01-06 18:55:37 +01:00
7453497ee4
make transaction description read-only (UI fix)
2012-01-06 06:57:14 +01:00
7d145a0f59
Add support for opening bitcoin: URIs directly.
2012-01-05 00:29:28 -05:00
9a93c4c024
Automatically refocus on new SendCoinsEntrys and scroll to them.
2012-01-05 00:29:28 -05:00
f7a9a11391
Fix horrific performance found by gmaxwell.
2012-01-04 19:46:16 -05:00
d237f62c23
-blocknotify=command argument, implemented using system() and boost::thread
2012-01-03 15:48:59 -05:00
96d3bcb996
Merge pull request #731 from laanwj/txshowfix
...
Fix transaction type in UI
2012-01-03 09:24:54 -08:00
af8c56f8be
Merge branch 'getblock'
2012-01-03 12:16:56 -05:00
8677f9c751
I broke -testnet with my TOR option-parsing fixes.
2012-01-03 11:17:24 -05:00
112b0e97d4
Merge pull request #741 from laanwj/typo734fix
...
Fix typo (#734 )
2012-01-03 07:54:38 -08:00
73e86eedd5
Merge branch 'bugfix_multisig' of https://github.com/coderrr/bitcoin
2012-01-03 10:23:20 -05:00
daad9a9a71
Merge branch 'gitianfix' of https://github.com/TheBlueMatt/bitcoin
2012-01-03 10:22:24 -05:00
0fcf91ea1e
Fix issue #659 , and cleanup wallet/command-line argument handling a bit
2012-01-03 10:17:28 -05:00
ecaa91d1df
Fix typo ( #734 )
2012-01-03 11:57:24 +01:00
a75d7066b8
Fix some address-handling deadlocks
...
Made three critical blocks for cs_mapAddresses smaller, and moved
writing to the database out of them. This should also improve the
concurrency of the code.
2012-01-03 02:01:56 +01:00
6ec76ca09e
make sure IsMine only returns true when we own all keys
2012-01-03 06:24:52 +07:00
56c6e3696d
Fix transaction type in UI: not all tx'es with "from"/"to" field are necessarily IP tx'es
...
- Also, prepare for OP_EVAL by calling all transactions without bitcoin address "SendToOther"/"RecvFromOther",
(IP tx'es are so rare they can be put together with funky EV_EVAL scripts)
2011-12-28 11:14:05 +01:00
625b56de64
Merge branch 'opevalcountfix' of https://github.com/laanwj/bitcoin
2011-12-27 16:42:29 -05:00
6d6d392b22
Fixed OP_EVAL recursion unit test, checks for both infinite and exactly-3-deep recursion
2011-12-27 16:41:56 -05:00
89772f932a
Fix OP_EVAL recursion depth counting
2011-12-27 10:02:28 +01:00
61977f956c
Check all prevout.n if one transaction provides multiple inputs
2011-12-25 10:32:05 -05:00
60835d9627
assert condition in previous commit was backwards
2011-12-25 10:08:01 -05:00
Wladimir J. van der Laan
Pieter Wuille
Matt Corallo
Gavin Andresen
Chris Moore
sje397
gmaxwell
Janne Pulkkinen
Nils Schneider
Gregory Maxwell
Luke Dashjr
Daniel Folkinshteyn
Pieter Wuille
Forrest Voight
Lars Rasmusson
coderrr