Go to file
Russell Yanofsky 2ba5d78427 [qa] Fix bug in compactblocks v2 merge
Bug caused the wait_for_block_announcement to be called on the wrong node,
leading to nondeterminism and occasional test failures. Bug was introduced in
merge commit:

d075479 Merge #8882: [qa] Fix race conditions in p2p-compactblocks.py and sendheaders.py

Underlying commits which conflicted were:

27acfc1 [qa] Update p2p-compactblocks.py for compactblocks v2
6976db2 [qa] Another attempt to fix race condition in p2p-compactblocks.py

The first commit changed the test_compactblock_construction function signature
and second commit added code which wasn't updated during the merge to use the
new arguments.

Suhas Daftuar <sdaftuar@chaincode.com> noticed the bug and suggested the fix.

Github-Pull: #9058
Rebased-From: 47e9659ecf
2016-11-19 23:53:01 +01:00
.tx tx: change slug to `bitcoin.qt-translation-013x` 2016-06-28 11:49:30 +02:00
build-aux/m4 Add MIT license to build-aux/m4 scripts 2016-10-27 14:47:22 +02:00
contrib [copyright] add MIT license headers to .sh scripts where missing 2016-09-21 02:43:47 +00:00
depends Fix wake from sleep issue with Boost 1.59.0 2016-10-07 13:05:53 +02:00
doc Move release notes to release-notes/release-notes-0.13.1.md 2016-10-27 14:55:10 +02:00
qa [qa] Fix bug in compactblocks v2 merge 2016-11-19 23:53:01 +01:00
share Add MIT license to autogen.sh and share/genbuild.sh 2016-10-27 14:47:22 +02:00
src test: Fix use-after-free in scheduler tests 2016-11-19 23:24:35 +01:00
.gitattributes Separate protocol versioning from clientversion 2014-10-29 00:24:40 -04:00
.gitignore [trivial] Ignore split-debug.sh 2016-06-13 19:28:39 +08:00
.travis.yml [travis] Update SDK_URL 2016-06-20 14:56:43 +02:00
CONTRIBUTING.md [doc] Add basic git squash example 2016-05-10 16:14:21 +08:00
COPYING Update license year range to 2016 2016-01-17 23:38:11 +05:30
INSTALL Prettify some /Contrib READMEs 2013-10-21 20:07:31 -04:00
Makefile.am Add MIT license to Makefiles 2016-10-27 14:47:22 +02:00
README.md readme: Omit phrasing; 'new' 2016-06-19 14:15:58 -06:00
autogen.sh Add MIT license to autogen.sh and share/genbuild.sh 2016-10-27 14:47:22 +02:00
configure.ac Bump version to 0.13.1 2016-10-18 00:15:59 +02:00
libbitcoinconsensus.pc.in Unify package name to as few places as possible without major changes 2015-12-14 02:11:10 +00:00

README.md

Bitcoin Core integration/staging tree

Build Status

https://bitcoincore.org

What is Bitcoin?

Bitcoin is an experimental digital currency that enables instant payments to anyone, anywhere in the world. Bitcoin uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Bitcoin Core is the name of open source software which enables the use of this currency.

For more information, as well as an immediately useable, binary version of the Bitcoin Core software, see https://bitcoin.org/en/download, or read the original whitepaper.

License

Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is regularly built and tested, but is not guaranteed to be completely stable. Tags are created regularly to indicate new official, stable release versions of Bitcoin Core.

The contribution workflow is described in CONTRIBUTING.md.

The developer mailing list should be used to discuss complicated or controversial changes before working on a patch set.

Developer IRC can be found on Freenode at #bitcoin-core-dev.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check

There are also regression and integration tests of the RPC interface, written in Python, that are run automatically on the build server. These tests can be run (if the test dependencies are installed) with: qa/pull-tester/rpc-tests.py

The Travis CI system makes sure that every pull request is built for Windows, Linux, and OS X, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.

Translators should also subscribe to the mailing list.