From 8e96d1439dfe39afd0084ae5f784c25221b38a5a Mon Sep 17 00:00:00 2001 From: Gabe Date: Wed, 4 Jun 2014 13:42:06 -0400 Subject: [PATCH 1/2] check if seed is greater than 512 bits --- lib/HierarchicalKey.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/HierarchicalKey.js b/lib/HierarchicalKey.js index e220c84..4f45afb 100644 --- a/lib/HierarchicalKey.js +++ b/lib/HierarchicalKey.js @@ -63,6 +63,8 @@ HierarchicalKey.seed = function(bytes, network) { bytes = new Buffer(bytes, 'hex'); //if not buffer, assume hex if (bytes.length < 128/8) return false; //need more entropy + if (bytes.length > 512/8) + return false; var hash = coinUtil.sha512hmac(bytes, new Buffer('Bitcoin seed')); var hkey = new HierarchicalKey(null); From a374b58271468f5a86d0b7b2be10d8c0ada909c5 Mon Sep 17 00:00:00 2001 From: Gabe Date: Wed, 4 Jun 2014 13:59:38 -0400 Subject: [PATCH 2/2] fix bad test, bytes!=bits --- examples/HierarchicalKey.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/HierarchicalKey.js b/examples/HierarchicalKey.js index 9e0b658..e78eb0f 100644 --- a/examples/HierarchicalKey.js +++ b/examples/HierarchicalKey.js @@ -10,7 +10,7 @@ var run = function() { console.log('https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki\n'); console.log('1) Make new hkey from randomly generated new seed'); - var randomBytes = crypto.randomBytes(256); + var randomBytes = crypto.randomBytes(32); var hkey = HierarchicalKey.seed(randomBytes); console.log('master extended private key: ' + hkey.extendedPrivateKeyString()); console.log('master extended public key: ' + hkey.extendedPublicKeyString());