Commit Graph

131 Commits

Author SHA1 Message Date
eordano a37e7b140c Add functionality to randomize outputs 2015-03-11 15:38:53 -03:00
Manuel Araoz b92fd915eb increase coverage for Input and Output, fix some bugs 2015-02-27 18:46:27 -03:00
Manuel Araoz d5fd3919c9 add Transaction#inputAmount and outputAmount 2015-02-27 16:38:48 -03:00
eordano 405f4f43df Update dust amount 2015-02-24 17:24:22 -03:00
eordano 2f86f323c0 Add link when throwing a serialization error 2015-02-24 16:41:15 -03:00
eordano 97671abfdc Add more docs on serialization checks 2015-02-24 16:36:08 -03:00
eordano b81624480a transaction: Fix verbosity of jsdocs 2015-02-24 16:34:52 -03:00
eordano c5d7eacfac Add check for output amount > input amount 2015-02-24 16:34:52 -03:00
eordano f0f90c5d6a Change unnecesarily big name 2015-02-24 13:04:40 -03:00
eordano a6df7a175e Better granularity on serialize() checks 2015-02-24 13:02:34 -03:00
Manuel Aráoz e2ff93b714 Merge pull request #1083 from eordano/feature/multisigchecks
Transaction: Check that threshold is less than amount of signatures
2015-02-18 12:01:58 -03:00
eordano c19d5c6501 Transaction: Check that threshold is less than amount of signatures 2015-02-18 11:52:50 -03:00
Manuel Aráoz 4c822e06c5 Merge pull request #1078 from eordano/fix/smallFee
Add check for small fees
2015-02-18 11:30:21 -03:00
eordano 7e88167891 Add check for small fees 2015-02-16 12:47:53 -03:00
Trevin Hofmann 59a9e40f13 Properly capitalize BufferUtil everywhere
Right out of CONTRIBUTING.md

https://github.com/bitpay/bitcore/blob/master/CONTRIBUTING.md#g6---naming-utility-namespaces
2015-02-13 21:21:06 -06:00
Trevin Hofmann ea2a0163c4 Remove redundant util requirement
The Transaction class was requiring bitcore.util.js twice, as `util` and
`JSUtil`. It seems `JSUtil` is the standard name in other classes.
2015-02-13 21:06:51 -06:00
Manuel Aráoz a9533546b2 remove console.log 2015-02-11 19:28:15 -03:00
Manuel Araoz 0e1de0403e remove logs 2015-02-11 12:21:42 -03:00
Manuel Araoz 8ca396c34f refactor transaction input deserializtion 2015-02-11 11:40:24 -03:00
Manuel Araoz 0f17927fde fix 0 fee error 2015-02-10 18:29:14 -03:00
Manuel Araoz aa1158097d fix bug in change calculation 2015-02-10 18:12:45 -03:00
Manuel Araoz 986264e181 add locktime docs and Transaction#getLockTime 2015-02-10 13:03:07 -03:00
Esteban Ordano f8974b383a transaction: Change variable name from time to height 2015-02-10 10:29:29 -03:00
Esteban Ordano 7cf3b6eb91 Split setLockTime in two methods 2015-02-10 10:29:29 -03:00
Manuel Araoz 07c8c153f9 add Transaction#lockUntil stub 2015-02-10 10:29:29 -03:00
Nathan Hernandez 80d444f60e Update transaction.js 2015-02-09 13:23:23 -05:00
Manuel Aráoz ebf43b3f4a Merge pull request #1056 from eordano/docs/transaction
Rewrite of Transaction doc
2015-02-09 14:20:13 -03:00
Esteban Ordano 78189f61d9 Rewrite of Transaction doc 2015-02-09 14:11:51 -03:00
Esteban Ordano 8d642f3c7a Merge pull request #1044 from trustatom-oss/master
Add check to _hasDustOutputs if output has OP_RETURN
2015-02-09 12:45:06 -03:00
Manuel Aráoz 6e27dc3a9a Merge pull request #1043 from eordano/performance/bn
Drop inherited and modified BN class for big improvement on performance
2015-02-06 11:28:02 -03:00
Esteban Ordano 67164790ff Fix inspect method so it doesn't fail on incomplete TX 2015-02-06 10:10:29 -03:00
Esteban Ordano 9cafbd558d Dust outputs: Fix condition (one OP_RETURN was avoiding checks on other outputs) 2015-02-06 09:32:12 -03:00
Gabriel Jaldon 89400c0a56 Add check to _hasDustOutputs if output has OP_RETURN 2015-02-06 13:31:27 +08:00
Esteban Ordano 73a973359b Fix invocations to binary operations called on numbers 2015-02-05 17:28:45 -03:00
Esteban Ordano 6b05f20397 Add the new operator when BN was used without it 2015-02-05 16:46:18 -03:00
Matias Alejo Garcia 5fa384603f Update transaction.js
Fixes https://github.com/bitpay/bitcore/issues/1036
2015-02-05 10:40:45 -03:00
Esteban Ordano 979d284567 Transaction: add `removeInput` member 2015-02-04 17:53:16 -03:00
Manuel Aráoz cd7e5d5a1e Merge pull request #1028 from eordano/transaction/changeupdate
Improvements to Transaction
2015-02-04 16:19:02 -03:00
Esteban Ordano e568a8786c Transaction: Fix wrong logic on input addition 2015-02-04 15:57:34 -03:00
Esteban Ordano 1f45e88268 Add fee to serialization 2015-02-04 12:50:06 -03:00
Esteban Ordano ed393dcb91 Update change on each output or input change 2015-02-04 12:50:03 -03:00
Esteban Ordano bd97f20f1c Use addInput in _fromNonP2SH 2015-02-04 12:10:47 -03:00
Manuel Araoz b9be679e09 add some checks 2015-02-04 11:49:09 -03:00
Manuel Araoz 2b3ce4de12 adds a test and small fix for transaction 2015-01-19 18:02:26 -03:00
Esteban Ordano f3663e26d6 Don't add the same input twice 2015-01-12 11:59:15 -03:00
Manuel Aráoz 50a868cb8c Merge pull request #917 from eordano/transaction/updates
Changes to internal transaction and address
2015-01-09 17:44:13 -03:00
Manuel Aráoz 7c87305943 Merge pull request #935 from eordano/feature/outputinspect
Add inspect method to output
2015-01-09 17:11:03 -03:00
Esteban Ordano bdeac4e67d Add inspect method to output 2015-01-09 16:53:50 -03:00
Manuel Aráoz f6cc8c695b Merge pull request #916 from eordano/dusterror
Don't allow serialization if dust amounts are detected
2015-01-09 13:45:07 -03:00
Esteban Ordano 0f73c3f7a3 Throw error if dust amount is detected 2015-01-08 18:02:59 -03:00
Esteban Ordano dc6ff32290 Make serialization roundtrip recover info about inputs 2015-01-08 17:42:08 -03:00
Esteban Ordano d053599fd2 Improve test coverage 2015-01-08 17:24:29 -03:00
Yemel Jardi 5f59fd0d05 Merge pull request #903 from eordano/fix/addchange
Add `change` when serializing transaction
2015-01-08 17:00:14 -03:00
Esteban Ordano fe86abc093 Add `change` when serializing transaction 2015-01-08 16:39:53 -03:00
Yemel Jardi e57d02c03c Use define immutable helper 2015-01-08 10:57:46 -03:00
Braydon Fuller bce28cd227 Fixed bug in IE11 that would cause MAX_MONEY verification test to fail. 2015-01-06 12:00:28 -05:00
Esteban Ordano 11975bc0df Rename UTXO to Transaction.UnspentOutput 2015-01-02 15:59:13 -03:00
Esteban Ordano 476f009b4d Add Insight and UTXO class 2015-01-02 15:59:13 -03:00
Esteban Ordano dbf47ef78f transaction: better errors for signature methods
Closes #868
2014-12-31 02:10:51 -03:00
Manuel Aráoz 85169a3874 Merge pull request #812 from eordano/feature/safeSerialize
Modify Transaction Interface
2014-12-19 10:37:24 -03:00
Esteban Ordano 99db72ba90 Add `uncheckedAddInput` function
* For internal usage: for example, testing Script.Interpreter
2014-12-19 10:30:20 -03:00
Esteban Ordano 9a73338c91 Add tests for changes to Transaction interface 2014-12-18 20:38:19 -03:00
Braydon Fuller 6d42e01718 Fix formatting issue with examples 2014-12-18 17:07:01 -05:00
Esteban Ordano e5631b1a69 Modify transaction interface
* Add checks when serializing
* Add default _estimateSize to generic inputs
* Fix multisig size estimation
* Change _addOutput to addOutput
* Add addInput and using that internally
* Split `getFee` out from `_updateChangeOutput`
2014-12-18 14:09:44 -03:00
Esteban Ordano 24dc84d614 Dont lose sighash when signing with multiple keys 2014-12-18 02:19:39 -03:00
Esteban Ordano 6be0c047b7 Update index for the documentation 2014-12-17 17:40:15 -03:00
Esteban Ordano 9f442e8ec4 Merge pull request #777 from maraoz/add/tx_invalid/tests
add tx_invalid.json tests
2014-12-16 23:13:59 -03:00
Manuel Araoz 84deec297a add tx_invalid tests 2014-12-16 22:40:59 -03:00
Esteban Ordano f7f7d147c6 Add change features 2014-12-16 22:39:25 -03:00
Esteban Ordano d4b8c4adc6 Remove globals 2014-12-16 17:30:43 -03:00
Manuel Araoz 4fcc048311 script interpreting working 2014-12-16 13:33:57 -03:00
Manuel Araoz 73874ae873 import Sighash 2014-12-16 13:33:56 -03:00
Manuel Araoz 9aa6152f25 trying to fix OP_CHECKSIG script evaluation 2014-12-16 13:33:56 -03:00
Esteban Ordano de4d2884c7 Modify Transaction to use Multisig
* Allow `Script#add` to add a Script causing concatenation of opcodes
* Add `Script#equals` to compare scripts
* Add `Script#fromAddress`
* Drop `_payTo` methods
* Add `Script.buildP2SHMultisigIn`

Greatly simplifying the internal transaction object
2014-12-15 18:19:54 -03:00
Esteban Ordano af43228daf Add `PublicKeyHashInput` and `ScriptHashInput`.
Remove `_outpoints`, `_utxos` from Transaction, as that info
can be efficiently retrieved from the inputs
2014-12-15 18:19:39 -03:00
Manuel Aráoz 264a239e5a Merge pull request #737 from braydonf/bug/to-object
Transaction:  `toJSON` / `fromJSON` tests
2014-12-15 17:06:08 -03:00
Braydon Fuller b13c4fb0c9 Added inspect prototype G5 2014-12-14 15:13:01 -05:00
Braydon Fuller f43c2f9aa3 Fixed bug, toObject should use other object's toObject 2014-12-13 14:54:07 -05:00
Braydon Fuller 002eb3dcf5 Transaction: Added toObject method and changed toJSON to return a string 2014-12-12 19:03:14 -05:00
Esteban Ordano 0c28bc1786 Split buildPKH arguments, add Copy constructor on publickey 2014-12-10 12:46:21 -03:00
Esteban Ordano 5c974a8ef2 Refactor transaction to match new API
* Refactor transaction into a different subfolder
* Added a lot of tests for sighash and transaction serialization (from
  reddit's and Ryan X. Charles' `fullnode`)
* Drop "only" from sighash tests and consolidate logs
2014-12-10 12:44:30 -03:00