7e23109f9b
Added more tests around script.isPublicKeyHashIn
2015-07-06 13:12:20 -04:00
9b727afc71
fix signature hasDefinedHashtype method to be closer to the Bitcoin Core function IsDefinedHashtypeSignature
2015-07-01 07:11:08 -04:00
02cad1645a
fix root cause for bitcore.Transaction.sighash.sign not setting nhashtype.
...
added unit tests.
fixed an existing lint in a file that i touched.
2015-06-30 15:21:11 -04:00
6dd599187c
Merge pull request #1276 from greggzigler/feature/get-sigops-count
...
get-signature-count needed to measure txs with many inputs
2015-06-25 19:20:14 -04:00
b6d44f4622
camelCase variable names
2015-06-25 17:53:50 -04:00
77645c7f03
remove skipped tests since equalivant boolean tests already exist
2015-06-24 14:44:27 -04:00
183ffab02b
match bitcore style standards, rename arg, set default to true
2015-06-24 14:18:55 -04:00
a4b8c06a2d
get-signature-count needed to measure txs with many inputs or outputs
2015-06-24 13:30:25 -04:00
8e13b68405
Merge pull request #1268 from brandonrobertz/master
...
modularize network version check issues/1265 (2nd)
2015-06-23 18:02:14 -04:00
3518843f98
stylistic change and unnecessary test code removal
2015-06-23 09:47:02 -07:00
783c59d99e
removed Networks.all and associated test
2015-06-22 20:36:35 -07:00
37b5d3d588
Merge pull request #1264 from fanatid/fix/sortOutputs
...
fix Transaction.sortOutputs
2015-06-18 11:06:20 -04:00
a53bd10f42
test explicitly passed invalid network
2015-06-11 08:05:35 -07:00
f638b5bd6e
test fee per kb
2015-06-10 22:28:15 -03:00
a38c0c2d93
modularize network version check/tests issues/1265
2015-06-09 14:06:22 -07:00
b9d52b79c8
fix Transaction.sortOutputs
2015-06-05 21:11:40 +03:00
0d2784eb1e
created test to verify correct network initialization in PrivateKey.fromJSON()
2015-06-05 01:51:27 -07:00
a03e6b9385
Add base option for BN.fromString
2015-05-27 14:11:43 -04:00
e2542866d1
expose BN.fromString problem
2015-05-27 15:01:26 -03:00
4c1ba674c5
Merge pull request #1248 from braydonf/bug/misleading-error
...
Fixes bug with misleading error with getSerializationError. Closes #1236
2015-05-26 11:32:51 -06:00
ffe6b449cb
Check the compressed property in Signature.fromCompact tests.
2015-05-26 01:15:11 -04:00
a5cd5a1407
Added support for uncompressed public keys to Signature.fromCompact
2015-05-25 23:57:46 -04:00
7719d1bfd4
Add test with uncompressed pubkey compact signature.
2015-05-25 23:31:42 -04:00
ee651df635
Added test for null input for transaction.verify()
2015-05-23 20:28:33 -04:00
3ace170ac5
Ignore fee error when unspent output is actually negative, rather than already when the check for negative unspent output is disabled.
2015-05-23 20:13:53 -04:00
ac2fbe2777
When disableMoreOutputThanInput is set for getSerializationError, also disable the fee checks as the concept of a fee is meaningless when unspent output value is negative. This also allows for removing the opts from buildSkipTest again and simplifying the skip test for disableMoreOutputThanInput.
2015-05-23 20:13:53 -04:00
dc07788e53
Put )); on a separate line.
2015-05-23 20:13:53 -04:00
6729b38944
Expect the correct error to be thrown.
2015-05-23 20:13:53 -04:00
8c5b2c851b
When checking for transaction serialization errors, check the output amount before checking fee errors. Added a test for it and also improved buildSkipTest by specifying which error to expect and using it for some tests where it wasn't used yet.
2015-05-23 20:13:53 -04:00
74e285dadd
fix imports for block tests
2015-05-23 16:44:11 -03:00
6e49ed0e40
reorganize block test files
2015-05-20 14:42:48 -03:00
b53f249d02
Merge pull request #1235 from maraoz/transaction/clearOutputs
...
add Transaction#clearOutputs
2015-05-18 16:24:02 -04:00
85dd29e576
Merge pull request #1227 from fanatid/fix/inBrowser
...
remove inBrowser
2015-05-18 16:22:14 -04:00
1c8ebc0eb5
Simplify version guard
...
- Updated index.js test to run in Node.js and browsers
- Simplified message and clarified case where two of the same versions would conflict
2015-05-18 15:00:45 -04:00
7723dd302a
Added test case for an empty OP_RETURN for script.getData() Fixes #1237
2015-05-18 10:39:15 -04:00
7e3993578c
improve guard for prevent more than one instance of bitcore
2015-05-17 10:09:18 +03:00
8a13a22baf
add Transaction#clearOutputs
2015-05-15 15:29:05 -03:00
458abe069e
Fixed issue with handling invalid output scripts
...
- Changed toObject serialization to always use a hexa string for a script
- Updated inspect method to handle a null script
- Roundtrip toObject/fromObject with an invalid script
- Additional test coverage for Output
2015-05-14 01:50:14 -04:00
e294505486
Some transaction tests were not run because of the way they were built. Fixed this so they are run and fixed one test that still assumed the dust limit at 5460 instead of 546.
2015-05-13 09:14:00 +02:00
de078a40d3
If output.script is InvalidBuffer, return null instead of throwing error
2015-05-12 17:23:56 -04:00
a02258dfba
Merge pull request #1218 from maraoz/docs/pubkeys
...
improve PublicKey docs and fix #1215
2015-05-12 13:31:34 -04:00
8e7528d13f
Merge pull request #1219 from braydonf/coverage/transaction
...
Added coverage to transaction and fixed bug with serialization check.
2015-05-11 17:48:50 -04:00
993125428e
Merge pull request #1213 from braydonf/bug/is-fully-signed
...
Fixed script.isPublicKeyHashIn bug with variable length signatures.
2015-05-11 15:12:44 -04:00
53b6171547
Added coverage to transaction and fixed bug with serialization check.
2015-05-11 13:39:53 -04:00
951a07c011
fix PublicKey.toObject
2015-05-11 12:24:45 -03:00
b1e54101d3
Call the parent error of the fee errors FeeError for backwards compatibility.
2015-05-10 00:38:56 +02:00
8da9c4a44a
Give the 3 fee errors a common parent error.
2015-05-10 00:32:27 +02:00
d1eb190626
Introduce different kinds of FeeError to distinguish the different cases. Fix the issue uncovered by this, which is that getFee might not be the actual fee, but only an estimate, if a change address is specified but there isn't enough to pay a fee and have change.
2015-05-09 21:06:40 +02:00
16dc489b08
Make sure a specified transaction fee and outputs add up to the sum of the inputs. Don't ignore the fee when it's explicitly specified.
2015-05-09 18:44:26 +02:00
d8e90685f4
Fixed script.isPublicKeyHashIn bug with variable length signatures.
...
- DER encoded signatures have a max length of 72 bytes, however a minimum size isn't defined.
- R and S values can have arbitrary lengths
- For more information: https://github.com/bitcoin/bips/blob/master/bip-0062.mediawiki#der-encoding
2015-05-08 22:09:42 -04:00
Braydon Fuller
mruddy
Gregg Zigler
Brandon Roberts
Ivan Socolsky
Kirill Fomichev
mpolci
Manuel Araoz
Patrick Nagurny
David de Kloet
Patrick Nagurny
Eric Martindale