From 17115d0a34ce5c370e45fb51560c02bee5339b11 Mon Sep 17 00:00:00 2001 From: Jonas Schnelli Date: Wed, 4 Feb 2015 16:34:34 +0100 Subject: [PATCH] fix getblocktemplate lock issue getblocktemplate didn't have a wallet lock before #5711 and IMO there is no need for LEAVE/ENTER critical section. --- src/rpcmining.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/rpcmining.cpp b/src/rpcmining.cpp index 369b3fb4d..8f2d34edf 100644 --- a/src/rpcmining.cpp +++ b/src/rpcmining.cpp @@ -446,10 +446,6 @@ Value getblocktemplate(const Array& params, bool fHelp) } // Release the wallet and main lock while waiting -#ifdef ENABLE_WALLET - if(pwalletMain) - LEAVE_CRITICAL_SECTION(pwalletMain->cs_wallet); -#endif LEAVE_CRITICAL_SECTION(cs_main); { checktxtime = boost::get_system_time() + boost::posix_time::minutes(1); @@ -467,10 +463,6 @@ Value getblocktemplate(const Array& params, bool fHelp) } } ENTER_CRITICAL_SECTION(cs_main); -#ifdef ENABLE_WALLET - if(pwalletMain) - ENTER_CRITICAL_SECTION(pwalletMain->cs_wallet); -#endif if (!IsRPCRunning()) throw JSONRPCError(RPC_CLIENT_NOT_CONNECTED, "Shutting down");