From 4e1e91512d7b4e8b19a8709bde88175587e3a124 Mon Sep 17 00:00:00 2001 From: Eirik Ogilvie-Wigley Date: Wed, 1 Aug 2018 14:46:09 -0600 Subject: [PATCH] Fix assertion and comment --- qa/rpc-tests/wallet_nullifiers.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/qa/rpc-tests/wallet_nullifiers.py b/qa/rpc-tests/wallet_nullifiers.py index db8940d3b..72e26fab8 100755 --- a/qa/rpc-tests/wallet_nullifiers.py +++ b/qa/rpc-tests/wallet_nullifiers.py @@ -5,7 +5,7 @@ from test_framework.test_framework import BitcoinTestFramework -from test_framework.util import assert_equal, start_node, \ +from test_framework.util import assert_equal, assert_true, start_node, \ start_nodes, connect_nodes_bi, bitcoind_processes import time @@ -189,7 +189,7 @@ class WalletNullifiersTest (BitcoinTestFramework): assert_equal(myzaddr in self.nodes[3].z_listaddresses(True), True) # Node 3 should see the same received notes as node 2; however, - # some of the notes were change for note 2 but not for note 3. + # some of the notes were change for node 2 but not for node 3. # Aside from that the recieved notes should be the same. So, # group by txid and then check that all properties aside from # change are equal. @@ -199,7 +199,8 @@ class WalletNullifiersTest (BitcoinTestFramework): for txid in node2Received: received2 = node2Received[txid] received3 = node3Received[txid] - assert_equal(len(received2), len(received3)) + # the change field will be omitted for received3, but all other fields should be shared + assert_true(len(received2) >= len(received3)) for key in received2: # check all the properties except for change if key != 'change':