Commit Graph

9888 Commits

Author SHA1 Message Date
Jack Grigg db853f8a46
Handle wrapping of potentially long lines 2016-10-22 15:50:18 -05:00
Jack Grigg 0ddd6d1cd8
Tag metrics strings for translation 2016-10-22 15:50:17 -05:00
Jack Grigg d30273f919
Split out screen sections into separate functions 2016-10-22 15:50:16 -05:00
Jack Grigg 4482bd8fd7
Adjust copy 2016-10-22 15:50:14 -05:00
Jack Grigg d934e68967
Fit metrics screen into an 80-column terminal without wrapping 2016-10-22 15:50:13 -05:00
Jack Grigg 4ace963c80
Show important console messages on metrics screen 2016-10-22 15:50:11 -05:00
Jack Grigg a6df7ab567
Add a persistent screen showing basic node metrics
The screen is implemented using ANSI Escape sequences.

Closes #1331
2016-10-22 15:50:06 -05:00
zkbot 026c3f784f Auto merge of #1602 - str4d:1424-minimal-getblocktemplate, r=daira
Minimal modifications to getblocktemplate

A simpler alternative to #1435 that ensures Zcash GBT will remain compatible with BIP 22.

Closes #1424
2016-10-22 16:40:59 -04:00
Jack Grigg bc54cf06cc
Fix RPC test 2016-10-22 15:36:38 -05:00
zkbot f39d176ebf Auto merge of #1607 - daira:1530.update-unit-tests-doc, r=daira
Update unit-tests documentation. closes #1530

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-10-22 15:57:44 -04:00
zkbot 30d3d2dfd4 Auto merge of #1603 - str4d:1556-reject-old-block-versions, r=daira
Reject block versions lower than 4

Includes parts of #1554
Closes #1556
2016-10-22 14:32:40 -04:00
Daira Hopwood 6316cc2b48 Address @str4d's comments on unit-tests doc. ref #1530
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-10-22 18:56:43 +01:00
zkbot f82273829a Auto merge of #1600 - str4d:1557-consensus-rule-disallow-v0-txns, r=daira
Disallow v0 transactions as a consensus rule

Closes #1557
2016-10-22 13:50:52 -04:00
Daira Hopwood 9f7b947bbe Update unit-tests documentation. closes #1530
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-10-22 18:45:26 +01:00
zkbot e3c8e88e9b Auto merge of #1588 - bitcartel:upstream_8427_dos_logging, r=daira
Upstream: Prevent possible DoS in logging

bitcoin/bitcoin#8427
2016-10-22 13:08:26 -04:00
Simon 432bc22ade Patch backport of upstream 1588 as we don't (yet) use the NetMsgType namespace 2016-10-22 09:49:35 -07:00
Jack Grigg f4f1b4b097
Update sighash tests for new consensus rule 2016-10-22 11:09:07 -05:00
Jack Grigg 77175766f4
Enforce standard transaction rules on testnet
Closes #1582
2016-10-22 09:03:09 -05:00
Daira Hopwood 789914e7b0 Update comments in chainparams.cpp.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-10-22 13:46:22 +01:00
Daira Hopwood a5fd8da7ba Static assertion that standard and network min tx versions are consistent.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-10-22 13:46:22 +01:00
Daira Hopwood cb1246194e Update the error message string for tx version too low. ref #1600
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-10-22 13:26:44 +01:00
zkbot 0b3809464c Auto merge of #1601 - str4d:1459-revert-reversion, r=daira
Revert "Revert "Avoid boost::posix_time functions that have potential out-of-bounds read bugs. ref #1459""

This reverts commit f19cb7b7ee.

Closes #1459.
2016-10-22 07:06:40 -04:00
Jack Grigg 86d2c90468
Update tests for new genesis blocks 2016-10-22 00:52:58 -05:00
Jack Grigg 8c54e34a68
Use tromp's solver to regenerate miner tests
When using, comment out tromp's solver in miner.cpp to avoid linker errors.
2016-10-22 00:52:56 -05:00
Jack Grigg 6be6762237
Regenerate genesis blocks with nVersion = 4
Includes parts of #1554
2016-10-22 00:52:45 -05:00
Jack Grigg 80f4cdcf8f
Reject block versions lower than 4
Closes #1556
2016-10-22 00:43:26 -05:00
Jack Grigg 7ac924cdb7
Disallow v0 transactions as a consensus rule
Closes #1557
2016-10-22 00:40:50 -05:00
zkbot a12eaa2bf2 Auto merge of #1581 - bitcartel:1464_ncc_2016_008, r=str4d
Fixes for NCC-2016-008

To close #1464 NCC-2016-088

- This PR
- https://github.com/zcash/libsnark/pull/8

Of the 101 issues in NCC-2016-088, 62 are in dependencies, and many of the remainder are duplicates of the CIDs fixed in this PR.

Commit log message is: CID Type (Type is from scan.coverity Type column)
2016-10-22 00:56:08 -04:00
Simon e11e61ddb1 Workaround g++ 5.x bug with brace enclosed initializer.
http://stackoverflow.com/questions/32912921/whats-wrong-with-this-inline-initialization-of-stdarray/32912976#32912976
2016-10-21 21:50:25 -07:00
Jack Grigg 07064ea2d1
GBT: Add RPC tests 2016-10-21 23:38:37 -05:00
Jack Grigg 1628efedaf
GBT: Correct block header in proposals RPC test 2016-10-21 23:36:35 -05:00
Jack Grigg 89aa746ca1
GBT: Add informational founders' reward value to coinbasetxn 2016-10-21 23:36:04 -05:00
Jack Grigg 53ddbaed16
GBT: Support coinbasetxn instead of coinbasevalue
Once a Zcash GBT spec has been written, we can re-enable coinbasevalue.
2016-10-21 23:32:24 -05:00
zkbot 48888b67c9 Auto merge of #1599 - daira:1597.fix-other-potential-race-conditions, r=daira
Fix other potential race conditions similar to ref #1597 in RPC tests.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-10-22 00:15:32 -04:00
Jack Grigg 09864abc55
Revert "Revert "Avoid boost::posix_time functions that have potential out-of-bounds read bugs. ref #1459""
This reverts commit f19cb7b7ee.
2016-10-21 23:14:00 -05:00
zkbot 7ccbcca62c Auto merge of #1591 - bitcartel:upstream_7933_fix_out_of_memory_deserializing_utxo, r=daira
Upstream: fix out of memory problem when deserializing utxo

bitcoin/bitcoin#7933
2016-10-21 23:32:51 -04:00
zkbot f808be7546 Auto merge of #1589 - bitcartel:upstream_7856_one_getaddr_per_connection, r=daira
Upstream: Only send one GetAddr response per connection.

bitcoin/bitcoin#8427
2016-10-21 22:53:19 -04:00
zkbot 71043784dd Auto merge of #1586 - bitcartel:z_sendmany_amount_too_strict, r=daira
Fix issue where z_sendmany amount parameter is too strict

Upstream treats an amount parameter of `1` the same as `1.0`.  Third-party would like this fixed.
2016-10-21 22:10:41 -04:00
zkbot fd7ef7b632 Auto merge of #1584 - bitcartel:1504_zca_011_logging, r=daira
More granular control over logging of z_* calls

Closes #1504
2016-10-21 21:32:46 -04:00
zkbot 10ad093bbb Auto merge of #1567 - str4d:rename-binaries, r=daira
Rename binaries

This ensures that our installs don't clash with existing Bitcoin binaries and libraries.

Closes #1563 and #1565
2016-10-21 20:48:11 -04:00
Daira Hopwood deba66ca55 Fix other potential race conditions similar to ref #1597 in RPC tests.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-10-22 00:37:14 +01:00
zkbot dc21a8a39f Auto merge of #1578 - daira:1570.tromp-equihash-with-libsodium-blake.2, r=daira
1570.tromp equihash with libsodium blake.2

Remove BLAKE2b implementation from Tromp Equihash solver, and address almost all of @str4d's review comments on #1570. Supercedes #1576.

Signed-off-by: Daira Hopwood daira@jacaranda.org
2016-10-21 19:07:26 -04:00
Daira Hopwood f0f838f081 Fix race condition in rpc-tests/wallet_protectcoinbase.py. closes #1597
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-10-21 17:20:36 +01:00
zkbot cd8e856df7 Auto merge of #1585 - bitcartel:1583_stop_test_writing_to_testnet3, r=daira
Closes #1583 by setting up the datadir for the wallet gtest.

Stops test writing to ~/.zcash/testnet3.
Also related to #1506
2016-10-21 03:15:00 -04:00
Simon 43f0769cf6 Fix build problem with coins_tests 2016-10-20 23:50:19 -07:00
Pieter Wuille abd22bb674 Add tests for CCoins deserialization 2016-10-20 22:59:50 -07:00
Patrick Strateman e9d221e764 CDataStream::ignore Throw exception instead of assert on negative nSize.
Previously disk corruption would cause an assert instead of an exception.
2016-10-20 22:59:50 -07:00
Pieter Wuille f588c5edd6 Fix OOM bug: UTXO entries with invalid script length 2016-10-20 22:59:50 -07:00
Pieter Wuille 6fc5764eda Treat overly long scriptPubKeys as unspendable 2016-10-20 22:59:50 -07:00
Pieter Wuille 4c6ea562bd Introduce constant for maximum CScript length 2016-10-20 22:59:50 -07:00