From bd7c367590287922c01afc3125f947d101dbd7f8 Mon Sep 17 00:00:00 2001 From: ying tong Date: Tue, 27 Apr 2021 12:33:56 +0800 Subject: [PATCH] Apply suggestions from code review Co-authored-by: str4d --- orchard_generators.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/orchard_generators.py b/orchard_generators.py index 1737108..dff66e7 100644 --- a/orchard_generators.py +++ b/orchard_generators.py @@ -17,16 +17,16 @@ NULLIFIER_K_BASE = group_hash(b'z.cash:Orchard', b'K') VALUE_COMMITMENT_VALUE_BASE = group_hash(b'z.cash:Orchard-cv', b'v') VALUE_COMMITMENT_RANDOMNESS_BASE = group_hash(b'z.cash:Orchard-cv', b'r') -# Used in SinsemillaCommit (https://zips.z.cash/protocol/nu5.pdf#sinsemillacommitments) +# Used in SinsemillaCommit (https://zips.z.cash/protocol/nu5.pdf#concretesinsemillacommit) NOTE_COMMITMENT_BASE = group_hash(b'z.cash:Orchard-NoteCommit-r', b'') -NOTE_COMMITMENT_Q = group_hash(b'z.cash:Orchard-NoteCommit-M', b'') +NOTE_COMMITMENT_Q = group_hash(b'z.cash:SinsemillaQ', b'z.cash:Orchard-NoteCommit-M') -# Used in SinsemillaShortCommit (https://zips.z.cash/protocol/nu5.pdf#sinsemillacommitments) +# Used in SinsemillaShortCommit (https://zips.z.cash/protocol/nu5.pdf#concretesinsemillacommit) IVK_COMMITMENT_BASE = group_hash(b'z.cash:Orchard-CommitIvk-r', b'') -IVK_COMMITMENT_Q = group_hash(b'z.cash:Orchard-CommitIvk-M', b'') +IVK_COMMITMENT_Q = group_hash(b'z.cash:SinsemillaQ', b'z.cash:Orchard-CommitIvk-M') # Used in SinsemillaHash (https://zips.z.cash/protocol/nu5.pdf#orchardmerklecrh) -MERKLE_CRH_Q = group_hash(b'z.cash:Orchard-MerkleCRH', b'') +MERKLE_CRH_Q = group_hash(b'z.cash:SinsemillaQ', b'z.cash:Orchard-MerkleCRH') def main(): render_tv(