zec
/
ZcashLightClientKit
mirror of https://github.com/zcash/ZcashLightClientKit.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Change lastState property to Publisher from Subject in SDKSynchronizer 

It's not good practice to make internal combine subjects accessible from
outside of SDK. So `lastState` is changed from `CurrentValueSubject` to
`Publisher`. This doesn't have any effect on public API. It just makes
SDK safer.
This commit is contained in:
Michal Fousek 2022-11-22 14:03:03 +01:00
parent 58b59bc9b3
commit 1f2ea5e716
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Sources/ZcashLightClientKit/Synchronizer/SDKSynchronizer.swift
View File

@ -110,8 +110,9 @@ public class SDKSynchronizer: Synchronizer {
public private(set) var latestScannedHeight: BlockHeight
public private(set) var connectionState: ConnectionState
public private(set) var network: ZcashNetwork
public private(set) var lastState: CurrentValueSubject<SynchronizerState,Never>
public var lastState: AnyPublisher<SynchronizerState, Never> { lastStateSubject.eraseToAnyPublisher() }
private var lastStateSubject: CurrentValueSubject<SynchronizerState, Never>
private var transactionManager: OutboundTransactionManager
private var transactionRepository: TransactionRepository
private var utxoRepository: UnspentTransactionOutputRepository
@ -149,7 +150,7 @@ public class SDKSynchronizer: Synchronizer {
let lastscannedHeight = (try? transactionRepository.lastScannedHeight()) ?? initializer.walletBirthday
self.latestScannedHeight = lastscannedHeight
self.network = initializer.network
self.lastState = CurrentValueSubject(
self.lastStateSubject = CurrentValueSubject(
SynchronizerState(
shieldedBalance: .zero,
transparentBalance: .zero,
@ -178,7 +179,6 @@ public class SDKSynchronizer: Synchronizer {
return .success
}
/// Starts the synchronizer
/// - Throws: CompactBlockProcessorError when failures occur
public func start(retry: Bool = false) throws {
@ -193,7 +193,7 @@ public class SDKSynchronizer: Synchronizer {
case .stopped, .synced, .disconnected, .error:
Task {
let state = await snapshotState()
lastState.send(state)
lastStateSubject.send(state)
NotificationSender.default.post(
name: .synchronizerStarted,
@ -723,7 +723,7 @@ public class SDKSynchronizer: Synchronizer {
case .synced:
Task {
let state = await self.snapshotState()
self.lastState.send(state)
self.lastStateSubject.send(state)
NotificationSender.default.post(
name: Notification.Name.synchronizerSynced,