ZcashLightClientKit/Tests/OfflineTests
Michal Fousek 6bbaad4cb1 [#740] Refator blocks downloading in CompactBlockProcessor
Closes #740

`CompactBlockDownloading` protocol is renamed to `BlockDownloaderService`. `CompactBlockDownloader` is renamed to `BlockDownloaderServiceImpl`.

What is the motivation for this rename?
Goal of this change is to extract code from `CompactBlockProcessor` which is related to downloading. So naturaly it should be called "downloader".
But `CompactBlockDownloader` was already taken. After analysis of `CompactBlockDownloading` and `CompactBlockDownloader` I found out that
`CompactBlockDownloader` doesn't download blocks exactly. It's more like abstraction over `LightWalletService`. And it does very similar job to
`LightWalletService`. That is why I decided to rename it to "service".

What is the motivation for protoco/impl naming scheme?
First `BlockDownloaderService` protocol doesn't describe capability in my eyes. It describe what something is. Also `BlockDownloaderServicing` sounds
strange. I agree that add suffix "Impl" to class name isn't super nice. But it is acceptable. And it makes sense to use nicer type name
(e.g. `BlockDownloaderService`) for protocol because it's used on much more places in the code.

- Added `BlockDownloader` protocol and `BlockDownloaderImpl` class. The code related to downloading was exctracted to this class.
2023-01-31 15:24:41 +01:00
..
DerivationToolTests [#711] Add Swiftlint plug in to SDK (#722) 2023-01-18 17:09:04 +01:00
BirthdayTests.swift [#398] Make WalletBirthday an internal type (#414) 2022-07-12 16:36:12 -03:00
BlockBatchValidationTests.swift [#740] Refator blocks downloading in CompactBlockProcessor 2023-01-31 15:24:41 +01:00
CompactBlockProcessorOfflineTests.swift [#711] Add Swiftlint plug in to SDK (#722) 2023-01-18 17:09:04 +01:00
CompactBlockStorageTests.swift Fix typos 2022-12-31 12:50:16 +02:00
ErrorLocalizationTests.swift [#711] Add Swiftlint plug in to SDK (#722) 2023-01-18 17:09:04 +01:00
InternalSyncProgressTests.swift [#711] Add Swiftlint plug in to SDK (#722) 2023-01-18 17:09:04 +01:00
MemoTests.swift Merge branch 'main' into 556_using_transactions_db_views 2023-01-19 12:44:28 +01:00
NotesRepositoryTests.swift [#711] Add Swiftlint plug in to SDK (#722) 2023-01-18 17:09:04 +01:00
NullBytesTests.swift [#711] Add Swiftlint plug in to SDK (#722) 2023-01-18 17:09:04 +01:00
PagedTransactionRepositoryTests.swift [#621] Adds a synchronizer state subject with the last available 2022-11-14 14:44:33 -03:00
PendingTransactionRepositoryTests.swift Fix UInt32 conversions to SQL in PendingTransactionDao 2022-10-19 14:13:18 -06:00
RawTransactionTests.swift Remove dependecy on rust sources 2022-02-28 17:03:20 +00:00
RecipientTests.swift [#711] Add Swiftlint plug in to SDK (#722) 2023-01-18 17:09:04 +01:00
TransactionRepositoryTests.swift [#556] Rename Transaction to ZCashTransaction 2023-01-23 10:01:07 +01:00
TxIdTests.swift Remove dependecy on rust sources 2022-02-28 17:03:20 +00:00
UndescribableTests.swift [#711] Add Swiftlint plug in to SDK (#722) 2023-01-18 17:09:04 +01:00
UnifiedTypecodesTests.swift [#711] Add Swiftlint plug in to SDK (#722) 2023-01-18 17:09:04 +01:00
WalletTests.swift [#711] Add Swiftlint plug in to SDK (#722) 2023-01-18 17:09:04 +01:00
ZatoshiTests.swift Fix typos 2022-12-31 12:50:16 +02:00
ZcashRustBackendTests.swift [#711] Add Swiftlint plug in to SDK (#722) 2023-01-18 17:09:04 +01:00
Zip302MemoTests.swift [#711] Add Swiftlint plug in to SDK (#722) 2023-01-18 17:09:04 +01:00