From 4dbc34550cb18da138180d6261a55dec45ca4bcc Mon Sep 17 00:00:00 2001
From: Jack Grigg <jack@electriccoin.co>
Date: Tue, 12 Nov 2024 18:34:29 +1300
Subject: [PATCH] Reduce the number of repositories fetched for the Zashi
 pipeline

---
 helpers/repos.py  | 23 +++++++++++++++--------
 zashi-pipeline.py | 11 +++++++++--
 2 files changed, 24 insertions(+), 10 deletions(-)

diff --git a/helpers/repos.py b/helpers/repos.py
index f26d5a68..ce3c547b 100644
--- a/helpers/repos.py
+++ b/helpers/repos.py
@@ -23,6 +23,13 @@ class Repo(object):
 
 # To get the GitHub ID of a repo, see <https://stackoverflow.com/a/47223479/393146>.
 
+LIBRUSTZCASH = Repo(('zcash', 'librustzcash'), 85334928, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTg5MDU1NTE')
+ZCASH_ANDROID_WALLET_SDK = Repo(('Electric-Coin-Company', 'zcash-android-wallet-sdk'), 151763639, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTg5MDI4MjE')
+ZCASH_LIGHT_CLIENT_FFI = Repo(('Electric-Coin-Company', 'zcash-light-client-ffi'), 439137887, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTMzMTMwNjcy')
+ZCASH_SWIFT_WALLET_SDK = Repo(('Electric-Coin-Company', 'zcash-swift-wallet-sdk'), 185480114, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTg5MDU1NjE')
+ZASHI_ANDROID = Repo(('Electric-Coin-Company', 'zashi-android'), 390808594, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTMzMDEwMTMw')
+ZASHI_IOS = Repo(('Electric-Coin-Company', 'zashi-ios'), 387551125, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTMzMDEwMTI5')
+
 HALO2_REPOS = [
     Repo(('zcash', 'halo2'), 290019239, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTMyNzg1NDUx'),
     Repo(('zcash', 'pasta_curves'), 344239327, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTMyOTI3Njg2'),
@@ -32,7 +39,7 @@ CORE_REPOS = [
     Repo(('zcash', 'zcash'), 26987049, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvOTc3ODc2NQ'),
     Repo(('zcash', 'zips'), 47279130, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMjIwMzQwMDY'),
     Repo(('zcash', 'incrementalmerkletree'), 48303644, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTMzMDcwMDc5'),
-    Repo(('zcash', 'librustzcash'), 85334928, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTg5MDU1NTE'),
+    LIBRUSTZCASH,
     Repo(('zcash', 'zcash-test-vectors'), 133857578, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTMyOTMxNTEx'),
     Repo(('zcash', 'sapling-crypto'), 111058300, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTMzOTY3ODY4'),
     Repo(('zcash', 'orchard'), 305835578, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTMyODU2MzA2'),
@@ -46,21 +53,21 @@ TFL_REPOS = [
 ]
 
 ANDROID_REPOS = [
-    Repo(('Electric-Coin-Company', 'zashi-android'), 390808594, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTMzMDEwMTMw'),
-    Repo(('Electric-Coin-Company', 'zcash-android-wallet-sdk'), 151763639, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTg5MDI4MjE'),
+    ZASHI_ANDROID,
+    ZCASH_ANDROID_WALLET_SDK,
     Repo(('Electric-Coin-Company', 'zashi'), 719178328, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTMzOTYwOTgw'),
 ]
 
 IOS_REPOS = [
-    Repo(('Electric-Coin-Company', 'zashi-ios'), 387551125, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTMzMDEwMTI5'),
-    Repo(('Electric-Coin-Company', 'zcash-swift-wallet-sdk'), 185480114, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTg5MDU1NjE'),
+    ZASHI_IOS,
+    ZCASH_SWIFT_WALLET_SDK,
     Repo(('Electric-Coin-Company', 'MnemonicSwift'), 270825987, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTMyNzk3Mzg0'),
-    Repo(('Electric-Coin-Company', 'zcash-light-client-ffi'), 439137887, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTMzMTMwNjcy'),
+    ZCASH_LIGHT_CLIENT_FFI,
     Repo(('Electric-Coin-Company', 'zashi'), 719178328, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTMzOTYwOTgw'),
 ]
 
 WALLET_REPOS = [
-    Repo(('zcash', 'librustzcash'), 85334928, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTg5MDU1NTE'),
+    LIBRUSTZCASH,
     Repo(('zcash', 'lightwalletd'), 159714694, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTg5MDU1NzE'),
 ] + ANDROID_REPOS + IOS_REPOS
 
@@ -82,7 +89,7 @@ ZF_FROST_REPOS = [
 ZCASHD_DEPRECATION_REPOS = [
     Repo(('zcash', 'zcash'), 26987049, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvOTc3ODc2NQ'),
     Repo(('zcash', 'zips'), 47279130, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMjIwMzQwMDY'),
-    Repo(('zcash', 'librustzcash'), 85334928, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTg5MDU1NTE'),
+    LIBRUSTZCASH,
     Repo(('zcash', 'wallet'), 863610221, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTM0MzU3MjQ0'),
     Repo(('zcash', 'lightwalletd'), 159714694, 'Z2lkOi8vcmFwdG9yL1JlcG9zaXRvcnkvMTg5MDU1NzE'),
 ]
diff --git a/zashi-pipeline.py b/zashi-pipeline.py
index 56beb687..4b349cc6 100644
--- a/zashi-pipeline.py
+++ b/zashi-pipeline.py
@@ -9,7 +9,7 @@ import re
 from textwrap import wrap
 from urllib.parse import urlparse
 
-from helpers import github, zenhub
+from helpers import github, repos as repositories, zenhub
 
 GITHUB_TOKEN = os.environ.get('GITHUB_TOKEN')
 ZENHUB_TOKEN = os.environ.get('ZENHUB_TOKEN')
@@ -73,7 +73,14 @@ def main():
     # The repos we care about are now:
     # - Any repo containing a tracked issue.
     # - The wallet repos where releases occur.
-    repos = set([repo for (repo, _) in tracked_issues] + github.WALLET_REPOS)
+    repos = set([repo for (repo, _) in tracked_issues] + [
+        repositories.LIBRUSTZCASH,
+        repositories.ZCASH_ANDROID_WALLET_SDK,
+        repositories.ZCASH_LIGHT_CLIENT_FFI,
+        repositories.ZCASH_SWIFT_WALLET_SDK,
+        repositories.ZASHI_ANDROID,
+        repositories.ZASHI_IOS,
+    ])
     workspaces = {
         workspace_id: [repo for repo in repos if repo in repos]
         for (workspace_id, _) in zenhub.WORKSPACE_SETS.items()