zec
/
developers
mirror of https://github.com/zcash/developers.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #50 from zcash/fix-permissions-crash 

Prevent DAG renderer crash if GITHUB_TOKEN has insufficient permissions
This commit is contained in:
Daira-Emma Hopwood 2024-02-06 02:07:37 +00:00 committed by GitHub
parent 7d72a65019 bfc7e36b8a
commit 720fa1c33a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
zcash-issue-dag.py
View File

@ -172,6 +172,9 @@ def download_issues(endpoint, nodes):
issues = [(repo, issue) for (repo, issue) in nodes if repo in REPOS] issues = [(repo, issue) for (repo, issue) in nodes if repo in REPOS]
ret = {} ret = {}
# Ensure that any graph nodes from ZenHub that are not in the repos we care about have
# default entries, to simplify subsequent graph manipulation code.
for (repo, issue) in [(repo, issue) for (repo, issue) in nodes if repo not in REPOS]: for (repo, issue) in [(repo, issue) for (repo, issue) in nodes if repo not in REPOS]:
ret[(repo, issue)] = GitHubIssue(repo, issue, None) ret[(repo, issue)] = GitHubIssue(repo, issue, None)
@ -187,7 +190,12 @@ def download_issues(endpoint, nodes):
data = (op + d) data = (op + d)
for (repo, issue) in issues: for (repo, issue) in issues:
ret[(repo, issue)] = GitHubIssue(repo, issue, data['repo%d' % repo]['issue%d' % issue]) repo_data = data['repo%d' % repo]
issue_key = 'issue%d' % issue
# If GITHUB_TOKEN doesn't have permission to read from a particular private
# repository in REPOS, GitHub returns an empty repo_data section.
issue_data = repo_data[issue_key] if issue_key in repo_data else None
ret[(repo, issue)] = GitHubIssue(repo, issue, issue_data)
return ret return ret