diff --git a/src/gadgets/blake2s.rs b/src/gadgets/blake2s.rs index beefe0928..672f13937 100644 --- a/src/gadgets/blake2s.rs +++ b/src/gadgets/blake2s.rs @@ -404,7 +404,7 @@ pub fn blake2s>( )?; } - Ok(h.iter().flat_map(|b| b.into_bits()).collect()) + Ok(h.into_iter().flat_map(|b| b.into_bits()).collect()) } #[cfg(test)] diff --git a/src/gadgets/uint32.rs b/src/gadgets/uint32.rs index 3467400ec..5a93e75a6 100644 --- a/src/gadgets/uint32.rs +++ b/src/gadgets/uint32.rs @@ -72,8 +72,10 @@ impl UInt32 { Ok(UInt32 { bits, value }) } - pub fn into_bits_be(&self) -> Vec { - self.bits.iter().rev().cloned().collect() + pub fn into_bits_be(self) -> Vec { + let mut ret = self.bits; + ret.reverse(); + ret } pub fn from_bits_be(bits: &[Boolean]) -> Self { @@ -101,8 +103,8 @@ impl UInt32 { } /// Turns this `UInt32` into its little-endian byte order representation. - pub fn into_bits(&self) -> Vec { - self.bits.clone() + pub fn into_bits(self) -> Vec { + self.bits } /// Converts a little-endian byte order representation of bits into a