From 270eec25748d38f5d31ec3d71bc90e631f7fe3f1 Mon Sep 17 00:00:00 2001 From: Jack Grigg Date: Thu, 11 Jul 2024 18:09:49 -0700 Subject: [PATCH] CI: Don't test `zcash_client_backend/lightwalletd-tonic` on WASM Broken until hyperium/tonic#1783 is addressed. --- .github/workflows/ci.yml | 2 +- zcash_client_backend/CHANGELOG.md | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index aac43e276..4ff69691e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -195,7 +195,7 @@ jobs: run: cargo add --no-default-features --path ../crates/zcash_proofs - name: Add zcash_client_backend as a dependency of the synthetic crate working-directory: ./ci-build - run: cargo add --features lightwalletd-tonic --path ../crates/zcash_client_backend + run: cargo add --path ../crates/zcash_client_backend - name: Copy pinned dependencies into synthetic crate run: cp crates/Cargo.lock ci-build/ - name: Add target diff --git a/zcash_client_backend/CHANGELOG.md b/zcash_client_backend/CHANGELOG.md index 8179c6ee4..1f6fc7c0f 100644 --- a/zcash_client_backend/CHANGELOG.md +++ b/zcash_client_backend/CHANGELOG.md @@ -22,6 +22,8 @@ and this library adheres to Rust's notion of ### Changed - MSRV is now 1.70.0. - Migrated to `tonic 0.12`. + - The `lightwalletd-tonic` feature flag no longer works on `wasm32-wasi` due + to https://github.com/hyperium/tonic/issues/1783. - `zcash_client_backend::{fixed,standard,zip317}::SingleOutputChangeStrategy` now implement a different strategy for choosing whether there will be any change, and its value. This can avoid leaking information about note amounts