From 796161e9b42093b32d313e5505082c24f018bb1d Mon Sep 17 00:00:00 2001 From: Kris Nuttycombe Date: Thu, 4 Feb 2021 11:22:13 -0700 Subject: [PATCH] Add suggested comment clarifying future additions to the TxVersion enum Co-authored-by: Daira Hopwood --- zcash_primitives/src/transaction/mod.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/zcash_primitives/src/transaction/mod.rs b/zcash_primitives/src/transaction/mod.rs index 1e191ff5a..f30f6d867 100644 --- a/zcash_primitives/src/transaction/mod.rs +++ b/zcash_primitives/src/transaction/mod.rs @@ -57,7 +57,9 @@ impl fmt::Display for TxId { /// /// This is serialized in the first four or eight bytes of the transaction format, and /// represents valid combinations of the `(overwintered, version, version_group_id)` -/// transaction fields. +/// transaction fields. Note that this is not dependent on epoch, only on transaction encoding. +/// For example, if a particular epoch defines a new transaction version but also allows the +/// previous version, then only the new version would be added to this enum. #[derive(Clone, Copy, Debug, PartialEq, Eq)] pub enum TxVersion { Sprout(u32),