Apply suggestions from code review

Co-authored-by: str4d <thestr4d@gmail.com>
This commit is contained in:
Kris Nuttycombe 2021-03-25 15:00:54 -06:00 committed by GitHub
parent ebdd6cf976
commit c41c71c514
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions

View File

@ -31,7 +31,7 @@ and this library adheres to Rust's notion of
- The `account` property of `WalletShieldedSpend` and `WalletShieldedOutput`
now has the type `AccountId`.
- `zcash_client_backend::welding_rig`:
- `scan_block` now takes `&[(AccountId, SaplingIvk)]`, instead of a
- `scan_block` now takes `&[(AccountId, K: ScanningKey)]`, instead of a
slice of extended full viewing keys with implicit account IDs.
- The `nullifiers` argument to `scan_block` now has the type
`&[(AccountId, Nullifier)]`.

View File

@ -38,7 +38,7 @@ and this library adheres to Rust's notion of
versions.
- `SignableInput` enum, encapsulating per-input data used when
creating transaction signatures.
- `zcash_primitives::primitives::SaplingIvk` wrapper was added for `jubjub::Fr`
- `zcash_primitives::primitives::SaplingIvk`, a newtype wrapper around `jubjub::Fr`
values that are semantically Sapling incoming viewing keys.
- Test helpers, behind the `test-dependencies` feature flag:
- `zcash_primitives::prover::mock::MockTxProver`, for building transactions in