From ebdd6cf9768b03482f0b19219afc36d775aede6c Mon Sep 17 00:00:00 2001 From: Kris Nuttycombe Date: Wed, 10 Mar 2021 10:39:18 -0700 Subject: [PATCH] Add SaplingIvk newtype to changelogs. --- zcash_client_backend/CHANGELOG.md | 2 +- zcash_primitives/CHANGELOG.md | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/zcash_client_backend/CHANGELOG.md b/zcash_client_backend/CHANGELOG.md index 887a229d5..8176db434 100644 --- a/zcash_client_backend/CHANGELOG.md +++ b/zcash_client_backend/CHANGELOG.md @@ -31,7 +31,7 @@ and this library adheres to Rust's notion of - The `account` property of `WalletShieldedSpend` and `WalletShieldedOutput` now has the type `AccountId`. - `zcash_client_backend::welding_rig`: - - `scan_block` now takes `&[(AccountId, IncomingViewingKey)]`, instead of a + - `scan_block` now takes `&[(AccountId, SaplingIvk)]`, instead of a slice of extended full viewing keys with implicit account IDs. - The `nullifiers` argument to `scan_block` now has the type `&[(AccountId, Nullifier)]`. diff --git a/zcash_primitives/CHANGELOG.md b/zcash_primitives/CHANGELOG.md index 97b5238ec..87d7fac1e 100644 --- a/zcash_primitives/CHANGELOG.md +++ b/zcash_primitives/CHANGELOG.md @@ -38,6 +38,8 @@ and this library adheres to Rust's notion of versions. - `SignableInput` enum, encapsulating per-input data used when creating transaction signatures. + - `zcash_primitives::primitives::SaplingIvk` wrapper was added for `jubjub::Fr` + values that are semantically Sapling incoming viewing keys. - Test helpers, behind the `test-dependencies` feature flag: - `zcash_primitives::prover::mock::MockTxProver`, for building transactions in tests without creating proofs. @@ -103,6 +105,10 @@ and this library adheres to Rust's notion of - `try_sapling_note_decryption` - `try_sapling_output_recovery` - `try_sapling_output_recovery_with_ock` +- `zcash_primitives::primitives::SaplingIvk` is now used where functions + previously used undistinguished `jubjub::Fr` values; this affects Sapling + note decryption and handling of IVKs by the wallet backend code. +- `zcash_primitives::primitives::ViewingKey::ivk` now returns `SaplingIvk` - `zcash_primitives::primitives::Note::nf` now returns `Nullifier`. - `zcash_primitives::transaction`: - The `overwintered`, `version`, and `version_group_id` properties of the