add comments that GetTaddressTxids() returns transactions

This commit is contained in:
Larry Ruane 2023-01-31 18:11:55 -07:00 committed by Larry Ruane
parent fb12fba802
commit f936ae8e61
7 changed files with 13 additions and 9 deletions

View File

@ -73,8 +73,9 @@ func (s *lwdStreamer) GetLatestBlock(ctx context.Context, placeholder *walletrpc
return &walletrpc.BlockID{Height: uint64(blockChainInfo.Blocks), Hash: []byte(bestBlockHash)}, nil
}
// GetTaddressTxids is a streaming RPC that returns transaction IDs that have
// GetTaddressTxids is a streaming RPC that returns transactions that have
// the given transparent address (taddr) as either an input or output.
// NB, this method is misnamed, it does not return txids.
func (s *lwdStreamer) GetTaddressTxids(addressBlockFilter *walletrpc.TransparentAddressBlockFilter, resp walletrpc.CompactTxStreamer_GetTaddressTxidsServer) error {
if err := checkTaddress(addressBlockFilter.Address); err != nil {
return err

View File

@ -5,7 +5,7 @@
// Code generated by protoc-gen-go. DO NOT EDIT.
// versions:
// protoc-gen-go v1.31.0
// protoc v4.23.4
// protoc v4.24.0
// source: compact_formats.proto
package walletrpc

View File

@ -5,7 +5,7 @@
// Code generated by protoc-gen-go. DO NOT EDIT.
// versions:
// protoc-gen-go v1.31.0
// protoc v4.23.4
// protoc v4.24.0
// source: darkside.proto
package walletrpc

View File

@ -5,7 +5,7 @@
// Code generated by protoc-gen-go-grpc. DO NOT EDIT.
// versions:
// - protoc-gen-go-grpc v1.3.0
// - protoc v4.23.4
// - protoc v4.24.0
// source: darkside.proto
package walletrpc

View File

@ -5,7 +5,7 @@
// Code generated by protoc-gen-go. DO NOT EDIT.
// versions:
// protoc-gen-go v1.31.0
// protoc v4.23.4
// protoc v4.24.0
// source: service.proto
package walletrpc

View File

@ -170,7 +170,8 @@ service CompactTxStreamer {
// Submit the given transaction to the Zcash network
rpc SendTransaction(RawTransaction) returns (SendResponse) {}
// Return the txids corresponding to the given t-address within the given block range
// Return the transactions corresponding to the given t-address within the given block range
// NB - this method is misnamed, it returns transactions, not transaction IDs.
rpc GetTaddressTxids(TransparentAddressBlockFilter) returns (stream RawTransaction) {}
rpc GetTaddressBalance(AddressList) returns (Balance) {}
rpc GetTaddressBalanceStream(stream Address) returns (Balance) {}

View File

@ -5,7 +5,7 @@
// Code generated by protoc-gen-go-grpc. DO NOT EDIT.
// versions:
// - protoc-gen-go-grpc v1.3.0
// - protoc v4.23.4
// - protoc v4.24.0
// source: service.proto
package walletrpc
@ -62,7 +62,8 @@ type CompactTxStreamerClient interface {
GetTransaction(ctx context.Context, in *TxFilter, opts ...grpc.CallOption) (*RawTransaction, error)
// Submit the given transaction to the Zcash network
SendTransaction(ctx context.Context, in *RawTransaction, opts ...grpc.CallOption) (*SendResponse, error)
// Return the txids corresponding to the given t-address within the given block range
// Return the transactions corresponding to the given t-address within the given block range
// NB - this method is misnamed, it returns transactions, not transaction IDs.
GetTaddressTxids(ctx context.Context, in *TransparentAddressBlockFilter, opts ...grpc.CallOption) (CompactTxStreamer_GetTaddressTxidsClient, error)
GetTaddressBalance(ctx context.Context, in *AddressList, opts ...grpc.CallOption) (*Balance, error)
GetTaddressBalanceStream(ctx context.Context, opts ...grpc.CallOption) (CompactTxStreamer_GetTaddressBalanceStreamClient, error)
@ -479,7 +480,8 @@ type CompactTxStreamerServer interface {
GetTransaction(context.Context, *TxFilter) (*RawTransaction, error)
// Submit the given transaction to the Zcash network
SendTransaction(context.Context, *RawTransaction) (*SendResponse, error)
// Return the txids corresponding to the given t-address within the given block range
// Return the transactions corresponding to the given t-address within the given block range
// NB - this method is misnamed, it returns transactions, not transaction IDs.
GetTaddressTxids(*TransparentAddressBlockFilter, CompactTxStreamer_GetTaddressTxidsServer) error
GetTaddressBalance(context.Context, *AddressList) (*Balance, error)
GetTaddressBalanceStream(CompactTxStreamer_GetTaddressBalanceStreamServer) error