Use `zero` instead of `default` for empty values

This commit is contained in:
Jack Grigg 2021-04-28 09:06:33 +12:00
parent 6d4ceb989f
commit 186914166a
2 changed files with 7 additions and 2 deletions

View File

@ -86,7 +86,7 @@ impl RecipientInfo {
RecipientInfo { RecipientInfo {
ovk: None, ovk: None,
recipient, recipient,
value: NoteValue::default(), value: NoteValue::zero(),
memo: None, memo: None,
} }
} }
@ -280,7 +280,7 @@ impl Builder {
// Determine the value balance for this bundle, ensuring it is valid. // Determine the value balance for this bundle, ensuring it is valid.
let value_balance: ValueSum = pre_actions let value_balance: ValueSum = pre_actions
.iter() .iter()
.fold(Ok(ValueSum::default()), |acc, action| { .fold(Ok(ValueSum::zero()), |acc, action| {
acc? + action.value_sum()? acc? + action.value_sum()?
})?; })?;

View File

@ -80,6 +80,11 @@ impl Sub for NoteValue {
pub struct ValueSum(i64); pub struct ValueSum(i64);
impl ValueSum { impl ValueSum {
pub(crate) fn zero() -> Self {
// Default for i64 is zero.
Default::default()
}
/// Creates a value sum from its raw numeric value. /// Creates a value sum from its raw numeric value.
/// ///
/// This only enforces that the value is a signed 63-bit integer. Callers should /// This only enforces that the value is a signed 63-bit integer. Callers should