diff --git a/src/builder.rs b/src/builder.rs index 0b106705..6ed10616 100644 --- a/src/builder.rs +++ b/src/builder.rs @@ -135,12 +135,7 @@ impl ActionInfo { let alpha = pallas::Scalar::random(&mut rng); let rk = ak.randomize(&alpha); - let note = Note::new( - self.output.recipient, - self.output.value, - nf_old.clone(), - rng, - ); + let note = Note::new(self.output.recipient, self.output.value, nf_old, rng); let cm_new = note.commitment(); // TODO: Note encryption @@ -542,7 +537,7 @@ pub mod testing { recipient_amounts in vec( arb_address().prop_flat_map(move |a| { arb_positive_note_value(MAX_NOTE_VALUE / n_recipients as u64) - .prop_map(move |v| (a.clone(), v)) + .prop_map(move |v| (a, v)) }), n_recipients as usize ), diff --git a/src/bundle.rs b/src/bundle.rs index 2b9de127..ac41e2fb 100644 --- a/src/bundle.rs +++ b/src/bundle.rs @@ -112,7 +112,7 @@ impl Action { Instance { anchor, cv_net: self.cv_net.clone(), - nf_old: self.nf.clone(), + nf_old: self.nf, rk: self.rk.clone(), cmx: self.cmx.clone(), enable_spend: flags.spends_enabled, diff --git a/src/circuit.rs b/src/circuit.rs index 16995821..3fbb2760 100644 --- a/src/circuit.rs +++ b/src/circuit.rs @@ -197,7 +197,7 @@ mod tests { let alpha = pallas::Scalar::random(&mut rng); let rk = ak.randomize(&alpha); - let (_, _, output_note) = Note::dummy(&mut rng, Some(nf_old.clone())); + let (_, _, output_note) = Note::dummy(&mut rng, Some(nf_old)); let cmx = output_note.commitment().into(); let value = spent_note.value() - output_note.value(); diff --git a/src/keys.rs b/src/keys.rs index e0029478..bcf3c1ef 100644 --- a/src/keys.rs +++ b/src/keys.rs @@ -421,7 +421,7 @@ impl DiversifiedTransmissionKey { } /// $repr_P(self)$ - pub(crate) fn to_bytes(&self) -> [u8; 32] { + pub(crate) fn to_bytes(self) -> [u8; 32] { self.0.to_bytes() } } diff --git a/src/note/nullifier.rs b/src/note/nullifier.rs index 2ae51c94..2f87148d 100644 --- a/src/note/nullifier.rs +++ b/src/note/nullifier.rs @@ -37,7 +37,7 @@ impl Nullifier { } /// Serialize the nullifier to its canonical byte representation. - pub fn to_bytes(&self) -> [u8; 32] { + pub fn to_bytes(self) -> [u8; 32] { self.0.to_bytes() }