From 705386e0311f23816b10c21671f065798e5fbee7 Mon Sep 17 00:00:00 2001 From: Venkat-corebts <143575548+Venkat-corebts@users.noreply.github.com> Date: Thu, 28 Sep 2023 17:47:21 +0530 Subject: [PATCH] [#948] Updated Settings screen UI * [#948] Updated Settings screen UI * [#948] Crash fix on settings screen * Center button UI components text So the text aligns with the center when the button is displayed on a very small device or, e.g., when the system accessibility text size increase feature is used. * Keep button spacing When rotated to landscape, the weighted spacing disappears. But we ideally want buttons to have all the same spacing around them in this scenario. * Kotlin code style * Move previous settings option to overflow - As the new design prescribes no debug/test options in the settings screen, we moved these useful actions into the only troubleshooting menu in the app bar. - Tests added * Add UI tests * Text in all caps in the components Rather than enforcing all caps in translations. --------- Co-authored-by: Honza --- .idea/codeStyles/Project.xml | 4 +- .../zcash/ui/design/component/Button.kt | 20 +- .../zcash/ui/design/theme/ExtendedColors.kt | 1 + .../zcash/ui/design/theme/internal/Color.kt | 11 +- .../ui/design/theme/internal/Typography.kt | 13 +- .../screen/settings/SettingsViewTestSetup.kt | 113 +++++++ .../TroubleshootingParametersFixture.kt | 25 ++ .../screen/settings/view/SettingsViewTest.kt | 284 +++++++++++------- .../ui/screen/settings/AndroidSettings.kt | 20 +- .../zcash/ui/screen/settings/SettingsTag.kt | 8 + .../model/TroubleshootingParameters.kt | 9 + .../ui/screen/settings/view/SettingsView.kt | 270 +++++++++++++---- .../main/res/ui/settings/values/strings.xml | 17 +- 13 files changed, 603 insertions(+), 192 deletions(-) create mode 100644 ui-lib/src/androidTest/java/co/electriccoin/zcash/ui/screen/settings/SettingsViewTestSetup.kt create mode 100644 ui-lib/src/androidTest/java/co/electriccoin/zcash/ui/screen/settings/fixture/TroubleshootingParametersFixture.kt create mode 100644 ui-lib/src/main/java/co/electriccoin/zcash/ui/screen/settings/SettingsTag.kt create mode 100644 ui-lib/src/main/java/co/electriccoin/zcash/ui/screen/settings/model/TroubleshootingParameters.kt diff --git a/.idea/codeStyles/Project.xml b/.idea/codeStyles/Project.xml index ca9a68bd..46402a65 100644 --- a/.idea/codeStyles/Project.xml +++ b/.idea/codeStyles/Project.xml @@ -9,8 +9,7 @@ -