From 598eac0eed86751dec876a1e1078edfd4298d26b Mon Sep 17 00:00:00 2001 From: Lukas Korba Date: Thu, 24 Feb 2022 14:14:50 +0100 Subject: [PATCH] Requested changes All PR comments have been fixed in this commit --- .../Features/BackupFlow/RecoveryPhraseValidation.swift | 2 +- .../Views/RecoveryPhraseBackupValidationView.swift | 10 ++++------ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/secant/Features/BackupFlow/RecoveryPhraseValidation.swift b/secant/Features/BackupFlow/RecoveryPhraseValidation.swift index 68eae62..c39a188 100644 --- a/secant/Features/BackupFlow/RecoveryPhraseValidation.swift +++ b/secant/Features/BackupFlow/RecoveryPhraseValidation.swift @@ -159,7 +159,7 @@ extension RecoveryPhraseValidationReducer { let value: RecoveryPhraseValidationAction = state.isValid ? .succeed : .fail return .concatenate( - .init(value: .failureFeedback), + Effect(value: .failureFeedback), Effect(value: value) .delay(for: 1, scheduler: environment.mainQueue) .eraseToEffect() diff --git a/secant/Features/BackupFlow/Views/RecoveryPhraseBackupValidationView.swift b/secant/Features/BackupFlow/Views/RecoveryPhraseBackupValidationView.swift index dc34175..00391f5 100644 --- a/secant/Features/BackupFlow/Views/RecoveryPhraseBackupValidationView.swift +++ b/secant/Features/BackupFlow/Views/RecoveryPhraseBackupValidationView.swift @@ -116,8 +116,7 @@ extension RecoveryPhraseValidationState { func wordsChips( for groupIndex: Int, groupSize: Int, - from wordGroup: RecoveryPhrase.Group, - state: RecoveryPhraseValidationState + from wordGroup: RecoveryPhrase.Group ) -> [PhraseChip.Kind] { let validationWord = validationWords.first(where: { $0.groupIndex == groupIndex }) @@ -127,7 +126,7 @@ extension RecoveryPhraseValidationState { } if let completedWord = validationWord?.word { - return .unassigned(word: completedWord, color: state.coloredChipColor) + return .unassigned(word: completedWord, color: self.coloredChipColor) } return .empty @@ -248,9 +247,8 @@ private extension WordChipGrid { ) { let chips = state.wordsChips( for: groupIndex, - groupSize: RecoveryPhraseValidationState.wordGroupSize, - from: wordGroup, - state: state + groupSize: RecoveryPhraseValidationState.wordGroupSize, + from: wordGroup ) self.init(chips: chips, coloredChipColor: state.coloredChipColor)