zec
/
secant-ios-wallet
mirror of https://github.com/zcash/secant-ios-wallet.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

[#512] Check that every TODO in code has an open issue (#513) 

Closes #512
This commit is contained in:
Francisco Gindre 2023-01-04 10:03:19 -03:00 committed by GitHub
parent a16de79a45
commit 9f4a9a101e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
secant/Features/RecoveryPhraseDisplay/RecoveryPhraseDisplayView.swift
View File

@ -75,7 +75,7 @@ struct RecoveryPhraseDisplayView: View {
.navigationBarHidden(true)
}
}
// TODO: This should have a #DEBUG tag, but if so, it's not possible to compile this on release mode and submit it to testflight
// TODO: This should have a #DEBUG tag, but if so, it's not possible to compile this on release mode and submit it to testflight https://github.com/zcash/ZcashLightClientKit/issues/695
extension RecoveryPhraseDisplayStore {
static var demo: RecoveryPhraseDisplayStore {
RecoveryPhraseDisplayStore(
@ -86,7 +86,7 @@ extension RecoveryPhraseDisplayStore {
}
}
// TODO: This should have a #DEBUG tag, but if so, it's not possible to compile this on release mode and submit it to testflight
// TODO: This should have a #DEBUG tag, but if so, it's not possible to compile this on release mode and submit it to testflight https://github.com/zcash/ZcashLightClientKit/issues/695
extension RecoveryPhrase {
static let testPhrase = [
// 1

2
secant/Features/Root/RootInitialization.swift
View File

@ -152,7 +152,7 @@ extension RootReducer {
Effect(value: .phraseValidation(.displayBackedUpPhrase))
)
} catch {
// TODO [#201]: - merge with issue 201 (https://github.com/zcash/secant-ios-wallet/issues/201) and its Error States
// TODO [#201]: - merge with issue 221 (https://github.com/zcash/secant-ios-wallet/issues/221) and its Error States
}
return .none

2
secant/Features/Settings/SettingsStore.swift
View File

@ -49,7 +49,7 @@ struct SettingsReducer: ReducerProtocol {
state.phraseDisplayState.phrase = recoveryPhrase
return Effect(value: .updateDestination(.backupPhrase))
} catch {
// TODO [#201]: - merge with issue 201 (https://github.com/zcash/secant-ios-wallet/issues/201) and its Error States
// TODO [#221]: - merge with issue 221 (https://github.com/zcash/secant-ios-wallet/issues/221) and its Error States
return .none
}

4
secant/UI Components/DesignGuide.swift
View File

@ -69,12 +69,12 @@ struct SmallVisualElements: View {
.navigationButtonStyle
.frame(width: 80, height: 40)
// TODO: Change state to selected
// TODO: Change state to selected https://github.com/zcash/ZcashLightClientKit/issues/696
Button("Back") { dump("Example button") }
.navigationButtonStyle
.frame(width: 80, height: 40)
// TODO: Change state to selected
// TODO: Change state to selected https://github.com/zcash/ZcashLightClientKit/issues/696
Button("Skip") { dump("Example button") }
.navigationButtonStyle
.frame(width: 80, height: 40)

2
secant/Utils/Previews.swift
View File

@ -1,6 +1,6 @@
import SwiftUI
// TODO: This should have a #DEBUG tag, but if so, it's not possible to compile this on release mode and submit it to testflight
// TODO: This should have a #DEBUG tag, but if so, it's not possible to compile this on release mode and submit it to testflight https://github.com/zcash/ZcashLightClientKit/issues/695
struct StateContainer<T, Content: View>: View {
@State private var state: T
private var content: (Binding<T>) -> Content

2
secant/Utils/Strings.swift
View File

@ -1,6 +1,6 @@
import Foundation
// TODO: This should have a #DEBUG tag, but if so, it's not possible to compile this on release mode and submit it to testflight
// TODO: This should have a #DEBUG tag, but if so, it's not possible to compile this on release mode and submit it to testflight https://github.com/zcash/ZcashLightClientKit/issues/695
extension String {
init<T>(dumping value: T) {
var output = String()