Commit Graph

6 Commits

Author SHA1 Message Date
Michal Fousek a4d35b759f
[#546] Update how swiftlint is used (#547)
Closes #546

- Have separate swiftlint config for code and for tests.
2023-02-28 15:32:36 -03:00
Michal Fousek a1104163f3
[#554] Add WalletConfigProvider (#574)
- Added `WalletConfigProvider` object which handles loading and caching of
  feature flags.
- Added `WalletConfig` which represents one configuration
  of all feature flags.
2023-02-24 17:33:46 +01:00
Francisco Gindre adb48ba507
[#541] Adopt Latest main commit of SDK (#542)
* [#541] Adopt Latest main commit of SDK

This adopts commit `cf60f44aa83938432c81361917406483ff42c719` from `main`
branch of ZcashLightClientKit.

It includes changes to remove a fake "defaultBirthday" and use the real
`BlockHeight.ofLatestCheckpoint()` function that allows the wallets
to fetch the latest checkpoint available from bundle and define it as the
birthday. Also "defaultBirthday" birthday was incorrectly being used as a
replacement for Sapling Activation height which is the minimum birthday
supported by the wallet in terms of shielded pools.

Wallets with lower heights that have only transparent funds could in theory
work, but they won't be able to see sprout funds. Also the the SDK won't provide a birthday prior to sapling activation.

removes references to `LightWalletService` since this class has been made
internal to the SDK only.

adopts FsBlockDb and adds a FsBlockDbRoot directory dependency for the
Databases dependencies. Which should be renamed in a later commit

Closes #541

* Fix SwiftLint issues
2023-02-15 19:27:52 -03:00
Lukas Korba 61567834a4
[#521] Update format for the Swiftlint TODO rule (#522)
- TODO rule updated in the yml file
- all TODOs updated to the new format
- some missing TODOs updated as well
- code cleanup
2023-01-20 14:55:08 +01:00
Michal Fousek 6bf65b1d4d
[#25] Add swiftlint rule to detect TODO without issue number (#425)
Closes #25

- Add `todos` swiftlint rule which detects `TODO:` or `FIXME:` without
  ticket number.
- Use `TODO [#<issue number>]:` to not trigger this rule.
- Updated TODOs and FIXMEs which had issue number in different format in
  the code.
2022-09-26 17:30:07 +02:00
Adam Stener 789333f234 Enable SwiftLint 2021-09-16 05:34:54 -05:00