Commit Graph

675 Commits

Author SHA1 Message Date
Lukas Korba abb8dcea29 [#1093] Zashi-iOS audit Issue B
- The URL scheme has been removed entirely from the project

[#1093] Zashi-iOS audit Issue B (#1105)

- removed from testnet target
2024-03-08 13:37:16 +01:00
Lukas Korba 746b6859a7 [#1097] Zashi-iOS audit Issue E
- copy with expiry time set draft

[#1097] Zashi-iOS audit Issue E

- copy to pasteboard has been removed from recovery phrase seed completely
- copy seed to pasteboard added to the debug menu, please note, the debug menu will not be in production build, issue #1113
2024-03-08 13:31:55 +01:00
Lukas Korba 22fab58852 [#940] Set final privacy policy URL for iOS
- new URL used
2024-03-08 13:09:55 +01:00
Lukas Korba b5a71c7bed [#1106] Zashi-iOS audit Issue G
- storedWallet is no longer held in memory
- unit tests fixed
2024-03-06 16:12:23 +01:00
Lukas Korba 6970b6ff60
Merge pull request #1091 from LukasKorba/1086-Resolve-interaction-with-the-keychain-for-both-fore-and-background-app-states
[#1086] Resolve interaction with the keychain for both fore and background app states
2024-03-04 13:42:19 +01:00
Lukas Korba 557cae3552 [#1086] Resolve interaction with the keychain for both fore and background app states
- draft

[#1086] Resolve interaction with the keychain for both fore and background app states

- revert

[#1086] Resolve interaction with the keychain for both fore and background app states

- initialization pipeline updated to handle state when BGTask runs with fresh app start, in such case Zashi wait and doesn't try to initialize SDK -> no keychain error is triggered

[#1086] Resolve interaction with the keychain for both fore and background app states

- code cleaned up
- finished the state handling
- closing the BGTask asap for state that is supposed to just wait

[#1086] Resolve interaction with the keychain for both fore and background app states

- unit tests fixed

[#1086] Resolve interaction with the keychain for both fore and background app states (#1091)

- Comments addressed

[#1086] Resolve interaction with the keychain for both fore and background app states (#1091)

- Unit tests fixed
- Block time of didFinishLaunching increased to 0.5s (from 0.02)
2024-03-03 10:09:16 +01:00
Lukas Korba 487abbd9bf
Merge pull request #1089 from LukasKorba/931-Statuses-of-the-sync-process-dependency
[#931] Statuses of the sync process dependency
2024-03-02 18:03:00 +01:00
Lukas Korba 2ba8f26d0a
Merge pull request #1088 from LukasKorba/1055-Handle-unavailable-AccountBalance
[#1055] Handle unavailable AccountBalance
2024-02-29 08:11:53 +01:00
Lukas Korba 99e1b12e7d [#931] Statuses of the sync process dependency
- Statuses updated according to the product/design requirements.
2024-02-27 12:56:06 +01:00
Lukas Korba 21b01fca7d [#1055] Handle unavailable AccountBalance
- The available balance 0 scenario is now handled on a product/design level and the 0 is replaced with a progress view.
- There is some redundancy in the code that is going to be resolved in #1087 because it will require to implement a brand new reducer and stream subscriber, out of the scope of this issue.

[#1055] Handle unavailable AccountBalance

- Changelog updated.

[#1055] Handle unavailable AccountBalance (#1088)

- rebased
2024-02-27 12:54:39 +01:00
Lukas Korba ecc8ec9c1d
Merge pull request #1078 from LukasKorba/1051-Crashlytics-acknowledge
[#1051] Crashlytics acknowledge
2024-02-27 12:52:38 +01:00
Lukas Korba 6b94e1a8f6 [#1051] Crashlytics acknowledge (#1078)
- comments addressed

[#1051] Crashlytics acknowledge (#1078)

- documented what boolean values represents
2024-02-27 12:52:11 +01:00
Lukas Korba 45d7241d33
Merge pull request #1085 from LukasKorba/1082-New-shielding-explanation-copy
[#1082] New shielding explanation copy
2024-02-27 12:48:57 +01:00
Lukas Korba f1c7df7768 [#1082] New shielding explanation copy (#1085)
- generated file updated
2024-02-27 12:46:40 +01:00
Lukas Korba 6c83487da4
Update modules/Sources/Generated/Resources/Localizable.strings
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
2024-02-27 12:43:42 +01:00
Lukas Korba 97dc8eea80
Merge pull request #1083 from LukasKorba/1080-Send-amount-enhancements
[#1080] Send amount enhancements
2024-02-25 09:23:20 +01:00
Lukas Korba 18ee995a42
Merge pull request #1084 from LukasKorba/940-Set-final-privacy-policy-URL-for-iOS
[#940] Set final privacy policy URL for iOS
2024-02-23 12:31:31 +01:00
Lukas Korba a83dfa73f7 [#1082] New shielding explanation copy
- Message for the transparent hint box updated
2024-02-22 14:05:22 +01:00
Lukas Korba ab10520492 [#940] Set final privacy policy URL for iOS
- link updated
2024-02-22 13:58:05 +01:00
Lukas Korba a0a17c6d49 [#1080] Send fields enhancements
- All bullet points from the parent ticket have been resolved
- The keyboard is not decimal one so users don't need to switch to numbers + it reduces cases when users fill in some alphabetical letters + it improved the UX with floating point comma vs. point
- Error handling fixed
- Max amount fix and rely on spendable balance
- Unit tests fixed
2024-02-22 13:47:15 +01:00
Lukas Korba c9f1e85c1f [#1060] Memo field behaviours for transparent address
- MessageEditor updated to present disabled state in a different way
- Text in the memo is not persisted when the transparent address is used and MessageBox disabled
- New unit tests implemented and many more updated

[#1060] Memo field behaviours for transparent address (#1075)

- comments addressed

[#1060] Memo field behaviours for transparent address (#1075)

- debug code removed

[#1060] Memo field behaviours for transparent address (#1075)

- code revert
2024-02-22 13:46:23 +01:00
Lukas Korba 25197b1dc6 Update modules/Sources/Generated/L10n.swift
Co-authored-by: str4d <thestr4d@gmail.com>
2024-02-22 10:04:57 +01:00
Lukas Korba ff5cc09941 [#1051] Crashlytics acknowledge
- Layout changes for the Security warning consent
- The screen has also been refactored to the latest TCA
- Unit tests fixed
2024-02-22 10:04:57 +01:00
Lukas Korba 039af8c863
Merge pull request #1069 from LukasKorba/988-Scan-UI
[#988] Scan UI
2024-02-22 09:04:10 +01:00
Lukas Korba 6b6c586f01 [#988] Scan UI (#1069)
- comments addressed
2024-02-22 09:03:42 +01:00
Lukas Korba 774f5d294d Update modules/Sources/Features/Scan/ScanStore.swift
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-02-22 09:03:42 +01:00
Lukas Korba 5a96727b01 [#988] Scan UI
- new layout for the scan screen

[#988] Scan UI

- new layout and design for scan
- camera not authorized case + UI
- scan store refactored to the latest TCA
- unit test fixed

[#988] Scan UI (#1069)

- changelog update
2024-02-22 09:03:42 +01:00
Lukas Korba 32b7afb867
Merge pull request #1077 from LukasKorba/1037-Consolidate-back-button-on-the-phrase-display-screen
[#1037] Consolidate back button on the phrase display screen
2024-02-22 08:53:51 +01:00
Lukas Korba ef64496739 [#1037] Consolidate back button on the phrase display screen
- ZashiBackModifier updated with a new hidden param. This way it can be controlled by views for dynamic scenarios.
- Reducer updated to latest TCA.
- Unit tests refactored and fixed.

[#1037] Consolidate back button on the phrase display screen

- updated test
2024-02-20 15:25:03 +01:00
Lukas Korba 21cb72dfc9
Merge pull request #1065 from LukasKorba/1056-Redactable-AccountBalance
[#1056] Redactable AccountBalance
2024-02-20 12:10:51 +01:00
Lukas Korba e494744fcc
Merge pull request #1072 from LukasKorba/1067-Disable-logging-for-production
[#1067] Disable logging for production
2024-02-20 12:08:52 +01:00
Lukas Korba 3460cf6f58 [#1067] Disable logging for production
- There are 3 different and independent loggers that have been disabled for production (release configuration builds)
- The TCA logger doesn't call os_log()
- The SDK is instantiated with .noLogging policy
- The Wallet logger is never set so it's nil
- With no logs the export logs button in Export Private Data screen no longer makes sense so I removed it from the UI

[#1067] Disable logging for production (#1072)

- project reverted back
2024-02-20 12:06:30 +01:00
Lukas Korba 06cc8ed1c1
Merge pull request #1073 from LukasKorba/1068--False-positive-keysMissing-detection
[#1068] False positive keysMissing detection
2024-02-20 12:03:31 +01:00
Lukas Korba 6b783cbbe5
Merge pull request #1074 from LukasKorba/1070-No-email-account-in-iPhone-error-handling
[#1070] No email account in iPhone error handling
2024-02-20 12:03:07 +01:00
Lukas Korba 5afe5fb1dd [#1070] No email account in iPhone error handling
- Alert view message updated
- Copy support email button added to the alert view
- Unit test for the new functionality added

[#1070] No email account in iPhone error handling (#1074)

- empty row comment addressed
2024-02-20 12:02:38 +01:00
Lukas Korba 9d7d9badb6 [#1068] False positive keysMissing detection
- Change of the setup of the keychain massively reduces the probability and frequency of cases when the keychain is required to provide data. Background task for the sync was the main producer of these attempts to read the data, the new flag allows BGTask to operate freely with no errors related to the keychain. Ultimate solution how to make it even better is covered in #1071, TODO added to the code.
2024-02-19 14:04:42 +01:00
Lukas Korba 33b94b517d
Merge pull request #1066 from LukasKorba/1053-Improve-successful-restore-message
[#1053] Improve successful restore message
2024-02-16 08:49:39 +01:00
Lukas Korba 4639e4fc84 [#1053] Improve successful restore message
- text has been updated
2024-02-15 13:13:29 +01:00
Lukas Korba 21412a356b [#1056] Redactable AccountBalance
- AccountBalance has been wrapped into RedactableAccountBalance
- SynchronizerState has been wrapped into RedactableSynchronizerState
- Code updated to use these new redactable structs instead of direct use of unredacted ones
- tests fixed
2024-02-15 12:42:11 +01:00
Lukas Korba 10eb66f1a2
Merge pull request #1061 from LukasKorba/1058-Cleanup-dependency-injection-in-reducers
[#1058] Cleanup dependency injection in reducers
2024-02-14 19:33:20 +01:00
Lukas Korba 9b683651cf [#1058] Cleanup dependency injection in reducers
- All work here is just cleanup of obsolete dependency injection. #981 introduced a brand new approach of DI for token name and SDK constants. That allowed me to deliver expected values directly in the TCA fashion so all reducers no longer needed those values to be passed via initializers.
2024-02-14 14:42:01 +01:00
Lukas Korba 48536e5fa0
Merge pull request #1059 from LukasKorba/981--Send-button-disable-check-must-include-the-fee
[#981] Send button disable check must include the fee
2024-02-14 14:39:27 +01:00
Lukas Korba 0faa37c243 [#981] Send button disable check must include the fee
- the fee is now checked and it's coming from the SDK
- unit test checking validity of the form when not enough Zatoshi for the fee has been implemented
- brand new concept of handling the SDK constants inside the TCA has been implemented, will greatly simplify cleanup of all reducers (see #1058)
2024-02-14 12:44:42 +01:00
Lukas Korba b668b15f04
Merge pull request #1048 from LukasKorba/975-Localize-the-balances
[#975] Localize the balances
2024-02-14 12:02:24 +01:00
Lukas Korba 783ed20c20 [#975] Localize the balances
- The Zatoshi decimals have been localized with respect to floating point style
- unit tests fixed + new set of comma tests implemented

[#975] Localize the balances (#1048)

- pre-rebase

[#975] Localize the balances (#1048)

- "<" localized

[#975] Localize the balances (#1048)

- rebased
2024-02-14 11:30:47 +01:00
Lukas Korba 82fd0e043f
Merge pull request #1047 from LukasKorba/1032-Advanced-settings
[#1032] Advanced settings
2024-02-14 11:16:20 +01:00
Lukas Korba 8498cff744 [#1032] Advanced settings
- all buttons moved to appropriate positions and screens
- business logic rewired
- all new texts localized
- changelog updated

[#1032] Advanced settings

- unit tests fixed

[#1032] Advanced settings (#1047)

- separate reducer for advanced settings
2024-02-14 11:12:51 +01:00
Lukas Korba 5d078035f4 [#1028] Runtime switch of lightwalletd servers
- prototype of the solution implemented

[#1028] Runtime switch of lightwalletd servers

- error handling done
- localized all new texts
- custom server resolved with all possible parsing states
- persistency of selected server done

[#1028] Runtime switch of lightwalletd servers (#1044)

- changelog update

[#1028] Runtime switch of lightwalletd servers (#1044)

- Unfortunately the compiler has a bug so Circular reference error is not possible to solve, Apple fixed reported issue from October 2023 last week so we should expect fix in Xcode 15.3, beta is released but still no fix. Until that moment I moved placeholders to the view and will move it back to the stores once the issue is resolved
2024-02-14 11:12:51 +01:00
Lukas Korba 8372df6f1e [#1028] Runtime switch of lightwalletd servers
- prototype of the solution implemented

[#1028] Runtime switch of lightwalletd servers

- error handling done
- localized all new texts
- custom server resolved with all possible parsing states
- persistency of selected server done

[#1028] Runtime switch of lightwalletd servers (#1044)

- changelog update

[#1028] Runtime switch of lightwalletd servers (#1044)

- Unfortunately the compiler has a bug so Circular reference error is not possible to solve, Apple fixed reported issue from October 2023 last week so we should expect fix in Xcode 15.3, beta is released but still no fix. Until that moment I moved placeholders to the view and will move it back to the stores once the issue is resolved

[#1028] Runtime switch of lightwalletd servers (#1044)

- adoption of SDK 2.0.10
2024-02-14 11:12:51 +01:00
Lukas Korba 924e318be3
Merge pull request #1044 from LukasKorba/1028-Runtime-switch-of-lightwalletd-servers
[#1028] Runtime switch of lightwalletd servers
2024-02-14 11:11:00 +01:00