Commit Graph

58 Commits

Author SHA1 Message Date
Lukas Korba f58b17e6e1 Validation Failure/Success updated to handle dark mode 2022-03-15 16:33:54 +01:00
Lukas Korba 6380452780 Hotfix for the broken animation 2022-03-07 10:30:06 +01:00
Francisco Gindre f81d9fa7ac
Merge branch 'main' into 139_ValidationSuccessScreen_DesignUpdate 2022-03-04 12:43:33 -03:00
Lukas Korba 146404989b Backup Succeeded View design
updated to the latest
2022-03-04 11:38:15 +01:00
Lukas Korba 545df13602 Backup Failed design updated
to the latest design

smaller enhancements
2022-03-04 11:35:52 +01:00
Lukas Korba 9c887367c4 code clean up 2022-03-03 13:06:47 +01:00
Lukas Korba 0ac32c9854 FIXME added 2022-03-03 11:37:29 +01:00
Lukas Korba d3e0f4f1e5 debugging the navigation
code cleanup

I reimplemented preamble screen so it's not "a feature" but it's a simple view with the set of bindings
2022-03-03 11:29:00 +01:00
Lukas Korba 28c7cf98b5 Merge branch 'main' into 147_phrase_preamble_screen 2022-03-02 10:27:29 +01:00
Lukas Korba a9dfadbc18 final enhancements
tested for iPhone SE, light/dark and accessibility large
2022-03-02 10:20:12 +01:00
Lukas Korba 158c75ce57 Merge branch '165_wallet_import_screen' of https://github.com/LukasKorba/secant-ios-wallet into 165_wallet_import_screen 2022-03-01 17:10:19 +01:00
Lukas Korba b0dff8a063 pointless comment removed 2022-03-01 17:10:09 +01:00
Lukas Korba 3fd5a2061d
Update secant/Features/ImportWallet/ImportWalletStore.swift
Co-authored-by: Francisco Gindre <francisco.gindre@gmail.com>
2022-03-01 17:09:18 +01:00
Lukas Korba b3b6be8037 First draft of the screen
the circular frame needs to be updated so it fits iPhone SE, otherwise screen is ready
2022-03-01 15:30:32 +01:00
Lukas Korba e52b28adc3 Import Wallet localised
localisation of the import wallet screen done

Height of the buttons

according to design guide, the buttons should be 64px height
2022-03-01 09:40:16 +01:00
Lukas Korba dfca94677d Merge branch '174_app_localization' into 165_wallet_import_screen 2022-03-01 09:17:03 +01:00
Lukas Korba f6548ee4ff Import Wallet Screen added
Scaffold of the import wallet screen has been created and connected to the onboarding flow
2022-03-01 09:12:50 +01:00
Lukas Korba b2bd0adaea Required strings localized
All screens' strings that are meaningful for the demo application have been moved to the strings file.
2022-02-25 13:27:50 +01:00
Francisco Gindre 3b2dd7c43a
Merge pull request #170 from LukasKorba/163_validation_feedback
Requested changes done
2022-02-24 13:57:17 -03:00
Lukas Korba 465d4feded Test fixes 2022-02-24 17:26:06 +01:00
Lukas Korba 598eac0eed Requested changes
All PR comments have been fixed in this commit
2022-02-24 14:14:50 +01:00
Lukas Korba e618cc48e5 Generator moved
I decided to also follow the Pastboard dependency and get rid of the specific file just for the generator.
2022-02-23 18:51:18 +01:00
Lukas Korba b7fccb3c28 TCA way
The syntax convention for the feedback generator was re-implemented to follow TCA and secant wallet principles.
2022-02-23 18:39:39 +01:00
Lukas Korba c8e54550fc Requested changes done
The failed color (red) updated. The haptic feedback (.error) now occurs when the chips are not at the right indices.
2022-02-23 17:49:17 +01:00
Lukas Korba 1e12d472f8
Merge branch 'zcash:main' into 138_onbordingUI_enhancements 2022-02-23 15:05:30 +01:00
Lukas Korba 8931433f8e Button UI updates
Colors updated, pressed button simulated and present in the DesignGuide.swift
2022-02-22 15:44:29 +01:00
Dimitris Apostolou b2eb4b228e
Fix typos 2022-02-18 23:39:04 +02:00
Francisco Gindre b42cc56906 Issue #61 - Zcash Logo and welcome screen
Text shadows

font adjustments

Naïvely integrate to navigation

bump build

fix lint warning

PR Suggestions
2022-02-18 11:06:17 -03:00
Francisco Gindre b75def9cc1 Issue #44: Recovery Phrase Validation flow + tests
Rename struct to RecoveryPhraseValidationState. Add docs

WordGrid + tests

Make Word Groups Droppable and Blue word chips draggable

cleanup

Rename Stores and adopt aliases and default pattern for reducers

Fix drop not working

FIX: apply background to header. Spacing

Fix compilation errors. Add validation demo to AppView

Fix: the empty chips are rendered once, because they are not uniquely identifiable

Add the Validation screen to the App Home

make mutating functions static

fix project warnings

Fix Tests

Fixed .complete test

refactoring the Enum. first step

Move given() to RecoveryPhraseValidationState and fix tests

Add canary test for computed property of State

Move RecoveryPhraseValidationStep to a nested type of RecoveryPhraseValidationState

rename RecoveryPhraseValidationState.RecoveryPhraseValidationStep to RecoveryPhraseValidationState.Step

Move static functions from RecoveryPhraseValidationStep to RecoveryPhraseValidationState

Move creational factory methods together to the same extension

Remove unused functions

remove associated values from Step enum

Fix: Avoid Drop being disable between chips

0.0.1-10

add navigation bar to phrase validation demo

Reduce spacing between groups. Code cleanup

Remove RecoveryPhraseValidationStep.swift
Move remaining code to proper places

PR Fixes. Move .initial factory method to test target. Rename given() to apply(chip:group:) and make it a member function

Cleanup. Remove .validate, .invalid and .valid states. Figure word chips out of the state.

Fix randomIndices()

Tie view's title to state

Connect Header to State

BlueChip is now ColoredChip.

Success Screen

fix project

Connect Success Screen to successful validation

Add Red color to backgrounds

Validation Failed Screen

Connect SuccessValidation Screen to home

hide back button on Success view

Connect Phrase Display to validation

0.0.1-11

Fix word grid background colors

View Modifier to add scrollview when the content is being scaled up by DynamicType

Adjust UI spacing and padding to designs

Add Placeholder states for SwiftUI Previews

Flatten EnumeratedChip Hierarchy

Flatten EnumeratedChip view hierarchy

Fix: LazyVGrid can't take GeometryReader on its items' bodies

Fix: Colored Chip does not adjust

Fix: Vertical separation between wordgroups is too tall.

Fix: Accesibility fixes for Validation Failed screen

Rename ValidationFailedView

Accessibility Pass on Validation success screen

 FIX: Colored chips too big when scaled up

Fix: ValidationFailedScreen does not scroll well when scaled up

Fix Empty chip shadow color for dark color scheme

Fix: chip grid background does not bleed out to bottom of the screen

build 12

Fix: pre success/failure screen step shrinks the screen because word grid is missing

Resolved PR comments

Fixes to resolve PR conversations

Fixes to resolve PR conversations

Fix PhraseChip preview

Make ScrollableWhenScaledUp modifier fileprivate

Remove comments and clean up code

Fix Swiftlint issues

Renamed RecoveryPhraseStepFulfillment to ValidationWord

Rename pickWordsFromMissingIndices

PR fixes

PR suggestions

PR suggestions

Move words(fromMissingIndices:size) to RecoveryPhrase

Make ScrollableWhenScaled struct fileprivate

PR Suggestions Part two

PR Suggestion changes

remove unused

PR suggestions

suggested rename

PR suggestions

remove apply(chip:into) move that to Reducer

Formatting changes

more formatting changes

Fix: iPhone 13 Pro Max displays 4 columns instead of three

Fix: Recovery Phrase puzzle shows incorrect number of columns and margin alignment on bigger devices

Add test to catch state not changing as intended

Phrase validation reducer refactor + tests

make step computed property a bool

make isComplete a single line

PR Suggestions

Rename ValidationSuccededView.swift

Fix Bug: valid phrase should contemplate that the phrase is complete first

PR Suggestion

refactor and add Unit Tests for resultingPhrase, isComplete, isValid
2022-02-18 10:26:11 -03:00
Daniel Haight c37e9a2ade [Refactor] remove unused code
No significant code changes, just consolidating helper methods
and removing unused code.
2021-12-14 22:38:30 +00:00
Daniel Haight cd3c98cce4 Add button to show history placeholder from 2021-12-14 22:25:59 +00:00
Daniel Haight b2320c057a [lint] fix swiftlint warnings 2021-12-14 02:50:55 +00:00
Daniel Haight 8ec6494044 Add `.reset` action to `Home`
This is here for convenience while we are in the "placeholder" stages,
to give a way to navigate to the "App" screen from Home
2021-12-14 02:50:55 +00:00
Daniel Haight 9f7c5c158a Add App placeholder feature
This feature represents the "entrypoint" of the app.

As it stands now it combines the home, and onboarding features.

Notice how we have created `AppReducer.routeReducer` to (temporarily)
use use the `OnboardingAction.createWallet` action, to navigate directly
to `Home` while we are still implementing it.
2021-12-14 02:50:55 +00:00
Daniel Haight c0dd6f8015 Add Profile placeholder feature
This feature is a very basic example of combining two existing features
that can be navigated to. Aside from this it currently has no other functionality, and is
intended to exist as yet another feature that can be navigated to.
2021-12-14 02:50:53 +00:00
Daniel Haight 4166439ffa Add Request placeholder feature
This is boiler plate to flesh out a feature to navigate to
2021-12-14 02:50:14 +00:00
Daniel Haight 9720e8c59b Add Scan placeholder feature
This is boiler plate to flesh out a feature to navigate to
2021-12-14 02:38:22 +00:00
Daniel Haight 20cc378ee9 Add Settings placeholder feature
This is boiler plate to flesh out a feature to navigate to
2021-12-14 02:34:31 +00:00
Daniel Haight 202808097c Add WalletInfo placeholder feature
This is boiler plate to flesh out a feature to navigate to
2021-12-14 02:34:31 +00:00
Daniel Haight 82e8f5cc78 Refactor home view to show different routes better
This makes navigation while we are dealing with placeholders much easier,
though this will likely _all_ be deleted as we start to implement proper UIs
2021-12-14 02:34:21 +00:00
Daniel Haight 0481038986 Remove onboarding nav from home
We will link it differently shortly when we introduce an "app" view / feature
which will act as the first / root screen
2021-12-14 02:29:32 +00:00
Daniel Haight 61696bbda6 [cleanup] tidy `.demo` properties and rename to `.placeholder` 2021-12-14 02:27:13 +00:00
Francisco Gindre 5646afbdd5 First Stab at The Composable Architecture
Initial Light Mode Recovery Phrase Backup Screen

Dark mode color adjustments

Quotes "Navigation Bar Title"

Fix Recovery Phrase chips throw a UI Thread warning

Integrate Copy to buffer button

create test build 4 for UX validation

FIX: Archiving compilation errors

fix warnings. add TODOs for demo code that is needed to build on release mode

PR Fixes: remove dump calles add TODOs

remove unneeded padding

remove prints

PR fixes: remove min height from standard button style.

change extension from View to Text

change comment format

PR Fixes. code style

Add ticket number to TODOs

Rename "Backup Flow" to BackupFlow

PR lint fixes

Add tests

Fix lint issue. cleanup

rename "UI Components" to "UIComponents"

Renamed folder with spaces to CamelCase names:
"App Errors" to "AppErrors"
"Mocked Dependencies" to "MockedDependencies"

Renamed "Font Styles" to "FontStyles"

hook up to home screen

Adding: [Suggestion(adding pasteboard to environment)]

Implement [Suggestion(use specific RecoveryPhraseError) | non-blocking]

Remove double carriage return and replace by VStack of Text()

add App Uses Non-Exempt Encryption -> NO value to Info.plist

bump build #

0.0.1-7

make view modifiers private

move modifiers into extension

Testable Pasteboard

Fix: Word groups don't have noticeable spacing that allows the user to tell them apert

FIX: don't truncate enumerated chips
2021-12-13 15:58:13 -03:00
Francisco Gindre 3422c8dbd0 Integrate onboarding to fake home
show OnboadingScreen instead of  OnboardingView

remove Struct Type
2021-12-08 19:47:35 -03:00
Francisco Gindre c702319bb5
Merge pull request #122 from adamstener/onboarding-screen
Onboarding Screen
2021-12-08 14:32:39 -03:00
adam cc32e881ba Onboarding Screen 2021-12-07 06:18:35 -06:00
Daniel Haight 780dd0fafa [Experiment] Move `Send` routing into a parent `SendView`
This is to demonstrate having something like a 'Coordinator' that
handles the routing logic of the feature.

It is done as a seperate commit to compare against the original
implementation that has the routing logic encoded explicitely in
each view.
2021-11-21 14:51:32 +00:00
Daniel Haight a8fc8d79f7 Create a reducer to go back `Home` when finished sending
This is done as a seperate commit to demonstrate composing routing
logic where a 'child' feature can send messages to a 'parent'.
2021-11-21 14:51:32 +00:00
Daniel Haight 85395bb9f0 Add `Send` "Placeholder" Feature
This adds screens to represent a basic "Send" Feature. The main
purpose of this is two-fold.

1. To act as a placeholder for the actual journet
2. To demonstrate a slightly different navigation paradigm, i.e,
   a `NavigationView` with >1 depth.
2021-11-21 14:47:51 +00:00
Daniel Haight c6a98f06c2 Add `WithStateBinding`
This is a way to add back some of the "free" animations that we lose when
creating custom bindings instead of using `@State` variables, which is
extremely common in TCA / unidirectional architecture.

For an example check out the live preview in the `WithStateBinding` file.
The first is with a standard State binding, click to get the detail and then
drag from the leading edge slowly. You will notice the selection highlight _gradually_
gets less the more you drag (or stronger if you go back).

For the second one with a custom binding, drag back and you will notice it is either
entirely selected, or deselected.

The third uses `WithStateBinding` to give _back_ the nice animations to custom bindings.
2021-11-15 23:36:16 +00:00