zec
/
zcash-android-wallet-sdk
mirror of https://github.com/zcash/zcash-android-wallet-sdk.git

[#843] Ktlint 0.48.2 

- Removed semicolon in enum classes suppression
- Created and linked issue for test wallets values
This commit is contained in:
Honza Rychnovsky 2023-01-31 15:17:51 +01:00 committed by GitHub
parent b1810f2982
commit 7d065ceaf7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
darkside-test-lib/src/androidTest/java/cash/z/ecc/android/sdk/darkside/test/TestWallet.kt
View File

@ -164,11 +164,9 @@ class TestWallet(
}
}
// TODO [843]: Ktlint 0.48.1 (remove this suppress)
// TODO [843]: https://github.com/zcash/zcash-android-wallet-sdk/issues/843
@Suppress("ktlint:no-semi")
enum class Backups(val seedPhrase: String, val testnetBirthday: BlockHeight, val mainnetBirthday: BlockHeight) {
// TODO: get the proper birthday values for these wallets
// TODO: [#902] Get the proper birthday values for test wallets
// TODO: [#902] https://github.com/zcash/zcash-android-wallet-sdk/issues/902
DEFAULT(
"column rhythm acoustic gym cost fit keen maze fence seed mail medal shrimp tell relief clip cannon foster soldier shallow refuse lunar parrot banana",
BlockHeight.new(
@ -208,6 +206,6 @@ class TestWallet(
1_330_190
),
BlockHeight.new(ZcashNetwork.Mainnet, 1_000_000)
);
)
}
}

2
gradle.properties
View File

@ -81,7 +81,7 @@ EMULATOR_WTF_GRADLE_PLUGIN_VERSION=0.0.15
FLANK_VERSION=23.01.0
FULLADLE_VERSION=0.17.4
GRADLE_VERSIONS_PLUGIN_VERSION=0.44.0
KTLINT_VERSION=0.48.0
KTLINT_VERSION=0.48.2
KSP_VERSION=1.8.0-1.0.8
PROTOBUF_GRADLE_PLUGIN_VERSION=0.8.19
RUST_GRADLE_PLUGIN_VERSION=0.9.3

8
sdk-lib/src/androidTest/java/cash/z/ecc/android/sdk/util/TestWallet.kt
View File

@ -166,11 +166,9 @@ class TestWallet(
}
}
// TODO [843]: Ktlint 0.48.1 (remove this suppress)
// TODO [843]: https://github.com/zcash/zcash-android-wallet-sdk/issues/843
@Suppress("ktlint:no-semi")
enum class Backups(val seedPhrase: String, val testnetBirthday: BlockHeight, val mainnetBirthday: BlockHeight) {
// TODO: get the proper birthday values for these wallets
// TODO: [#902] Get the proper birthday values for test wallets
// TODO: [#902] https://github.com/zcash/zcash-android-wallet-sdk/issues/902
DEFAULT(
"column rhythm acoustic gym cost fit keen maze fence seed mail medal shrimp tell relief clip cannon foster soldier shallow refuse lunar parrot banana",
BlockHeight.new(
@ -210,6 +208,6 @@ class TestWallet(
1_330_190
),
BlockHeight.new(ZcashNetwork.Mainnet, 1_000_000)
);
)
}
}

4
sdk-lib/src/main/java/cash/z/ecc/android/sdk/ext/ConsensusBranchId.kt
View File

@ -7,9 +7,7 @@ import java.util.Locale
* omitted since this is not the source of truth for branch information but rather a tool for
* printing that information to users.
*/
// TODO [843]: Ktlint 0.48.1 (remove this suppress)
// TODO [843]: https://github.com/zcash/zcash-android-wallet-sdk/issues/843
@Suppress("MagicNumber", "ktlint:no-semi")
@Suppress("MagicNumber")
enum class ConsensusBranchId(val displayName: String, val id: Long, val hexId: String) {
// TODO [#679]: see if we can find a way to not rely on this separate source of truth (either stop converting from
// hex to display name in the apps or use Rust to get this info)