zec
/
zcash
mirror of https://github.com/zcash/zcash.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

CI: Use `github.head_ref` instead of `HEAD` for "recent base" check 

The `pull_request_target` event causes `actions/checkout` to check out
the target branch (e.g. the main repo's `master` branch) instead of the
PR's branch. This meant that after zcash/zcash#6487 merged, the check
would always pass (because the queried revision is always present in the
history of `master`). `github.head_ref` correctly points to the tip of
the PR's branch, ensuring that `git merge-base --is-ancestor` performs
the expected comparison.
This commit is contained in:
Jack Grigg 2023-03-15 15:33:05 +00:00
parent 219b9c68b0
commit 41997a5ac3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/checks.yml vendored
View File

@ -18,7 +18,7 @@ jobs:
- name: Ensure branch contains necessary commits for Tekton CI - name: Ensure branch contains necessary commits for Tekton CI
id: tekton id: tekton
# https://github.com/zcash/zcash/pull/6358 # https://github.com/zcash/zcash/pull/6358
run: git merge-base --is-ancestor 267ddf8efe36cc799c4c31772a8883ea332ef55b HEAD run: git merge-base --is-ancestor 267ddf8efe36cc799c4c31772a8883ea332ef55b ${{ github.head_ref }}
- name: Tell PR author if they need to rebase - name: Tell PR author if they need to rebase
if: failure() && steps.tekton.outcome == 'failure' if: failure() && steps.tekton.outcome == 'failure'