#!/usr/bin/env python3 # Copyright (c) 2020 The Zcash developers # Distributed under the MIT software license, see the accompanying # file COPYING or https://www.opensource.org/licenses/mit-license.php . from test_framework.test_framework import BitcoinTestFramework from test_framework.util import ( LEGACY_DEFAULT_FEE, NU5_BRANCH_ID, assert_equal, assert_greater_than, assert_raises_message, connect_nodes_bi, get_coinbase_address, nuparams, start_nodes, wait_and_assert_operationid_status, ) from test_framework.authproxy import JSONRPCException from test_framework.mininode import COIN from decimal import Decimal # Test wallet address behaviour across network upgrades class WalletZSendmanyTest(BitcoinTestFramework): def __init__(self): super().__init__() self.cache_behavior = 'sprout' def setup_network(self, split=False): self.nodes = start_nodes(3, self.options.tmpdir, extra_args=[[ '-minrelaytxfee=0', nuparams(NU5_BRANCH_ID, 238), '-allowdeprecated=getnewaddress', '-allowdeprecated=z_getnewaddress', '-allowdeprecated=z_getbalance', '-allowdeprecated=z_gettotalbalance', ]] * self.num_nodes) connect_nodes_bi(self.nodes,0,1) connect_nodes_bi(self.nodes,1,2) connect_nodes_bi(self.nodes,0,2) self.is_network_split=False self.sync_all() # Check we only have balances in the expected pools. # Remember that empty pools are omitted from the output. def _check_balance_for_rpc(self, rpcmethod, node, account, expected, minconf): rpc = getattr(self.nodes[node], rpcmethod) actual = rpc(account, minconf) assert_equal(set(expected), set(actual['pools'])) total_balance = 0 for pool in expected: assert_equal(expected[pool] * COIN, actual['pools'][pool]['valueZat']) total_balance += expected[pool] assert_equal(actual['minimum_confirmations'], minconf) return total_balance def check_balance(self, node, account, address, expected, minconf=1): acct_balance = self._check_balance_for_rpc('z_getbalanceforaccount', node, account, expected, minconf) z_getbalance = self.nodes[node].z_getbalance(address, minconf) assert_equal(acct_balance, z_getbalance) fvk = self.nodes[node].z_exportviewingkey(address) self._check_balance_for_rpc('z_getbalanceforviewingkey', node, fvk, expected, minconf) def run_test(self): # z_sendmany is expected to fail if tx size breaks limit myzaddr = self.nodes[0].z_getnewaddress() recipients = [] num_t_recipients = 1000 num_z_recipients = 2100 amount_per_recipient = Decimal('0.00000001') errorString = '' for i in range(0,num_t_recipients): newtaddr = self.nodes[2].getnewaddress() recipients.append({"address":newtaddr, "amount":amount_per_recipient}) for i in range(0,num_z_recipients): newzaddr = self.nodes[2].z_getnewaddress() recipients.append({"address":newzaddr, "amount":amount_per_recipient}) # Issue #2759 Workaround START # HTTP connection to node 0 may fall into a state, during the few minutes it takes to process # loop above to create new addresses, that when z_sendmany is called with a large amount of # rpc data in recipients, the connection fails with a 'broken pipe' error. Making a RPC call # to node 0 before calling z_sendmany appears to fix this issue, perhaps putting the HTTP # connection into a good state to handle a large amount of data in recipients. self.nodes[0].getinfo() # Issue #2759 Workaround END try: self.nodes[0].z_sendmany(myzaddr, recipients) except JSONRPCException as e: errorString = e.error['message'] assert("size of raw transaction would be larger than limit" in errorString) # add zaddr to node 2 myzaddr = self.nodes[2].z_getnewaddress() # add taddr to node 2 mytaddr = self.nodes[2].getnewaddress() # send from node 0 to node 2 taddr mytxid = self.nodes[0].sendtoaddress(mytaddr, 10.0) self.sync_all() self.nodes[0].generate(10) self.sync_all() # send node 2 taddr to zaddr recipients = [] recipients.append({"address":myzaddr, "amount":7}) opid = self.nodes[2].z_sendmany(mytaddr, recipients, 1, LEGACY_DEFAULT_FEE, 'AllowFullyTransparent') mytxid = wait_and_assert_operationid_status(self.nodes[2], opid) self.sync_all() # check balances zsendmanynotevalue = Decimal('7.0') zsendmanyfee = LEGACY_DEFAULT_FEE node2sproutbalance = Decimal('50.00000000') node2utxobalance = Decimal('210.00000000') - zsendmanynotevalue - zsendmanyfee # check shielded balance status with getwalletinfo wallet_info = self.nodes[2].getwalletinfo() assert_equal(Decimal(wallet_info["shielded_unconfirmed_balance"]), zsendmanynotevalue) assert_equal(Decimal(wallet_info["shielded_balance"]), node2sproutbalance) self.nodes[2].generate(10) self.sync_all() assert_equal(self.nodes[2].getbalance(), node2utxobalance) assert_equal(self.nodes[2].getbalance("*"), node2utxobalance) # check zaddr balance with z_getbalance zbalance = zsendmanynotevalue assert_equal(self.nodes[2].z_getbalance(myzaddr), zbalance) # check via z_gettotalbalance resp = self.nodes[2].z_gettotalbalance() assert_equal(Decimal(resp["transparent"]), node2utxobalance) assert_equal(Decimal(resp["private"]), node2sproutbalance + zbalance) assert_equal(Decimal(resp["total"]), node2utxobalance + node2sproutbalance + zbalance) # check confirmed shielded balance with getwalletinfo wallet_info = self.nodes[2].getwalletinfo() assert_equal(Decimal(wallet_info["shielded_unconfirmed_balance"]), Decimal('0.0')) assert_equal(Decimal(wallet_info["shielded_balance"]), node2sproutbalance + zsendmanynotevalue) # there should be at least one Sapling output mytxdetails = self.nodes[2].getrawtransaction(mytxid, 1) assert_greater_than(len(mytxdetails["vShieldedOutput"]), 0) # the Sapling output should take in all the public value assert_equal(mytxdetails["valueBalance"], -zsendmanynotevalue) # send from private note to node 0 and node 2 node0balance = self.nodes[0].getbalance() # The following assertion fails nondeterministically # assert_equal(node0balance, Decimal('25.99798873')) node2balance = self.nodes[2].getbalance() # The following assertion might fail nondeterministically # assert_equal(node2balance, Decimal('16.99799000')) # try sending with a memo to a taddr, which should fail recipients = [{"address":self.nodes[0].getnewaddress(), "amount":1, "memo":"DEADBEEF"}] opid = self.nodes[2].z_sendmany(myzaddr, recipients, 1, LEGACY_DEFAULT_FEE, 'AllowRevealedRecipients') wait_and_assert_operationid_status(self.nodes[2], opid, 'failed', 'Failed to build transaction: Memos cannot be sent to transparent addresses.') recipients = [] recipients.append({"address":self.nodes[0].getnewaddress(), "amount":1}) recipients.append({"address":self.nodes[2].getnewaddress(), "amount":1.0}) opid = self.nodes[2].z_sendmany(myzaddr, recipients, 1, LEGACY_DEFAULT_FEE, 'AllowRevealedRecipients') wait_and_assert_operationid_status(self.nodes[2], opid) zbalance -= Decimal('2.0') + zsendmanyfee self.sync_all() self.nodes[2].generate(1) self.sync_all() node0balance += Decimal('11.0') node2balance += Decimal('1.0') assert_equal(Decimal(self.nodes[0].getbalance()), node0balance) assert_equal(Decimal(self.nodes[0].getbalance("*")), node0balance) assert_equal(Decimal(self.nodes[2].getbalance()), node2balance) assert_equal(Decimal(self.nodes[2].getbalance("*")), node2balance) # Get a new unified account on node 2 & generate a UA n0account0 = self.nodes[0].z_getnewaccount()['account'] n0ua0 = self.nodes[0].z_getaddressforaccount(n0account0)['address'] # Prepare to fund the UA from coinbase source = get_coinbase_address(self.nodes[2]) recipients = [] recipients.append({"address":n0ua0, "amount":10}) # If we attempt to spend with the default privacy policy, z_sendmany # fails because it needs to spend transparent coins in a transaction # involving a Unified Address. unified_address_msg = 'Could not send to a shielded receiver of a unified address without spending funds from a different pool, which would reveal transaction amounts. THIS MAY AFFECT YOUR PRIVACY. Resubmit with the `privacyPolicy` parameter set to `AllowRevealedAmounts` or weaker if you wish to allow this transaction to proceed anyway.' revealed_senders_msg = 'Insufficient funds: have 0.00, need 10.00; note that coinbase outputs will not be selected if you specify ANY_TADDR, any transparent recipients are included, or if the `privacyPolicy` parameter is not set to `AllowRevealedSenders` or weaker.' opid = self.nodes[2].z_sendmany(source, recipients, 1, 0) wait_and_assert_operationid_status(self.nodes[2], opid, 'failed', unified_address_msg) # We can't create a transaction with an unknown privacy policy. assert_raises_message( JSONRPCException, 'Unknown privacy policy name \'ZcashIsAwesome\'', self.nodes[2].z_sendmany, source, recipients, 1, 0, 'ZcashIsAwesome') # If we set any policy that does not include AllowRevealedSenders, # z_sendmany also fails. for (policy, msg) in [ ('FullPrivacy', unified_address_msg), ('AllowRevealedAmounts', revealed_senders_msg), ('AllowRevealedRecipients', revealed_senders_msg), ]: opid = self.nodes[2].z_sendmany(source, recipients, 1, 0, policy) wait_and_assert_operationid_status(self.nodes[2], opid, 'failed', msg) # By setting the correct policy, we can create the transaction. opid = self.nodes[2].z_sendmany(source, recipients, 1, 0, 'AllowRevealedSenders') wait_and_assert_operationid_status(self.nodes[2], opid) self.nodes[2].generate(1) self.sync_all() node2balance -= Decimal('10.0') node0balance += Decimal('10.0') assert_equal(Decimal(self.nodes[2].getbalance()), node2balance) assert_equal(Decimal(self.nodes[0].getbalance()), node0balance) self.check_balance(0, 0, n0ua0, {'sapling': 10}) # Send some funds to a specific legacy taddr that we can spend from recipients = [] recipients.append({"address":mytaddr, "amount":5}) # If we attempt to spend with the default privacy policy, z_sendmany # returns an error because it needs to create a transparent recipient in # a transaction involving a Unified Address. revealed_recipients_msg = "This transaction would have transparent recipients, which is not enabled by default because it will publicly reveal transaction recipients and amounts. THIS MAY AFFECT YOUR PRIVACY. Resubmit with the `privacyPolicy` parameter set to `AllowRevealedRecipients` or weaker if you wish to allow this transaction to proceed anyway." opid = self.nodes[0].z_sendmany(n0ua0, recipients, 1, 0) wait_and_assert_operationid_status(self.nodes[0], opid, 'failed', revealed_recipients_msg) # If we set any policy that does not include AllowRevealedRecipients, # z_sendmany also returns an error. for policy in [ 'FullPrivacy', 'AllowRevealedAmounts', 'AllowRevealedSenders', 'AllowLinkingAccountAddresses', ]: opid = self.nodes[0].z_sendmany(n0ua0, recipients, 1, 0, policy) wait_and_assert_operationid_status(self.nodes[0], opid, 'failed', revealed_recipients_msg) # By setting the correct policy, we can create the transaction. opid = self.nodes[0].z_sendmany(n0ua0, recipients, 1, 0, 'AllowRevealedRecipients') wait_and_assert_operationid_status(self.nodes[0], opid) self.nodes[0].generate(1) self.sync_all() node2balance += Decimal('5.0') self.check_balance(0, 0, n0ua0, {'sapling': 5}) assert_equal(Decimal(self.nodes[2].getbalance()), node2balance) # Send some funds to a legacy sapling address that we can spend from recipients = [] recipients.append({"address":myzaddr, "amount":3}) opid = self.nodes[0].z_sendmany(n0ua0, recipients, 1, 0) wait_and_assert_operationid_status(self.nodes[0], opid) self.nodes[0].generate(1) self.sync_all() zbalance += Decimal('3.0') self.check_balance(0, 0, n0ua0, {'sapling': 2}) assert_equal(Decimal(self.nodes[2].z_getbalance(myzaddr)), zbalance) # Send funds back from the legacy taddr to the UA. This requires # AllowRevealedSenders, but we can also use any weaker policy that # includes it. recipients = [] recipients.append({"address":n0ua0, "amount":4}) opid = self.nodes[2].z_sendmany(mytaddr, recipients, 1, 0, 'AllowFullyTransparent') wait_and_assert_operationid_status(self.nodes[2], opid) self.nodes[2].generate(1) self.sync_all() node2balance -= Decimal('4.0') self.check_balance(0, 0, n0ua0, {'sapling': 6}) assert_equal(Decimal(self.nodes[2].getbalance()), node2balance) # Send funds back from the legacy zaddr to the UA recipients = [] recipients.append({"address":n0ua0, "amount":2}) opid = self.nodes[2].z_sendmany(myzaddr, recipients, 1, 0) wait_and_assert_operationid_status(self.nodes[2], opid) self.nodes[2].generate(1) self.sync_all() zbalance -= Decimal('2.0') self.check_balance(0, 0, n0ua0, {'sapling': 8}) assert_equal(Decimal(self.nodes[2].z_getbalance(myzaddr)), zbalance) # # Test that z_sendmany avoids UA linkability unless we allow it. # # Generate a new account with two new addresses. n1account = self.nodes[1].z_getnewaccount()['account'] n1ua0 = self.nodes[1].z_getaddressforaccount(n1account)['address'] n1ua1 = self.nodes[1].z_getaddressforaccount(n1account)['address'] # Send funds to the transparent receivers of both addresses. for ua in [n1ua0, n1ua1]: taddr = self.nodes[1].z_listunifiedreceivers(ua)['p2pkh'] self.nodes[0].sendtoaddress(taddr, 2) self.sync_all() self.nodes[2].generate(1) self.sync_all() # The account should see all funds. assert_equal( self.nodes[1].z_getbalanceforaccount(n1account)['pools'], {'transparent': {'valueZat': 4 * COIN}}, ) # The addresses should see only the transparent funds sent to them. assert_equal(self.nodes[1].z_getbalance(n1ua0), 2) assert_equal(self.nodes[1].z_getbalance(n1ua1), 2) # If we try to send 3 ZEC from n1ua0, it will fail with too-few funds. recipients = [{"address":n0ua0, "amount":3}] linked_addrs_with_coinbase_note_msg = 'Insufficient funds: have 2.00, need 3.00; note that coinbase outputs will not be selected if you specify ANY_TADDR, any transparent recipients are included, or if the `privacyPolicy` parameter is not set to `AllowRevealedSenders` or weaker. (This transaction may require selecting transparent coins that were sent to multiple Unified Addresses, which is not enabled by default because it would create a public link between the transparent receivers of these addresses. THIS MAY AFFECT YOUR PRIVACY. Resubmit with the `privacyPolicy` parameter set to `AllowLinkingAccountAddresses` or weaker if you wish to allow this transaction to proceed anyway.)' linked_addrs_without_coinbase_note_msg = 'Insufficient funds: have 2.00, need 3.00. (This transaction may require selecting transparent coins that were sent to multiple Unified Addresses, which is not enabled by default because it would create a public link between the transparent receivers of these addresses. THIS MAY AFFECT YOUR PRIVACY. Resubmit with the `privacyPolicy` parameter set to `AllowLinkingAccountAddresses` or weaker if you wish to allow this transaction to proceed anyway.)' revealed_amounts_msg = 'Could not send to a shielded receiver of a unified address without spending funds from a different pool, which would reveal transaction amounts. THIS MAY AFFECT YOUR PRIVACY. Resubmit with the `privacyPolicy` parameter set to `AllowRevealedAmounts` or weaker if you wish to allow this transaction to proceed anyway.' opid = self.nodes[1].z_sendmany(n1ua0, recipients, 1, 0) wait_and_assert_operationid_status(self.nodes[1], opid, 'failed', revealed_amounts_msg) # If we try it again with any policy that is too strong, it also fails. for (policy, msg) in [ ('FullPrivacy', revealed_amounts_msg), ('AllowRevealedAmounts', linked_addrs_with_coinbase_note_msg), ('AllowRevealedRecipients', linked_addrs_with_coinbase_note_msg), ('AllowRevealedSenders', linked_addrs_without_coinbase_note_msg), ('AllowFullyTransparent', linked_addrs_without_coinbase_note_msg), ]: opid = self.nodes[1].z_sendmany(n1ua0, recipients, 1, 0, policy) wait_and_assert_operationid_status(self.nodes[1], opid, 'failed', msg) # If we try to send just a bit less than we have, it will fail, complaining about dust opid = self.nodes[1].z_sendmany(n1ua0, [{"address":n0ua0, "amount":3.9999999}], 1, 0, 'AllowLinkingAccountAddresses') wait_and_assert_operationid_status(self.nodes[1], opid, 'failed', 'Insufficient funds: have 4.00, need 0.00000044 more to avoid creating invalid change output 0.0000001 (dust threshold is 0.00000054).') # Once we provide a sufficiently-weak policy, the transaction succeeds. opid = self.nodes[1].z_sendmany(n1ua0, recipients, 1, 0, 'AllowLinkingAccountAddresses') wait_and_assert_operationid_status(self.nodes[1], opid) self.sync_all() self.nodes[2].generate(1) self.sync_all() # The account should see the remaining funds, and they should have been # sent to the Sapling change address (because NU5 is not active). assert_equal( self.nodes[1].z_getbalanceforaccount(n1account)['pools'], {'sapling': {'valueZat': 1 * COIN}}, ) # The addresses should both show the same balance, as they both show the # Sapling balance. assert_equal(self.nodes[1].z_getbalance(n1ua0), 1) assert_equal(self.nodes[1].z_getbalance(n1ua1), 1) # # Test Orchard-only UA before NU5 # n0orchard_only = self.nodes[0].z_getaddressforaccount(n0account0, ["orchard"])['address'] recipients = [{"address":n0orchard_only, "amount":1}] for (policy, msg) in [ ('FullPrivacy', 'Could not send to a shielded receiver of a unified address without spending funds from a different pool, which would reveal transaction amounts. THIS MAY AFFECT YOUR PRIVACY. Resubmit with the `privacyPolicy` parameter set to `AllowRevealedAmounts` or weaker if you wish to allow this transaction to proceed anyway.'), ('AllowRevealedAmounts', 'This transaction would send to a transparent receiver of a unified address, which is not enabled by default because it will publicly reveal transaction recipients and amounts. THIS MAY AFFECT YOUR PRIVACY. Resubmit with the `privacyPolicy` parameter set to `AllowRevealedRecipients` or weaker if you wish to allow this transaction to proceed anyway.'), ('AllowRevealedRecipients', 'Could not send to an Orchard-only receiver despite a lax privacy policy, because NU5 has not been activated yet.'), ]: opid = self.nodes[1].z_sendmany(n1ua0, recipients, 1, 0, policy) wait_and_assert_operationid_status(self.nodes[1], opid, 'failed', msg) # # Test NoPrivacy policy # # Send some legacy transparent funds to n1ua0, creating Sapling outputs. source = get_coinbase_address(self.nodes[2]) recipients = [{"address":n1ua0, "amount":10}] # This requires the AllowRevealedSenders policy, but we specify only AllowRevealedAmounts... opid = self.nodes[2].z_sendmany(source, recipients, 1, 0, 'AllowRevealedAmounts') wait_and_assert_operationid_status(self.nodes[2], opid, 'failed', revealed_senders_msg) # ... which we can always override with the NoPrivacy policy. opid = self.nodes[2].z_sendmany(source, recipients, 1, 0, 'NoPrivacy') wait_and_assert_operationid_status(self.nodes[2], opid) self.sync_all() self.nodes[2].generate(1) self.sync_all() # Send some funds from node 1's account to a transparent address. recipients = [{"address":mytaddr, "amount":5}] # This requires the AllowRevealedRecipients policy... opid = self.nodes[1].z_sendmany(n1ua0, recipients, 1, 0) wait_and_assert_operationid_status(self.nodes[1], opid, 'failed', revealed_recipients_msg) # ... which we can always override with the NoPrivacy policy. opid = self.nodes[1].z_sendmany(n1ua0, recipients, 1, 0, 'NoPrivacy') wait_and_assert_operationid_status(self.nodes[1], opid) # Activate NU5 self.sync_all() self.nodes[1].generate(10) self.sync_all() # # Test sending Sprout funds to Orchard-only UA # sproutAddr = self.nodes[2].listaddresses()[0]['sprout']['addresses'][0] recipients = [{"address":n0orchard_only, "amount":100}] for (policy, msg) in [ ('FullPrivacy', 'Could not send to a shielded receiver of a unified address without spending funds from a different pool, which would reveal transaction amounts. THIS MAY AFFECT YOUR PRIVACY. Resubmit with the `privacyPolicy` parameter set to `AllowRevealedAmounts` or weaker if you wish to allow this transaction to proceed anyway.'), ('AllowRevealedAmounts', 'This transaction would send to a transparent receiver of a unified address, which is not enabled by default because it will publicly reveal transaction recipients and amounts. THIS MAY AFFECT YOUR PRIVACY. Resubmit with the `privacyPolicy` parameter set to `AllowRevealedRecipients` or weaker if you wish to allow this transaction to proceed anyway.'), ('AllowRevealedRecipients', 'Could not send to an Orchard-only receiver despite a lax privacy policy, because you are sending from the Sprout pool and there is no transaction version that supports both Sprout and Orchard.'), ]: opid = self.nodes[2].z_sendmany(sproutAddr, recipients, 1, 0, policy) wait_and_assert_operationid_status(self.nodes[2], opid, 'failed', msg) # # Test AllowRevealedAmounts policy # assert_equal( {'pools': {'sapling': {'valueZat': 600000000}}, 'minimum_confirmations': 1}, self.nodes[1].z_getbalanceforaccount(n1account)) # Sending some funds to the Orchard pool in n0account0 ... n0ua1 = self.nodes[0].z_getaddressforaccount(n0account0, ["orchard"])['address'] recipients = [{"address":n0ua1, "amount": 6}] # Should fail under default and 'FullPrivacy' policies ... revealed_amounts_msg = 'Could not send to a shielded receiver of a unified address without spending funds from a different pool, which would reveal transaction amounts. THIS MAY AFFECT YOUR PRIVACY. Resubmit with the `privacyPolicy` parameter set to `AllowRevealedAmounts` or weaker if you wish to allow this transaction to proceed anyway.' opid = self.nodes[1].z_sendmany(n1ua0, recipients, 1, 0) wait_and_assert_operationid_status(self.nodes[1], opid, 'failed', revealed_amounts_msg) opid = self.nodes[1].z_sendmany(n1ua0, recipients, 1, 0, 'FullPrivacy') wait_and_assert_operationid_status(self.nodes[1], opid, 'failed', revealed_amounts_msg) # Should succeed under 'AllowRevealedAmounts' opid = self.nodes[1].z_sendmany(n1ua0, recipients, 1, 0, 'AllowRevealedAmounts') wait_and_assert_operationid_status(self.nodes[1], opid) self.sync_all() self.nodes[1].generate(1) self.sync_all() assert_equal( {'pools': {'sapling': {'valueZat': 1100000000}, 'orchard': {'valueZat': 600000000}}, 'minimum_confirmations': 1}, self.nodes[0].z_getbalanceforaccount(n0account0)) # A total that requires selecting from both pools should fail under default and # FullPrivacy policies... recipients = [{"address":n1ua0, "amount": 15}] opid = self.nodes[0].z_sendmany(n0ua0, recipients, 1, 0) wait_and_assert_operationid_status(self.nodes[0], opid, 'failed', revealed_amounts_msg) opid = self.nodes[0].z_sendmany(n0ua0, recipients, 1, 0, 'FullPrivacy') wait_and_assert_operationid_status(self.nodes[0], opid, 'failed', revealed_amounts_msg) # Should succeed under 'AllowRevealedAmounts' opid = self.nodes[0].z_sendmany(n0ua0, recipients, 1, 0, 'AllowRevealedAmounts') wait_and_assert_operationid_status(self.nodes[0], opid) self.sync_all() self.nodes[1].generate(1) self.sync_all() # All funds should be received to the Orchard pool assert_equal( {'pools': {'orchard': {'valueZat': 1500000000}}, 'minimum_confirmations': 1}, self.nodes[1].z_getbalanceforaccount(n1account)) # And all change should be optimistically shielded assert_equal( {'pools': {'orchard': {'valueZat': 200000000}}, 'minimum_confirmations': 1}, self.nodes[0].z_getbalanceforaccount(n0account0)) self.sync_all() self.nodes[1].generate(1) self.sync_all() # # Test transparent change # recipients = [{"address":n0ua1, "amount": 4}] # Should fail because this generates transparent change, but we don’t have # `AllowRevealedRecipients` opid = self.nodes[2].z_sendmany(mytaddr, recipients, 1, 0, 'AllowRevealedSenders') wait_and_assert_operationid_status(self.nodes[2], opid, 'failed', "This transaction would have transparent change, which is not enabled by default because it will publicly reveal the change address and amounts. THIS MAY AFFECT YOUR PRIVACY. Resubmit with the `privacyPolicy` parameter set to `AllowRevealedRecipients` or weaker if you wish to allow this transaction to proceed anyway.") # Should succeed once we include `AllowRevealedRecipients` opid = self.nodes[2].z_sendmany(mytaddr, recipients, 1, 0, 'AllowFullyTransparent') wait_and_assert_operationid_status(self.nodes[2], opid) if __name__ == '__main__': WalletZSendmanyTest().main()