zec
/
zips
mirror of https://github.com/zcash/zips.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

NCC audit: Correct the sizes of SpendDescriptionV5 and OutputDescriptionV5 in the version transaction format. 

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
This commit is contained in:
Daira Hopwood 2021-03-26 16:30:40 +00:00
parent bfc6a8e33c
commit 5fef9270e2
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
protocol/protocol.tex
View File

@ -11960,13 +11960,13 @@ A \blockHeight in the range $\range{1}{499999999}$ after which the \transaction
& \Varies & $\nSpendsSapling$ & \type{compactSize} & & \Varies & $\nSpendsSapling$ & \type{compactSize} &
The number of \spendDescriptions in $\vSpendsSapling$.\! \\ \hline The number of \spendDescriptions in $\vSpendsSapling$.\! \\ \hline
& \Longunderstack{$362 \mult$ \\$\!\nSpendsSapling\!$} & $\vSpendsSapling$ & \type{SpendDescriptionV5} \type{[$\nSpendsSapling$]} & & \Longunderstack{$96 \mult$ \\$\!\nSpendsSapling\!$} & $\vSpendsSapling$ & \type{SpendDescriptionV5} \type{[$\nSpendsSapling$]} &
A sequence of \spendDescriptions{}, encoded per \crossref{spendencodingandconsensus}.\! \\ \hline A sequence of \spendDescriptions{}, encoded per \crossref{spendencodingandconsensus}.\! \\ \hline
& \Varies & $\nOutputsSapling\!$ & \type{compactSize} & & \Varies & $\nOutputsSapling\!$ & \type{compactSize} &
The number of \outputDescriptions in $\vOutputsSapling$.\! \\ \hline The number of \outputDescriptions in $\vOutputsSapling$.\! \\ \hline
& \Longunderstack{$948 \mult$ \\$\!\nOutputsSapling\!$} & $\vOutputsSapling\!$ & \type{OutputDescriptionV5} \type{[$\nOutputsSapling$]} & & \Longunderstack{$756 \mult$ \\$\!\nOutputsSapling\!$} & $\vOutputsSapling\!$ & \type{OutputDescriptionV5} \type{[$\nOutputsSapling$]} &
A sequence of \outputDescriptions{}, encoded per \crossref{outputencodingandconsensus}.\! \\ \hline A sequence of \outputDescriptions{}, encoded per \crossref{outputencodingandconsensus}.\! \\ \hline
$\ddagger$ & $8$ & $\valueBalance{Sapling}\!$ & \type{int64} & $\ddagger$ & $8$ & $\valueBalance{Sapling}\!$ & \type{int64} &
@ -13982,6 +13982,8 @@ Peter Newell's illustration of the Jubjub bird, from \cite{Carroll1902}.
output of $\maptocurvesimpleswuIsoG$. output of $\maptocurvesimpleswuIsoG$.
\item Document the limitation on the domain separation string for the \groupHash \item Document the limitation on the domain separation string for the \groupHash
into \Pallas and \Vesta. into \Pallas and \Vesta.
\item Correct the sizes of \type{SpendDescriptionV5} and \type{OutputDescriptionV5}
in the version 5 \transaction format.
\item Make the naming of $\enableSpends$ and $\enableOutputs$ consistent. \item Make the naming of $\enableSpends$ and $\enableOutputs$ consistent.
\end{itemize} \end{itemize}
\item Correct the description of $\lengthField$ in \crossref{unifiedpaymentaddrencoding}. \item Correct the description of $\lengthField$ in \crossref{unifiedpaymentaddrencoding}.

2
zip-0225.rst
View File

@ -106,7 +106,7 @@ Transaction Format
+-----------------------------+--------------------------+----------------------------------------+---------------------------------------------------------------------+ +-----------------------------+--------------------------+----------------------------------------+---------------------------------------------------------------------+
|``varies`` |``nSpendsSapling`` |``compactSize`` |Number of Sapling Spend descriptions in ``vSpendsSapling``. | |``varies`` |``nSpendsSapling`` |``compactSize`` |Number of Sapling Spend descriptions in ``vSpendsSapling``. |
+-----------------------------+--------------------------+----------------------------------------+---------------------------------------------------------------------+ +-----------------------------+--------------------------+----------------------------------------+---------------------------------------------------------------------+
|``128 * nSpendsSapling`` |``vSpendsSapling`` |``SpendDescriptionV5[nSpendsSapling]`` |A sequence of Sapling Spend descriptions, encoded per | |``96 * nSpendsSapling`` |``vSpendsSapling`` |``SpendDescriptionV5[nSpendsSapling]`` |A sequence of Sapling Spend descriptions, encoded per |
| | | |protocol §7.3 ‘Spend Description Encoding and Consensus’. | | | | |protocol §7.3 ‘Spend Description Encoding and Consensus’. |
+-----------------------------+--------------------------+----------------------------------------+---------------------------------------------------------------------+ +-----------------------------+--------------------------+----------------------------------------+---------------------------------------------------------------------+
|``varies`` |``nOutputsSapling`` |``compactSize`` |Number of Sapling Output Decriptions in ``vOutputsSapling``. | |``varies`` |``nOutputsSapling`` |``compactSize`` |Number of Sapling Output Decriptions in ``vOutputsSapling``. |