From cdb7144519eaab229e0b37c0151776451a697e26 Mon Sep 17 00:00:00 2001 From: Kris Nuttycombe Date: Tue, 9 Feb 2021 08:06:00 -0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Daira Hopwood --- zip-0244.rst | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/zip-0244.rst b/zip-0244.rst index 9782f363..e8d7674a 100644 --- a/zip-0244.rst +++ b/zip-0244.rst @@ -279,8 +279,8 @@ The personalization field of this hash is set to:: T.4a.ii: sapling_spends_noncompact_digest ......................................... A BLAKE2b-256 hash of the non-nullifier information for all Sapling shielded spends -belonging to the transaction, excluding zkproof data and spend authorization -signature. For each spend, the following elements are included in the hash:: +belonging to the transaction, excluding both zkproof data and spend authorization +signature(s). For each spend, the following elements are included in the hash:: T.4a.ii.1: cv (field encoding bytes) T.4a.ii.2: anchor (field encoding bytes) @@ -547,22 +547,22 @@ A BLAKE2b-256 hash of the field encoding of the Sapling ``zkproof`` and ``spend_auth_sig`` values of each Sapling spend description belonging to the transaction, followed by the field encoding of the ``zkproof`` field of each Sapling output belonging to the transaction, -followed by the field encoding of the binding signature :: +followed by the field encoding of the binding signature:: - A.3a: spend_zkproofs_sigs (see subsection A.3a) - A.3b: output_zkproofs (field encoding bytes) - A.3c: binding_sig (field encoding bytes) + A.3a: spend_zkproofs_and_sigs (see subsection A.3a) + A.3b: output_zkproofs (field encoding bytes) + A.3c: binding_sig (field encoding bytes) The personalization field of this hash is set to:: "ZTxAuthSapliHash" -A.3a: spend_zkproofs_sigs -''''''''''''''''''''''''' +A.3a: spend_zkproofs_and_sigs +''''''''''''''''''''''''''''' For each ``SpendDescription`` belonging to the transaction, the following elements are added to the ``A.3`` hash:: - A.3a.i: zkproof ([u8; 192]) + A.3a.i: zkproof (field encoding bytes) A.3a.ii: spend_auth_sig (field encoding bytes)