Commit Graph

2618 Commits

Author SHA1 Message Date
Daira Hopwood 6c8f9fb478 Update the Sprout key component diagram in \crossref{addressesandkeys} to remove magenta highlighting.Remove magenta highlighting
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood e1f105eaa1 Add note about use of big-endian order in the encoding of BLS12-381 points.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 3a55af9b1f Cosmetics and indexing.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 7bfdce2d6a Write caution about linkage between the abstract and concrete protocols in \crossref{cautionlinkage}.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood 1097313feb Fix errors in the Sinsemilla proofs:
* SinsemillaHash is defined in terms of SinsemillaHashToPoint, which also takes the D argument.
* correct errors due to 1-based indexing.
* the argument for exceptional cases got the scalars and range of j wrong.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood cce172ace8 Cosmetics (page breaking).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
Daira Hopwood f45b6b5d66 Add Action Statement ref to flags note
This change makes it clearer that the note spend and creation
rules are implemented as part of the proof.

Co-authored-by: teor <teor@riseup.net>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 02:11:35 +01:00
teor ecb2ccd3f4 Copy outCiphertext description to the encoding tables 2021-04-01 02:11:35 +01:00
Daira Hopwood 0eca13f809
Merge pull request #479 from nuttycom/zip_225-sapling_anchors
Remove anchorSapling field when there are no spends.
2021-04-01 00:59:47 +01:00
Daira Hopwood 89596379ff ZIP 225: Cosmetics (trailing spaces).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 00:58:37 +01:00
Kris Nuttycombe e0b08fd576 ZIP 225: Remove anchorSapling field when there are no spends.
Co-authored-by: Kris Nuttycombe <kris@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 00:58:23 +01:00
Daira Hopwood 1bed047c0e ZIP 221: cosmetics.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-31 13:40:26 +01:00
Daira Hopwood c9f9d0b36b ZIP 221: fix rst formatting.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-31 13:37:49 +01:00
Daira Hopwood 31e8b03491 ZIP 244: update link to protocol spec.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-30 20:19:33 +01:00
Daira Hopwood b0c65971d7
Merge pull request #467 from nuttycom/zip_225-ncc_fixes
Fixes for ZIP 225 issues identified by the NCC audit.
2021-03-30 20:10:43 +01:00
Kris Nuttycombe 0dd2982ec3 Update generated HTML. 2021-03-30 11:13:28 -06:00
Kris Nuttycombe 6ecba03a2a Fix vSpendAuthSigsOrchard field name. 2021-03-30 10:57:24 -06:00
Kris Nuttycombe f7461d62e5
Apply suggestions from code review
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-03-30 10:45:49 -06:00
Kris Nuttycombe e936a21a6b
Apply suggestions from code review
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-03-30 09:40:13 -06:00
Kris Nuttycombe 02fd26fc1f Make ordering of Orchard txid hash fields consistent with field order.
Also fixes a few conflicting/incorrect digest references and
removes some spurious duplication.

Co-authored by: Daira Hopwood <daira@jacaranda.org>
2021-03-30 08:28:09 -06:00
Daira Hopwood 64484cb945
Merge pull request #477 from daira/nu5-update-zip221
ZIP 221 and 252 updates for NU5
2021-03-30 14:59:42 +01:00
Deirdre Connolly 0d67dcf681 Update zip-0221.rst
Co-authored-by: Deidre Connolly <deirde@zfnd.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-30 14:58:30 +01:00
Daira Hopwood 5c6ab07f15 ZIP 252: mention amended ZIP 221, and the halo2 book.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-29 23:19:55 +01:00
Daira Hopwood 37479f7a11 ZIP 221: NU5 updates.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-29 23:19:13 +01:00
Daira Hopwood b16cf169e4 ZIP 221: renamed fields.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-29 23:18:45 +01:00
Daira Hopwood 306c575b87 ZIP 244: regenerate HTML.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-29 16:52:29 +01:00
Daira Hopwood 17818f0b32
Merge pull request #474 from teor2345/patch-8
[ZIP 244]: Be explicit about immediate hashBlockCommitments activation
2021-03-29 16:51:55 +01:00
teor 96efd54702
Be explicit about hashBlockCommitments activation 2021-03-29 14:14:12 +10:00
Kris Nuttycombe 4b2af700ef Add non-requirement for non-malleable transaction IDs for v4 transactions. 2021-03-26 16:37:30 -06:00
Kris Nuttycombe f202b83a9d Remove Sprout commitments from ZIP 244; include flagsOrchard in txid. 2021-03-26 16:37:30 -06:00
Kris Nuttycombe e4bc6ad354 Fixes for ZIP 225 issues identified by the NCC audit. 2021-03-26 16:37:29 -06:00
Daira Hopwood b0180c76f8 ZIP 216: fix section numbers.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 20:03:19 +00:00
Daira Hopwood d713d35f54 ZIP 216: fix references to the NU5 protocol spec.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 20:00:44 +00:00
Daira Hopwood 0f427feb5b Regenerate PDFs. 2021-03-26 19:45:47 +00:00
Daira Hopwood f66887cdee Fix an off-by-one error.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 19:40:57 +00:00
Daira Hopwood 3898e2f571 Regenerate PDFs. 2021-03-26 19:38:49 +00:00
Daira Hopwood b4aac633f4 Cosmetics.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 19:31:45 +00:00
Daira Hopwood 17a6a72974 Merge branch 'orchard-wip'
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 19:27:21 +00:00
Daira Hopwood 2f246ce24d Other fixes to the Orchard specification, including generation of dummy notes and output notes.
fixes #465

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 19:17:33 +00:00
Daira Hopwood aa86282e16 Change the specifications of note decryption to return the note and memo, rather than a note plaintext.
Generalize the specification of block chain scanning to support Orchard.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 18:23:58 +00:00
Daira Hopwood c50bdbd9ce Delete a confusing part of the definition of concatbits that we don't rely on.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 18:23:58 +00:00
Daira Hopwood b27213dfd3 Move the definition of ⊥ to before its first use.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 18:23:58 +00:00
Daira Hopwood cd1b4de8f9 Update the hashFinalSaplingRoot/hashLightClientRoot/hashBlockCommitments field for NU5.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 18:23:58 +00:00
Daira Hopwood 74dfa80194 Fix errors in Orchard due to cut-and-paste from Sapling.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 18:23:58 +00:00
Daira Hopwood 4d3204b8e1 Describe the recommended way to encode a Sapling or unified payment address as a QR code.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 18:23:58 +00:00
Daira Hopwood bbc6131f29 Update specification of Poseidon.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 18:23:58 +00:00
Daira Hopwood 212fdc8752 Add references for the halo2 book.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 18:23:57 +00:00
Daira Hopwood 5e55821889 NCC audit: Make the description of when fields are included in v5 transactions consistent
between the protocol specification and ZIP 225. Also regenerate the HTML for ZIP 225.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 18:23:57 +00:00
Daira Hopwood 55af963e53 NCC audit: Add a definition for the section symbol in \crossref{introduction}, before its first use.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 18:23:57 +00:00
Daira Hopwood eff39611f8 ZIP 225: Correct the size of the outCiphertext field in a Sapling Output description.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 18:23:57 +00:00