Commit Graph

99 Commits

Author SHA1 Message Date
GoodDaisy fdd8a6fb60 ZIP 32: fix typos 2024-01-07 15:30:21 +08:00
Daira Emma Hopwood 52a7763e4b ZIP 32: fix a type error in the derivation of dk_i. (The intent was clear.)
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-12-19 17:43:09 +00:00
Daira Emma Hopwood 2eb0ed8ef0 Updates to reference BCP 14 rather than RFC 2119. fixes #729
Also change two "should"s in ZIP 224 to "SHOULD"s.

Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-10-28 15:34:22 +01:00
Andrew Arnott af2f3aece4
Fix reference to undefined LEBS2OS function
The `LEBS2OS` function does not exist and isn't meant to. This reference is understood to have meant `LEBS2OSP`.

See discussion at:
https://forum.zcashcommunity.com/t/what-is-the-lebs2os-function-in-the-zip-32-spec/44886
2023-07-31 07:16:58 -06:00
Daira Emma Hopwood 8ea921667d Daira Hopwood -> Daira Emma Hopwood.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-03-02 12:13:07 +00:00
Daira Hopwood d9ab7909ec ZIP 32: Point out that Sapling and Orchard keys can be invalid.
fixes #561

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-04-28 16:38:15 +01:00
Daira Hopwood fb223c206d ZIP 32: Expose DeriveInternalFVK^Orchard for use by the protocol spec.
refs #598

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-04-28 16:38:15 +01:00
Daira Hopwood 8e2215c577 ZIP 32: Fix an error in #588; "ZcashIP32_Sprout" was a personalization for BLAKE2b-512, not BLAKE2b-256.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-01-28 18:33:31 +00:00
Daira Hopwood 7bd2845dbd ZIP 32: Remove Sprout-related specifications. fixes #581
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-01-28 17:44:15 +00:00
Daira Hopwood df0f9e6bee ZIP 32: Wording improvements to avoid implying that we want an internal address/FVK for every
external address/FVK.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-01-19 19:09:56 +00:00
Daira Hopwood ca302f40ef ZIPs 32 and 316: update and correct protocol spec references.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-01-19 19:00:52 +00:00
Daira Hopwood 2b5c860df5 ZIP 32: Add Sean Bowe, Kris Nuttycom and Ying Tong Lai to Credits.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-01-19 19:00:52 +00:00
Daira Hopwood 61223ae9b0 ZIP 32: Simplify Orchard internal key derivation diagram.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-01-19 19:00:51 +00:00
Daira Hopwood 79e6a10f0a ZIP 32: add internal key derivation for Sapling and Orchard.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-01-19 19:00:51 +00:00
Daira Hopwood 98515d003f ZIP 32: cosmetics.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-01-19 19:00:51 +00:00
Daira Hopwood d2b0f2d861 ZIP 32: disambiguate ToScalar and DiversifyHash for Sapling vs Orchard.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-01-19 19:00:51 +00:00
Deirdre Connolly 682308e33b ZIP 32: There will not be a zcashd 4.5.2, there will be 4.6.0. 2021-12-08 21:24:55 +00:00
Daira Hopwood 0db40ef927 ZIP 32: Note that legacy Sapling addresses use hardened derivation for `address_index`. 2021-12-08 21:24:51 +00:00
Jack Grigg 78b7d8489f ZIP 32: Revert all refinements
The hardened change path approach is being dropped. ZIP 316 will include
separate amendments (to be made later) that derive change addresses
within each protocol's key tree, instead of at the spend authorization
level.
2021-12-08 00:27:08 +00:00
Daira Hopwood dfdb4242f5 ZIP 32: Change the address index used to derive "legacy" Sapling addresses to 0x7FFFFFFF.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-08 00:27:08 +00:00
Daira Hopwood 4d0477ce5f ZIPs 32 and 316: refine how UIVK components are derived for Orchard and Transparent P2PKH.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-08 00:27:08 +00:00
Daira Hopwood 4d536ff421 ZIP 32: Add a note saying how zcashd uses a non-hardened `address_index` path level for Sapling.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-08 00:27:08 +00:00
Daira Hopwood 9dbe0a50f7 ZIP 32: minor wording changes.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-12-08 00:27:08 +00:00
Daira Hopwood 5ced374bf1 Update references to protocol spec from process and consensus ZIPs (0 to 252 inclusive, and 1014).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-10-02 00:46:17 +01:00
Daira Hopwood 21d3c13d4f Update references to the protocol spec for all NU5-related ZIPs.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-23 22:33:56 +01:00
Daira Hopwood 45e175512e ZIP 32: fix a type error in dk derivation for Orchard.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-03 22:48:38 +00:00
Daira Hopwood e40bb506ab ZIP 32 editorial updates.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-02 22:20:42 +00:00
Daira Hopwood e79401a10c Apply suggestions from ZIP review
Co-authored-by: Deirdre Connolly <deirdre@zfnd.org>
2021-03-02 22:20:42 +00:00
Jack Grigg dd8b82f567 ZIP 32: Address Orchard review comments 2021-03-02 22:20:42 +00:00
Jack Grigg 95ea11de9d ZIP 32: Clarify the diversifier key capabilities of an Orchard fvk 2021-03-02 22:20:42 +00:00
Jack Grigg f2eb24ae6e ZIP 32: Specify Orchard key derivation 2021-03-02 22:20:42 +00:00
Daira Hopwood 947f0b6649 Regularize ZIP categories.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-11-14 22:17:27 +00:00
Daira Hopwood c762d1ca67 Regularize references, especially to RFCs and the Protocol Spec.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-11-09 15:59:51 +00:00
Daira Hopwood fb84bd8084 Ensure that URLs enclosed in <> in header fields are linked.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-09-14 14:12:49 +01:00
Daira Hopwood 408a0a744c ZIP 32: fix an off-by-one error pointed out by @bigbrain.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-07-31 17:27:27 +01:00
Daira Hopwood 9a6aa31d93 ZIP 32: correction for seeds longer than 32 bytes. refs https://github.com/zcash/zcash/issues/4641
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-07-29 20:07:07 +01:00
Daira Hopwood 60db5fe85d ZIP 32: fixes https://github.com/zcash/zcash/issues/4641
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-07-29 19:33:49 +01:00
Daira Hopwood a3f0295cb6 ZIP 32: formatting.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-05-01 10:16:18 +01:00
Daira Hopwood 69ef14ce8a ZIP 32: add more line break opportunities in math.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-04-22 14:37:07 +01:00
Daira Hopwood 6c6843154d ZIP 32: use :math: markup for better rendering.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-04-22 11:41:16 +01:00
Daira Hopwood 09b3f6955c Link to https://www.rfc-editor.org/rfc/rfcXXXX.html for RFCs.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-02-29 16:00:39 +00:00
Daira Hopwood feca6f4b26 ZIP 31: child ask_i and nsk_i keys are intended to be taken modulo r_J.
Technically the ZIP was already correct because I_{ask}, I_{nsk}, ask_{par}, and nsk_{par} are all F_{r_J} elements,
but that assumes a lot of familiarity with the spec notation.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-01-21 13:32:30 +00:00
Daira Hopwood 41ec7e7820 Remove email addresses from Credits fields.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-01-01 16:28:27 +00:00
Daira Hopwood 8827ef0815 ZIP 32: update spec references.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-11-10 16:47:16 +00:00
Daira Hopwood 65af4c7de4 Fix rst warnings.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-08-06 13:58:09 +01:00
Daira Hopwood 3ccf1c37d1 Various ZIPs: clean up header metadata.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-08-01 09:18:23 +01:00
Daira Hopwood 4a9eb35910 ZIP 32: fill in links to reference implementation.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-02-22 22:54:16 +00:00
Jack Grigg 975a2aaa64
Formatting 2018-09-20 11:05:25 +01:00
Ariel cb1e663836
Improve explanation of diversifier sequence choice 2018-09-20 12:11:13 +03:00
Jack Grigg 888681c0b0
Update references to Sapling protocol spec 2018-09-18 11:42:29 +01:00