Commit Graph

3259 Commits

Author SHA1 Message Date
Daira Emma Hopwood eccfc4cc80
Merge pull request #716 from daira/zip-0-updates-2
[ZIP 0] Add Aditya Bharadwaj as a ZIP Editor; further clarifications and process updates
2023-09-29 15:11:23 +01:00
Daira Emma Hopwood 01190867fd Revert a change as discussed in the 2023-09-27 ZIP Editors' meeting,
and add a bugfix.

Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-29 15:06:57 +01:00
Daira Emma Hopwood e956ae7715 ZIP 313: Obsoleted by ZIP 317.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-27 22:03:31 +01:00
Daira Emma Hopwood c1881dfa27 Add support for notes and warnings.
There is currently a bug that will cause them to be rendered incorrectly
if they have only one paragraph, but that doesn't matter for the usage
in this PR.

Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-27 22:03:10 +01:00
Daira Emma Hopwood bbd44929bd ZIP 0: Regenerate HTML.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-15 18:16:28 +01:00
Daira Emma Hopwood f8b491ee50 ZIP 0: Add paragraph on public transparency about influence or constraints.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-15 18:16:13 +01:00
Daira Emma Hopwood 10bc5c8fa5 ZIP 0: Add Aditya Bharadwaj as a ZIP Editor.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-15 18:16:13 +01:00
Daira Emma Hopwood 0c8acb147d ZIP 0 clarifications:
* Remove redundancy between the list of reasons to reject an update and
  the "Specification of Status Workflow" section, and move things to the
  right section.
* Define "Released".
* Remove use of "proposed" (which was not intended to be the same as the
  status "Proposed").
* Add another reason to reject an update: it violates a conformance
  requirement of any Active Process ZIP (including this ZIP);
* Clarify that ZIP stubs, and only ZIP stubs, MUST use Status: Reserved;
* Clarify when a Released ZIP can be changed to a non-Released status;
* Require that changes in status other than Draft <-> Withdrawn in
  general need consensus among ZIP Editors, and eliminate resulting
  redundancies. This is technically a strengthened requirement for
  changes other than to Proposed or Rejected, but reflects existing
  practice.
* Clarify how the Owners of a ZIP change it to Withdrawn.
* Active can now only be reached from Proposed. Strengthen the
  requirements for rough consensus in this case to say that the ZIP
  has been complete for at least a month and Proposed for at least
  a week. This will impose a bit more overhead but I think it's
  necessary; previously, a Process or Informational ZIP could have
  gone directly from Draft to Active without sufficient notice.
* Require that a Consensus ZIP has an implementation merged into at
  least one consensus node codebase (currently zcashd and/or zebra)
  before it is moved to Implemented, and make the existing discussion
  of timing relative to a network upgrade apply only to Consensus ZIPs;
* Require that if a non-editorial update is made to an Obsolete or
  Withdrawn ZIP, its status MUST be changed appropriately.
* Allow a status transition from Implemented to Obsolete, and clarify
  when transitions to Obsolete occur.
* Add a responsibility for the ZIP Secretary to share significant
  changes in ZIP status, in particular progression of a ZIP to Proposed,
  on the Community Forum.

Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-15 18:16:13 +01:00
Daira Emma Hopwood e9469a3d61 ZIP 0: Formatting and typos.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-14 15:07:31 +01:00
Daira Emma Hopwood c608694157 ZIP 0: Add MUST NOT to defined keywords.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-13 22:27:23 -04:00
Daira Emma Hopwood 8a88f2a9e0 ZIP 0: Regenerate HTML.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-13 22:27:23 -04:00
Daira Emma Hopwood 85618ae84b ZIP 0: Repair rST errors.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-13 22:27:23 -04:00
Daira Emma Hopwood 7fa203425d ZIP 0: Consistent spelling of Obsoleted-By and Updated-By optional headers.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-13 22:27:23 -04:00
Daira Emma Hopwood f11228f543 ZIP 0: Remove redundant paragraphs and improve conformance language.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-13 22:27:23 -04:00
Daira Emma Hopwood 1a3d905c8c Apply suggestions from review 2023-09-13 22:27:23 -04:00
teor 3884fcd0b5 Apply changes to responsibilities section
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-13 22:27:23 -04:00
teor 43398a862f Apply changes to status section
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-13 22:27:23 -04:00
teor 790c25aae2 Apply changes to rejection and meeting sections
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-13 22:27:23 -04:00
teor b78ee9ae5c Apply changes to review section
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-13 22:27:23 -04:00
teor 37ae36a405 Apply changes to responsibilities section
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-13 22:27:23 -04:00
teor 5563f7cce0 Apply changes to ZIP editors section
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-09-13 22:27:23 -04:00
teor 37a8a3b081 Revise zip-0000.rst for new ZIP editors and processes 2023-09-13 22:27:23 -04:00
Deirdre Connolly af1c8e3cca Update zip-0000.rst 2023-09-13 22:27:23 -04:00
Deirdre Connolly 587afd463d Support more than 2 ZIP editors 2023-09-13 22:27:23 -04:00
dependabot[bot] 497bcc13b1 Bump actions/checkout from 3.5.3 to 3.6.0
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.3 to 3.6.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3.5.3...v3.6.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-08-30 17:47:46 -04:00
Daira Emma Hopwood 9b29341503
Merge pull request #702 from AArnott/fixErrors
Fix errors in protocol and ZIPs
2023-08-25 19:29:27 +01:00
Daira Emma Hopwood 02b7ce4c8a ZIPs 32, 316, and 321: regenerate HTML.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-08-25 19:27:33 +01:00
Daira Emma Hopwood 932b81d59d
dk is already a byte sequence. 2023-08-22 20:30:42 +01:00
Andrew Arnott 236336ad2f
Remove stray " character from ZIP-321 2023-08-17 07:45:36 -06:00
Andrew Arnott 61654491ce
Fix ZIP-316 bug in expected `dk` length
The `dk` value is 256 bits long. It's the *diversifier* that is only 88 bits long. The incoming viewing key requires the diversifier key -- not the diversifier.

This change also reflects the de facto standard in implementations up to this point, including YWallet and the [zcash_address crate](https://docs.rs/zcash_address/latest/src/zcash_address/kind/unified/ivk.rs.html).
2023-07-31 07:21:04 -06:00
Andrew Arnott af2f3aece4
Fix reference to undefined LEBS2OS function
The `LEBS2OS` function does not exist and isn't meant to. This reference is understood to have meant `LEBS2OSP`.

See discussion at:
https://forum.zcashcommunity.com/t/what-is-the-lebs2os-function-in-the-zip-32-spec/44886
2023-07-31 07:16:58 -06:00
Andrew Arnott 4ebc0f7629
Fix identification of HRP for full viewing keys
This was likely a copy-paste error with the section above it, which is very similar but presents the human-readable part of *incoming* viewing keys.
2023-07-31 07:13:11 -06:00
Daira Emma Hopwood c7a50bfd1b
Merge pull request #701 from str4d/700-collapsible-inline-rationale
Make inline Rationale sections collapsible
2023-07-21 20:39:49 +01:00
Jack Grigg 370b40e8f4 Update ZIP 0 to mention inline Rationale subsections 2023-07-20 16:54:48 +01:00
Jack Grigg 2fd1866298 Make existing inline rationale sections collapsible 2023-07-20 16:41:26 +01:00
dependabot[bot] ee79f0694d Bump actions/checkout from 3.5.2 to 3.5.3
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.2 to 3.5.3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3.5.2...v3.5.3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-07-13 18:52:54 -04:00
Daira Hopwood 0464b4893f
Merge pull request #695 from daira/zip-317-txunpaidactionlimit
ZIP 317: describe deployments and move status to Active
2023-05-25 14:57:23 +00:00
Daira Emma Hopwood 5659650da3 ZIP 317: describe deployments and move status to Active.
Also update the Endorsements section.

Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-05-25 15:16:14 +01:00
Daira Hopwood b00a20c949
Merge pull request #690 from zcash/sellout-zip-339
Correct issue link for ZIP 339
2023-05-10 21:09:00 +00:00
Daira Emma Hopwood 45ebfe1e1d ZIP 339: regenerate HTML.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-05-10 22:08:16 +01:00
dependabot[bot] 552b675999 Bump EndBug/add-and-commit from 9.1.1 to 9.1.3
Bumps [EndBug/add-and-commit](https://github.com/EndBug/add-and-commit) from 9.1.1 to 9.1.3.
- [Release notes](https://github.com/EndBug/add-and-commit/releases)
- [Commits](https://github.com/EndBug/add-and-commit/compare/v9.1.1...v9.1.3)

---
updated-dependencies:
- dependency-name: EndBug/add-and-commit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-05-10 17:06:41 -04:00
Greg Pfeil fa915b2a58
Correct issue link for ZIP 339 2023-05-07 01:33:28 -06:00
Daira Hopwood 8dba2077ce
Merge pull request #685 from daira/zip401-update-constants
ZIP 401: Allow an approximation of memory size, and update constants to avoid penalizing Orchard
2023-05-03 21:10:53 +00:00
Daira Emma Hopwood 3783355612 ZIP 401: regenerate HTML.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-05-03 22:09:26 +01:00
Deirdre Connolly 478f9f59f7 ZIP 401: include actual `zcashd` and `zebrad` versions that merged changes.
Co-authored-by: teor <teor@riseup.net>
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-05-03 22:09:06 +01:00
dependabot[bot] 18fce3b4a7 Bump actions/checkout from 3.5.1 to 3.5.2
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.1 to 3.5.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3.5.1...v3.5.2)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-04-18 08:36:24 -04:00
Daira Emma Hopwood 6e817f002d ZIP 401: updates to constants, rationale, and deployment.
* Update minimum cost threshold to 10000, and low_fee_penalty to 40000.
* Update references to "standard fee" in the Rationale section to take
  account of ZIP 317.
* Update the history of deployment and reference PRs.

fixes #565

Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-04-16 19:30:09 +01:00
Daira Emma Hopwood 6b074e1626 ZIP 401: allow implementations to use a different approximation of the
memory size of a transaction than its serialized size.

fixes #673

Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-04-16 19:11:23 +01:00
Daira Emma Hopwood aca1158f4e ZIP 401: the original deployment was in zcashd v2.1.0-1, not v2.1.0.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-04-16 18:55:53 +01:00
Daira Emma Hopwood 5356c6be47 ZIP 401: formatting of "zcashd" (cosmetic).
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-04-16 18:54:59 +01:00