Commit Graph

41 Commits

Author SHA1 Message Date
Daira-Emma Hopwood ba3b2697bb Daira [Emma] -> Daira-Emma. Also correct some author lists and prevent line-breaking of given names or surnames in the spec.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-04-14 17:42:34 +01:00
Daira Emma Hopwood 2eb0ed8ef0 Updates to reference BCP 14 rather than RFC 2119. fixes #729
Also change two "should"s in ZIP 224 to "SHOULD"s.

Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-10-28 15:34:22 +01:00
Daira Emma Hopwood 8ea921667d Daira Hopwood -> Daira Emma Hopwood.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-03-02 12:13:07 +00:00
Daira Hopwood 54359a8809 Update the status of all NU5 ZIPs to Final.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-06-22 22:21:35 +01:00
Jack Grigg a0767f42fe Add value of sizeProofsOrchard to protocol spec §7.1 and ZIP 225 2022-06-06 10:17:33 -04:00
Daira Hopwood 52abb0c609 ZIP 225: add links to zcashd and librustzcash PRs.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-10-02 00:46:17 +01:00
Daira Hopwood 5ced374bf1 Update references to protocol spec from process and consensus ZIPs (0 to 252 inclusive, and 1014).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-10-02 00:46:17 +01:00
Daira Hopwood 7421696ffa ZIP 225: Correct the size of an Orchard Action encoding in vActionsOrchard.
(The same error was corrected in v2021.2.1 of the protocol spec by 3f3195eb5c12c94b9e38ab7dfa5d660e144a97d3.)
fixes #525

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-06-22 07:27:28 +01:00
Daira Hopwood 35f42b8a49 ZIP 225: document that all fields are little-endian.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-06-05 15:49:13 +01:00
Kris Nuttycombe eea56aa173 The roots of empty transaction hash subtrees are now uniformly committed to with empty hashes. 2021-05-06 15:49:50 -06:00
Daira Hopwood 4f590fb8cd ZIP 225: add nConsensusBranchId field to the v5 transaction format.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-23 22:34:20 +01:00
Daira Hopwood 21d3c13d4f Update references to the protocol spec for all NU5-related ZIPs.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-23 22:33:56 +01:00
Daira Hopwood 89596379ff ZIP 225: Cosmetics (trailing spaces).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 00:58:37 +01:00
Kris Nuttycombe e0b08fd576 ZIP 225: Remove anchorSapling field when there are no spends.
Co-authored-by: Kris Nuttycombe <kris@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-01 00:58:23 +01:00
Kris Nuttycombe 6ecba03a2a Fix vSpendAuthSigsOrchard field name. 2021-03-30 10:57:24 -06:00
Kris Nuttycombe e936a21a6b
Apply suggestions from code review
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-03-30 09:40:13 -06:00
Kris Nuttycombe 02fd26fc1f Make ordering of Orchard txid hash fields consistent with field order.
Also fixes a few conflicting/incorrect digest references and
removes some spurious duplication.

Co-authored by: Daira Hopwood <daira@jacaranda.org>
2021-03-30 08:28:09 -06:00
Kris Nuttycombe f202b83a9d Remove Sprout commitments from ZIP 244; include flagsOrchard in txid. 2021-03-26 16:37:30 -06:00
Kris Nuttycombe e4bc6ad354 Fixes for ZIP 225 issues identified by the NCC audit. 2021-03-26 16:37:29 -06:00
Daira Hopwood 5e55821889 NCC audit: Make the description of when fields are included in v5 transactions consistent
between the protocol specification and ZIP 225. Also regenerate the HTML for ZIP 225.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 18:23:57 +00:00
Daira Hopwood 55af963e53 NCC audit: Add a definition for the section symbol in \crossref{introduction}, before its first use.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 18:23:57 +00:00
Daira Hopwood eff39611f8 ZIP 225: Correct the size of the outCiphertext field in a Sapling Output description.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 18:23:57 +00:00
Daira Hopwood 3d386eeec0 ZIP 225: Update references.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 18:23:57 +00:00
Daira Hopwood 5fef9270e2 NCC audit: Correct the sizes of SpendDescriptionV5 and OutputDescriptionV5 in the version transaction format.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 18:23:57 +00:00
Daira Hopwood 4d983aa855 NCC audit: Make the naming of enableSpends and enableOutputs consistent.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-26 18:23:57 +00:00
Daira Hopwood 0dfe5df5e3 ZIP 225: fix rst errors.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-17 18:15:11 +00:00
Daira Hopwood 9ab9857bba
Merge pull request #453 from nuttycom/225_remove-sprout-alternative
Proposal to remove Sprout fields from the V5 transaction format.
2021-03-17 18:09:19 +00:00
Kris Nuttycombe 09597dd1ee
Apply suggestions from code review
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-03-17 11:54:51 -06:00
Kris Nuttycombe 9627ad7c49 Fix zip-0222 reference. 2021-03-17 11:54:07 -06:00
Kris Nuttycombe fbddfafef4 Update the alternatives section of ZIP-0225 to reflect the adopted alternative. 2021-03-17 11:28:13 -06:00
Daira Hopwood 559291b192 ZIPs 224, 225 and 245: add MIT licensing.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-03 16:34:12 +00:00
Daira Hopwood f06f5539d8 ZIP 224 and 225: add Created dates.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-03 16:23:50 +00:00
Kris Nuttycombe 9a4b2e9afe
Update zip-0225.rst
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-03-02 20:24:28 -07:00
Kris Nuttycombe 0fc45a53ca Proposal to remove Sprout fields from the V5 transaction format. 2021-03-02 17:58:12 -07:00
Daira Hopwood 35b04b3115 ZIP 225: rst fixes and minor editorial changes.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-02 20:18:41 +00:00
Kris Nuttycombe ed25876e21 Add flagsOrchard field 2021-03-01 16:14:04 -07:00
Kris Nuttycombe 96b8fd1e35 Clean up RST tables and more quoting fixes. 2021-03-01 15:50:11 -07:00
Kris Nuttycombe 9663e146a9
Apply suggestions from code review
* Consistency in naming of spends and actions
* Proper quoting of identifiers within rst tables
* Fix to aggregated Orchard proof size

Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-03-01 15:21:39 -07:00
Kris Nuttycombe 62dca39483 Separate Sapling effecting data from authorizing data in the transaction format.
This change restructures the wire format of Sapling spend and output
descriptions to segregate authorizing data from the data describing the
effects of the transaction in a similar fashion as has been done for
Orchard. The result is now symmetric between Sapling and Orchard, and
also simplifies slightly the description of the computation of the
authorizing data commitment in ZIP 244.
2021-03-01 10:55:11 -07:00
Kris Nuttycombe 267bced55a Draft of ZIP 225 2021-02-28 12:32:29 -07:00
Daira Hopwood 368890ae8f Add stub for ZIP 225 (Version 5 Transaction Format).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-02-15 21:03:28 +00:00