zec
/
zips
mirror of https://github.com/zcash/zips.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
3,235 Commits 41 Branches 258 Tags 1.2 GiB
Commit Graph

42 Commits

Author SHA1 Message Date
Daira Emma Hopwood 2eb0ed8ef0 Updates to reference BCP 14 rather than RFC 2119. fixes #729 
Also change two "should"s in ZIP 224 to "SHOULD"s.

Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
 2023-10-28 15:34:22 +01:00
Daira Emma Hopwood d1b91d9e7f Regenerate HTML. 
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
 2023-03-02 12:24:49 +00:00
Daira Hopwood 25610fc5c7 Regenerate all HTML using Docutils 0.19. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2022-09-20 10:22:23 +01:00
Daira Hopwood 54359a8809 Update the status of all NU5 ZIPs to Final. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2022-06-22 22:21:35 +01:00
Jack Grigg 4075c18cc4 ZIP 244: Fix ill-defined commitments for shielded coinbase 
In zcash/zips#577 we altered ZIP 244 to have shielded signatures commit
to the same data as transparent inputs, in transactions that contain
transparent components. However, the edge case of shielded coinbase was
not correctly handled; they contain both a consensus-required "dummy"
transparent input, and binding signatures which would be required to
commit to a `CTxOut` that does not exist.

We resolve this by partially reverting one of the zcash/zips#577 changes,
by having S.2 for coinbase transactions be identical to T.2. This reverts
binding signatures in coinbase transactions to effectively signing the
transaction ID.

At the same time, we also revert the same change for transactions with no
transparent inputs but some transparent outputs; these also now revert to
using the transaction ID for all shielded signatures (like fully-shielded
transactions). The hardware wallet edge case does not apply here, as all
input values are shielded and therefore directly committed to.
 2022-01-24 22:46:41 +00:00
Daira Hopwood 2ae8fc6cec Minor wording nits. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2022-01-13 14:29:30 +00:00
Jack Grigg 1b30e57bde ZIP 244: Commit to scriptPubKey in txin_sig_digest instead of scriptCode 
This is a no-op for every scriptPubKey format except P2SH, where we now
commit to the digest of the redeemScript instead instead of redeemScript
directly.
 2022-01-12 22:08:22 +00:00
Jack Grigg 509b7a2b0c ZIP 244: Rename script_codes_sig_digest to scriptpubkeys_sig_digest 2022-01-12 16:00:23 +00:00
Jack Grigg 8e74c62a21 ZIP 244: Fix numbering of BIP 341 references 
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
 2022-01-12 15:58:51 +00:00
Jack Grigg 9e12b49e03 Merge branch 'main' into 574-changes-to-zip-244-transparent 2022-01-12 15:58:36 +00:00
Daira Hopwood 0ada3050af [Dark mode] Fix the background colour of the section anchor image. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2022-01-11 13:19:12 +00:00
Kris Nuttycombe 30ff9f6ddb Regenerate HTML 2022-01-07 16:46:10 -07:00
Daira Hopwood bdfe15bb3f Apply suggestions from code review 
Co-authored-by: Kris Nuttycombe <kris.nuttycombe@gmail.com>
 2022-01-05 17:37:33 +00:00
Jack Grigg 2671741042 ZIP 244: Regenerate HTML 2022-01-04 00:54:16 +00:00
Daira Hopwood abb898f484 ZIP 244: fix heading levels for Orchard digests. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-12-30 10:05:16 +00:00
Daira Hopwood dfd7a5a561 ZIP 244: add Jack Grigg to authors. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-12-30 10:03:12 +00:00
Daira Hopwood 5ced374bf1 Update references to protocol spec from process and consensus ZIPs (0 to 252 inclusive, and 1014). 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-10-02 00:46:17 +01:00
Daira Hopwood 11b8688a1d Correct references to the title of ZIP 200. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-08-15 23:47:48 +01:00
Daira Hopwood 604c40a5c0 ZIP 244: add a note that the empty authorization data tree cannot occur. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-06-15 15:24:09 +01:00
Kris Nuttycombe f0c438de9b Clarify contruction of `hashAuthDataRoot`. 
This changes the specification of hashAuthDataRoot to state that leaves
of the Merkle tree used to construct hashAuthDataRoot should have the
null hash value, while empty internal nodes should be hashes of empty
leaves. It also defines an all-FFs placeholder value to be used for
pre-v5 transactions in this tree.

Co-authored-by: Kris Nuttycom <nuttycom@electriccoin.co>
Co-authored-by: Jack Grigg <jack@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-06-15 15:14:44 +01:00
Kris Nuttycombe 97aa1be78e Regenerate HTML 2021-05-18 08:16:15 -06:00
Kris Nuttycombe 8d21457112 Add a note about the signedness of `value` 2021-05-18 07:53:40 -06:00
Kris Nuttycombe becbec175c Fix rendering of txin_sig_digest 2021-05-11 08:16:33 -06:00
Kris Nuttycombe 0bc4726a79 Regenerate ZIP-244 HTML. 2021-05-10 17:44:08 -06:00
Kris Nuttycombe f22a6d4151 Clarify hashes over authorizing data. 2021-05-06 16:06:03 -06:00
Kris Nuttycombe eea56aa173 The roots of empty transaction hash subtrees are now uniformly committed to with empty hashes. 2021-05-06 15:49:50 -06:00
Daira Hopwood 21d3c13d4f Update references to the protocol spec for all NU5-related ZIPs. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-04-23 22:33:56 +01:00
Daira Hopwood 89f5a20d6d ZIP 244: regenerate HTML. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-04-23 16:50:22 +01:00
Daira Hopwood cb141ac91e ZIP 244: regenerate HTML. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-04-21 00:12:46 +01:00
Daira Hopwood 31e8b03491 ZIP 244: update link to protocol spec. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-03-30 20:19:33 +01:00
Daira Hopwood b0c65971d7
Merge pull request #467 from nuttycom/zip_225-ncc_fixes 
Fixes for ZIP 225 issues identified by the NCC audit.
 2021-03-30 20:10:43 +01:00
Kris Nuttycombe 0dd2982ec3 Update generated HTML. 2021-03-30 11:13:28 -06:00
Daira Hopwood 306c575b87 ZIP 244: regenerate HTML. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-03-29 16:52:29 +01:00
Daira Hopwood 5df826f0f6 ZIP 244: formatting fix. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-03-07 19:34:11 +00:00
Daira Hopwood a55581bae5 Regenerate HTML. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-03-02 20:24:31 +00:00
Daira Hopwood 4b5ce259d1 Move ZIP 244 to Proposed and ZIP 245 to Draft. 
Also fix an rst syntax error in ZIP 245.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-02-15 20:52:40 +00:00
Kris Nuttycombe d610b8ca17 Regenerate html. 2021-02-15 10:00:04 -07:00
Kris Nuttycombe 506c3d0df3 Regenerate HTML 2021-02-09 08:07:53 -07:00
Kris Nuttycombe 4da60ce58b Fix authorizing commitment to include spend_auth_sigs 2021-02-02 13:06:43 -07:00
Kris Nuttycombe 3bc233bafb Clean up HTML rendering of the RST. 2021-01-26 15:29:24 -07:00
Kris Nuttycombe e3729e8e7c Fix rst rendering errors. 2021-01-26 15:06:30 -07:00
Daira Hopwood 917c85380c Add placeholder ZIPs for reserved numbers. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2020-09-14 15:53:54 +01:00