Commit Graph

3174 Commits

Author SHA1 Message Date
Daira Emma Hopwood 932b81d59d
dk is already a byte sequence. 2023-08-22 20:30:42 +01:00
Andrew Arnott 236336ad2f
Remove stray " character from ZIP-321 2023-08-17 07:45:36 -06:00
Andrew Arnott 61654491ce
Fix ZIP-316 bug in expected `dk` length
The `dk` value is 256 bits long. It's the *diversifier* that is only 88 bits long. The incoming viewing key requires the diversifier key -- not the diversifier.

This change also reflects the de facto standard in implementations up to this point, including YWallet and the [zcash_address crate](https://docs.rs/zcash_address/latest/src/zcash_address/kind/unified/ivk.rs.html).
2023-07-31 07:21:04 -06:00
Andrew Arnott af2f3aece4
Fix reference to undefined LEBS2OS function
The `LEBS2OS` function does not exist and isn't meant to. This reference is understood to have meant `LEBS2OSP`.

See discussion at:
https://forum.zcashcommunity.com/t/what-is-the-lebs2os-function-in-the-zip-32-spec/44886
2023-07-31 07:16:58 -06:00
Andrew Arnott 4ebc0f7629
Fix identification of HRP for full viewing keys
This was likely a copy-paste error with the section above it, which is very similar but presents the human-readable part of *incoming* viewing keys.
2023-07-31 07:13:11 -06:00
Daira Emma Hopwood c7a50bfd1b
Merge pull request #701 from str4d/700-collapsible-inline-rationale
Make inline Rationale sections collapsible
2023-07-21 20:39:49 +01:00
Jack Grigg 370b40e8f4 Update ZIP 0 to mention inline Rationale subsections 2023-07-20 16:54:48 +01:00
Jack Grigg 2fd1866298 Make existing inline rationale sections collapsible 2023-07-20 16:41:26 +01:00
dependabot[bot] ee79f0694d Bump actions/checkout from 3.5.2 to 3.5.3
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.2 to 3.5.3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3.5.2...v3.5.3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-07-13 18:52:54 -04:00
Daira Hopwood 0464b4893f
Merge pull request #695 from daira/zip-317-txunpaidactionlimit
ZIP 317: describe deployments and move status to Active
2023-05-25 14:57:23 +00:00
Daira Emma Hopwood 5659650da3 ZIP 317: describe deployments and move status to Active.
Also update the Endorsements section.

Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-05-25 15:16:14 +01:00
Daira Hopwood b00a20c949
Merge pull request #690 from zcash/sellout-zip-339
Correct issue link for ZIP 339
2023-05-10 21:09:00 +00:00
Daira Emma Hopwood 45ebfe1e1d ZIP 339: regenerate HTML.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-05-10 22:08:16 +01:00
dependabot[bot] 552b675999 Bump EndBug/add-and-commit from 9.1.1 to 9.1.3
Bumps [EndBug/add-and-commit](https://github.com/EndBug/add-and-commit) from 9.1.1 to 9.1.3.
- [Release notes](https://github.com/EndBug/add-and-commit/releases)
- [Commits](https://github.com/EndBug/add-and-commit/compare/v9.1.1...v9.1.3)

---
updated-dependencies:
- dependency-name: EndBug/add-and-commit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-05-10 17:06:41 -04:00
Greg Pfeil fa915b2a58
Correct issue link for ZIP 339 2023-05-07 01:33:28 -06:00
Daira Hopwood 8dba2077ce
Merge pull request #685 from daira/zip401-update-constants
ZIP 401: Allow an approximation of memory size, and update constants to avoid penalizing Orchard
2023-05-03 21:10:53 +00:00
Daira Emma Hopwood 3783355612 ZIP 401: regenerate HTML.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-05-03 22:09:26 +01:00
Deirdre Connolly 478f9f59f7 ZIP 401: include actual `zcashd` and `zebrad` versions that merged changes.
Co-authored-by: teor <teor@riseup.net>
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-05-03 22:09:06 +01:00
dependabot[bot] 18fce3b4a7 Bump actions/checkout from 3.5.1 to 3.5.2
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.1 to 3.5.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3.5.1...v3.5.2)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-04-18 08:36:24 -04:00
Daira Emma Hopwood 6e817f002d ZIP 401: updates to constants, rationale, and deployment.
* Update minimum cost threshold to 10000, and low_fee_penalty to 40000.
* Update references to "standard fee" in the Rationale section to take
  account of ZIP 317.
* Update the history of deployment and reference PRs.

fixes #565

Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-04-16 19:30:09 +01:00
Daira Emma Hopwood 6b074e1626 ZIP 401: allow implementations to use a different approximation of the
memory size of a transaction than its serialized size.

fixes #673

Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-04-16 19:11:23 +01:00
Daira Emma Hopwood aca1158f4e ZIP 401: the original deployment was in zcashd v2.1.0-1, not v2.1.0.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-04-16 18:55:53 +01:00
Daira Emma Hopwood 5356c6be47 ZIP 401: formatting of "zcashd" (cosmetic).
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-04-16 18:54:59 +01:00
dependabot[bot] e7d1f3e3c9 Bump actions/checkout from 3.4.0 to 3.5.1
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.4.0 to 3.5.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3.4.0...v3.5.1)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-04-12 17:05:16 -04:00
Daira Hopwood 7292281012
Merge pull request #674 from daira/zip-0-updates
ZIP 0 updates
2023-03-22 22:03:13 +00:00
Deirdre Connolly 757de495d6 Accept @nuttycom's curmudgeonly suggestion :-)
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-03-22 22:00:38 +00:00
Daira Hopwood 7baa07aafe
Merge pull request #678 from zcash/dependabot/github_actions/actions/checkout-3.4.0
Bump actions/checkout from 3.3.0 to 3.4.0
2023-03-21 14:37:02 +00:00
Daira Emma Hopwood ab5a94592e Regenerate HTML using current rst2html (with docutils 0.19).
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-03-21 13:18:15 +00:00
Daira Emma Hopwood 815db1ca09 ZIP 316: cosmetics and minor rewording.
Also add definitions of Unified String Encoding and Unified QR Encoding.

Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-03-21 13:16:14 +00:00
Daira Emma Hopwood 158b32dabc ZIP 316: update Owners and Credits.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-03-21 13:11:12 +00:00
Daira Hopwood 418bf7fcab ZIP 316: add MAY to keywords.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2023-03-21 13:11:12 +00:00
dependabot[bot] 9967a46280
Bump actions/checkout from 3.3.0 to 3.4.0
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3.3.0...v3.4.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-03-16 16:01:21 +00:00
Daira Emma Hopwood 871d5652c1 Makefile: `make discard` should discard changes to `README.rst`.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-03-03 18:37:42 +00:00
Daira Emma Hopwood e125258422 ZIP 332 stub: add @nuttycom as an Owner and update README.rst.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-03-03 18:37:42 +00:00
Daira Emma Hopwood 3e4bffef85 Add stub for ZIP 332: Wallet Recovery from zcashd HD Seeds
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-03-03 18:29:45 +00:00
Daira Emma Hopwood af060f7204 ZIP 0: regenerate HTML.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-03-02 12:28:22 +00:00
Daira Emma Hopwood ede99c9683 ZIP 0: minor clarifications.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-03-02 12:27:33 +00:00
Daira Emma Hopwood 063f51ed39 ZIP 0: describe the use of ZIP stubs.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-03-02 12:27:32 +00:00
Daira Emma Hopwood e60f6b7086 ZIP 0: add the ZIPs git repository as a reference.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-03-02 12:27:32 +00:00
Daira Emma Hopwood d1b91d9e7f Regenerate HTML.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-03-02 12:24:49 +00:00
Daira Emma Hopwood 2de178e9cc Update ZIP stubs 226 and 227 (for ZSAs).
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-03-02 12:13:27 +00:00
Daira Emma Hopwood e332ad3821 Always pluralize Owners and Original-Authors fields, as specified in ZIP 0.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-03-02 12:13:27 +00:00
Daira Emma Hopwood 8ea921667d Daira Hopwood -> Daira Emma Hopwood.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-03-02 12:13:07 +00:00
Jack Gavigan 137839e393
Amend ZIP1014 to provide a Discretionary Budget for MGRC (#668)
In 2021 Jason McGee proposed that ZIP 1014 be amended to provide the Major Grants Review Committee (aka the Zcash Community Grants Committee) with a Discretionary Budget. The proposal was approved by the Zcash Community Advisory Panel (ZCAP) in December 2021  - https://vote.heliosvoting.org/helios/elections/2d0787fc-61de-11ec-8619-8ee85a8a1b8a/view

The pull request amends ZIP 1014 to reflect the Zcash community's decision to provide the Major Grants Review Committee with a Discretionary Budget, funded out of the MG Slice of the Dev Fund. 

The initial denomination (ZEC), annual budget (3% of the MG slice), cap ($1,000,000 USD) and floor ($250,000) were established in the same ZCAP poll that approved the proposal. Zcash Foundation will run a similar poll to allow ZCAP to change these parameters if requested to do so by the Major Grants Review Committee.

Co-authored-by: teor <teor@riseup.net>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-02-15 16:06:28 -05:00
dependabot[bot] 90ab63fa55 Bump actions/checkout from 3.1.0 to 3.3.0
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.1.0 to 3.3.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3.1.0...v3.3.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-01-11 16:14:55 -05:00
Daira Hopwood 2d89ab5736 ZIP 317: add note about the need to modify the coinbase transaction.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-12-14 16:06:18 -05:00
Daira Hopwood c7c1c22da0 ZIP 317: add `min` and `floor` to Notation section.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-12-14 16:06:18 -05:00
Daira Hopwood 91c4c89eaa ZIP 317: add MAY to keywords.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-12-14 16:06:18 -05:00
Daira Hopwood 4d60ae131d
Merge pull request #650 from daira/zip-317-algorithm-4
ZIP 317: change block template construction to use "algorithm 4"
2022-12-07 21:30:07 +00:00
Daira Hopwood 0d9a96050b ZIP 317: address Teor's comments.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-12-05 21:46:30 +00:00