Jack Grigg
9b87a3ef00
Minor fixes
2020-03-10 13:14:29 +00:00
Jack Grigg
1af5d1a076
Cosmetic changes
...
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2020-03-10 13:14:29 +00:00
Jack Grigg
5e4a71e367
Clean up ZIP metadata and abstract
2020-03-10 13:14:29 +00:00
Jack Grigg
7b98f97f5d
Rework paragraph to eliminate incomplete sentence
2020-03-10 13:14:29 +00:00
Jack Grigg
f503789adf
Clarify explanations in Background section
2020-03-10 13:14:29 +00:00
Jack Grigg
bf159d1221
Use "altitude" to measure peaks instead of "height"
...
"Height" is used elsewhere in the ZIP to refer to block heights.
2020-03-10 13:14:29 +00:00
Jack Grigg
9eee0edd0c
Remove emails for Original-Authors
...
People in the Original-Authors field are not contact points for a ZIP.
2020-03-10 13:14:29 +00:00
Jack Grigg
1ad94f26c7
Remove external figures
...
Figures should be stored in a subdirectory, but the source files for the
figures have not been provided, and one of the figures contains an error.
2020-03-10 13:14:29 +00:00
Jack Grigg
d5e033bba9
Specify block header consensus rules, remove version change
2020-03-10 13:14:29 +00:00
Jack Grigg
069fa9c179
Fix typo in Background
2020-03-10 13:14:29 +00:00
Jack Grigg
5fd74c8a14
Commit to number of Sapling transactions instead of shielded transactions
2020-03-10 13:14:29 +00:00
Jack Grigg
c8193992d4
Clarify calculation of block ranges
2020-03-10 13:14:29 +00:00
Jack Grigg
6d64ce0c87
Fix vulnerability in get_peaks() pseudocode
...
This addresses finding NCC-1908_Zcash-002.
2020-03-10 13:14:29 +00:00
Jack Grigg
5b411837f4
Fix vulnerability in append() pseudocode.
...
This addresses finding NCC-1908_Zcash-001.
2020-03-10 13:14:29 +00:00
Jack Grigg
a627029132
Fix bugs in delete() pseudocode
2020-03-10 13:14:29 +00:00
Jack Grigg
1ef1388501
Move bag_peaks() pseudocode into the first block it is used in
2020-03-10 13:14:29 +00:00
Jack Grigg
be5dd9c66e
Fix bugs in make_parent() pseudocode
2020-03-10 13:14:29 +00:00
Jack Grigg
a239b8e3c9
Consistent BLAKE2b capitalization
2020-03-10 13:14:29 +00:00
Jack Grigg
f04f47f251
Fix reference to ZIP 307
2020-03-10 13:14:29 +00:00
Jack Grigg
630a4160f2
Explicitly note that wrapping addition is fine for nSubTreeTotalWork
2020-03-10 13:14:29 +00:00
Jack Grigg
893d06ab9b
Move Security and Privacy Considerations to below Rationale
2020-03-10 13:14:29 +00:00
Jack Grigg
b5b545f088
Use header characters consistent with other ZIPs
2020-03-10 13:14:29 +00:00
Jack Grigg
752f2c2c01
Use variable names in pseudcode that match the specification fields
...
The pseudocode is Python-esque, so snake_case makes sense for other
variables, but as the pseudocode is intended for specification clarity
it should defer to the specification's naming scheme.
2020-03-10 13:14:29 +00:00
Jack Grigg
7032b92143
Reference block work definition in the protocol spec
2020-03-10 13:14:29 +00:00
Jack Grigg
5aa4db445c
Fix typographical errors
2020-03-10 13:14:29 +00:00
Jack Grigg
f569d2863d
Spell Zcash correctly
2020-03-10 13:14:29 +00:00
Jack Grigg
609a15c8e4
Wrap all lines
2020-03-10 13:14:29 +00:00
Jack Grigg
14709c4fa2
Transfer ownership of ZIP 221 to Jack Grigg
2020-03-10 13:14:29 +00:00
ying tong
0ac23578de
update append pseudocode (fixes by @prestwich)
2020-03-10 13:14:29 +00:00
James Prestwich
8f3339dfc8
remove typo
2020-03-10 13:14:29 +00:00
James Prestwich
d159df6791
rename zip-0211.rst to zip-0221.rst. Change type of nSubTreeTotalWork to uint256 from CompactSize uint
2020-03-10 13:14:29 +00:00