Commit Graph

53 Commits

Author SHA1 Message Date
Daira Hopwood c762d1ca67 Regularize references, especially to RFCs and the Protocol Spec.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-11-09 15:59:51 +00:00
Daira Hopwood 3efc1217bd Update ZIP statuses:
* ZIPs 213, 221, 250 -> Final
* ZIPs 207, 251 -> Implemented (zcashd)
* ZIP 1014 -> Active.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-09-05 13:11:28 +01:00
Daira Hopwood 84f962e857 ZIPs 211, 212, 221: tools.ietf.org -> www.rfc-editor.org.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-06-02 18:35:15 +01:00
Daira Hopwood da3eb7d5c7 ZIPs 250 and 221 to Implemented (zcashd).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-05-30 17:19:19 +01:00
Daira Hopwood 711a88b545 ZIP 221: set hashLightClientRoot to all-zero in the block that activates the ZIP.
Also don't assume activation at Heartwood in the main specification, to improve
applicability to non-Zcash chains.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-04-01 11:40:21 +01:00
Daira Hopwood bbe73d0893 ZIP 221: fix typo.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-04-01 11:36:29 +01:00
Daira Hopwood 6cce68e02a ZIP 211 pseudocode: correct missing consensusBranchId argument in call to H.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-03-31 13:54:41 +01:00
Daira Hopwood e0c2123b05 ZIP 221: change the pseudocode so that CONSENSUS_BRANCH_ID doesn't look as though it's a constant.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-03-24 14:53:50 +00:00
Daira Hopwood 7196ab330c ZIP 221: update the discussion of difficulty adjustment in security considerations, per @str4d's review.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-03-24 14:52:44 +00:00
Daira Hopwood 238d00275e ZIP 221: strengthen caveat about FlyClient security in chains with rapid difficulty adjustment.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-03-23 16:31:39 +00:00
Daira Hopwood 5edc36cff1 ZIP 221: update ZIP links in references.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-03-17 14:26:38 +00:00
Daira Hopwood 03dac17d2a ZIP 221: resolve ambiguities for the first block of a network upgrade.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-03-16 21:36:05 +00:00
Daira Hopwood 62e4a4228d "branch" -> "consensus branch"
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-03-16 21:02:36 +00:00
str4d b2c36ca621
Merge pull request #331 from daira/zip-0250
Add ZIP 250: Deployment of the Heartwood Network Upgrade.
2020-03-11 11:27:35 +13:00
Daira Hopwood 86dbc09fc3 ZIP 221: update note about uint32 time overflow.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-03-10 19:16:55 +00:00
Daira Hopwood 94f8cdcae5 Add ZIP 250: Deployment of the Heartwood Network Upgrade.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-03-10 17:20:18 +00:00
Daira Hopwood 9aa520bbb3 ZIP 221: more cosmetics.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-03-10 16:54:14 +00:00
Daira Hopwood 053e86f87f ZIP 221: cosmetics.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-03-10 16:50:39 +00:00
Daira Hopwood c4457ae78f ZIP 221: Document that nTime fields will overflow on 2106-02-07.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-03-10 16:43:19 +00:00
Daira Hopwood 6d471d6cff ZIP 221 to Proposed.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-03-10 16:01:14 +00:00
Daira Hopwood 564ef9461a ZIP 221: correct Ying Tong Lai's name.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-03-10 16:00:05 +00:00
Daira Hopwood b25ab9caa1 ZIP 221: cosmetics.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-03-10 15:59:38 +00:00
Jack Grigg 9b87a3ef00 Minor fixes 2020-03-10 13:14:29 +00:00
Jack Grigg 1af5d1a076 Cosmetic changes
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2020-03-10 13:14:29 +00:00
Jack Grigg 5e4a71e367 Clean up ZIP metadata and abstract 2020-03-10 13:14:29 +00:00
Jack Grigg 7b98f97f5d Rework paragraph to eliminate incomplete sentence 2020-03-10 13:14:29 +00:00
Jack Grigg f503789adf Clarify explanations in Background section 2020-03-10 13:14:29 +00:00
Jack Grigg bf159d1221 Use "altitude" to measure peaks instead of "height"
"Height" is used elsewhere in the ZIP to refer to block heights.
2020-03-10 13:14:29 +00:00
Jack Grigg 9eee0edd0c Remove emails for Original-Authors
People in the Original-Authors field are not contact points for a ZIP.
2020-03-10 13:14:29 +00:00
Jack Grigg 1ad94f26c7 Remove external figures
Figures should be stored in a subdirectory, but the source files for the
figures have not been provided, and one of the figures contains an error.
2020-03-10 13:14:29 +00:00
Jack Grigg d5e033bba9 Specify block header consensus rules, remove version change 2020-03-10 13:14:29 +00:00
Jack Grigg 069fa9c179 Fix typo in Background 2020-03-10 13:14:29 +00:00
Jack Grigg 5fd74c8a14 Commit to number of Sapling transactions instead of shielded transactions 2020-03-10 13:14:29 +00:00
Jack Grigg c8193992d4 Clarify calculation of block ranges 2020-03-10 13:14:29 +00:00
Jack Grigg 6d64ce0c87 Fix vulnerability in get_peaks() pseudocode
This addresses finding NCC-1908_Zcash-002.
2020-03-10 13:14:29 +00:00
Jack Grigg 5b411837f4 Fix vulnerability in append() pseudocode.
This addresses finding NCC-1908_Zcash-001.
2020-03-10 13:14:29 +00:00
Jack Grigg a627029132 Fix bugs in delete() pseudocode 2020-03-10 13:14:29 +00:00
Jack Grigg 1ef1388501 Move bag_peaks() pseudocode into the first block it is used in 2020-03-10 13:14:29 +00:00
Jack Grigg be5dd9c66e Fix bugs in make_parent() pseudocode 2020-03-10 13:14:29 +00:00
Jack Grigg a239b8e3c9 Consistent BLAKE2b capitalization 2020-03-10 13:14:29 +00:00
Jack Grigg f04f47f251 Fix reference to ZIP 307 2020-03-10 13:14:29 +00:00
Jack Grigg 630a4160f2 Explicitly note that wrapping addition is fine for nSubTreeTotalWork 2020-03-10 13:14:29 +00:00
Jack Grigg 893d06ab9b Move Security and Privacy Considerations to below Rationale 2020-03-10 13:14:29 +00:00
Jack Grigg b5b545f088 Use header characters consistent with other ZIPs 2020-03-10 13:14:29 +00:00
Jack Grigg 752f2c2c01 Use variable names in pseudcode that match the specification fields
The pseudocode is Python-esque, so snake_case makes sense for other
variables, but as the pseudocode is intended for specification clarity
it should defer to the specification's naming scheme.
2020-03-10 13:14:29 +00:00
Jack Grigg 7032b92143 Reference block work definition in the protocol spec 2020-03-10 13:14:29 +00:00
Jack Grigg 5aa4db445c Fix typographical errors 2020-03-10 13:14:29 +00:00
Jack Grigg f569d2863d Spell Zcash correctly 2020-03-10 13:14:29 +00:00
Jack Grigg 609a15c8e4 Wrap all lines 2020-03-10 13:14:29 +00:00
Jack Grigg 14709c4fa2 Transfer ownership of ZIP 221 to Jack Grigg 2020-03-10 13:14:29 +00:00