Commit Graph

3261 Commits

Author SHA1 Message Date
Daira-Emma Hopwood ecbc7381f2 ZIP 316: fix a typo and remove trailing spaces.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-02-13 19:52:18 +00:00
Arya e720ad0a55
Merge pull request #783 from nuttycom/zip_316_r1_proposed
ZIP 316: Mark Revision 1 as Proposed
2024-02-13 14:08:32 -05:00
Kris Nuttycombe 1f6eec0f63 ZIP 316: Mark Revision 1 as Proposed 2024-02-13 12:07:27 -07:00
Arya 4d8dfbd191
Merge pull request #765 from nuttycom/zip_0316_rev_1
ZIP 316 Revision 1, and corresponding updates to ZIP 320
2024-02-13 13:54:54 -05:00
Kris Nuttycombe e538acac69 ZIP 316, Revision 1 and ZIP 320: Address comments from ZIP sync. 2024-02-13 11:53:39 -07:00
Daira-Emma Hopwood a5cba44738 ZIP 316: clarify Address Expiry for transactions sending to more than one UA.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-02-13 01:46:12 +00:00
Daira-Emma Hopwood 8b13e37e54 ZIP 316: apply suggestions from @arya2's review.
Co-authored-by: Arya <aryasolhi@gmail.com>
2024-02-13 01:45:41 +00:00
Daira-Emma Hopwood 56a6be2254 ZIP 316: add requirements on the revision of UAs and UIVKs derived from a
Revision 1 UIVK/UFVK.

Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-02-11 02:43:34 +00:00
Daira-Emma Hopwood ed1dd64051 ZIP 320:
* clarify the dependency on ZIP 316 Revision 1;
* move the main point of the specification of Alternative 2 to be higher up;
* clarify the semantics of UAs with both shielded Receivers and Source
  Restriction Metadata with value Transparent Source Only, and recommend
  against producing them.

Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-02-09 20:39:32 +00:00
Daira-Emma Hopwood a723dd29dd ZIP 316: formatting fix.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-02-09 20:25:57 +00:00
Daira-Emma Hopwood 81a9c41120 ZIP 316: exclude MUST-understand Metadata Items from the requirement for
Consumers to ignore Items with Typecodes they do not recognise.

Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-02-09 20:06:53 +00:00
Daira-Emma Hopwood 5e33e4760c
Merge pull request #778 from daira/zsa1
ZIPs 226, 227, and 230 - ZSA Protocol: Transfer, Issuance and Burn
2024-02-09 20:00:40 +00:00
Daira-Emma Hopwood 9fc438fb13 ZIP 320: remove a paragraph that no longer applies.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-02-09 01:36:56 +00:00
Daira-Emma Hopwood 0c4dd0d6e4 ZIPs 316 and 320: drop the "at least one shielded Item" restriction.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-02-09 01:36:51 +00:00
Daira-Emma Hopwood d9ec0e2ae6 ZIPs 316 and 320: change the prefix for Revision 1 to "ur".
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-02-09 01:21:53 +00:00
Kris Nuttycombe 9425d7a68a zip-0316: Expand the metadata typecodes range to start at 0xC0, to provide more space for MUST-understand typecodes. 2024-02-09 01:14:50 +00:00
Daira Emma Hopwood a95a0296ac ZIP 316, Revision 1: Change the Human-Readable Part for Revision 1 unified encodings.
This change ensures that wallets that have not yet been updated to ZIP
316 Revision 1 will fail to recognise Unified Addresses with
MUST-understand metadata, and consequently will not violate any
restrictions imposed on transfers by those metadata items'
requirements.

Co-authored-by: Kris Nuttycombe <kris@nutty.land>
2024-02-09 01:14:50 +00:00
Daira Emma Hopwood 84ef511641 ZIP 316: cosmetics - spell UA/UIVK consistently.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2024-02-09 01:14:50 +00:00
Kris Nuttycombe d5dd194a40 Reintroduce ZIP 316, Revision 1 changes.
This reverts commit 058b1a6a17.
2024-02-09 01:14:50 +00:00
Daira-Emma Hopwood 21cf12456a ZIPs 226, 227 and 230: regenerate HTML.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-02-07 19:18:35 +00:00
Daira-Emma Hopwood 406b7e86d9 CSS: Improve the font weight and size of code in headings.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-02-07 19:18:35 +00:00
Daira-Emma Hopwood 46a885f1cd ZIP 230: reword and wrap abstract.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-02-07 19:18:35 +00:00
Daira-Emma Hopwood 30bf5c9666 ZIP 227: minor rewording.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-02-07 19:18:35 +00:00
Daira-Emma Hopwood c67f8d0359 ZIP 226: editorial clarifications.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-02-07 19:18:35 +00:00
Daira-Emma Hopwood 15118ac4c0 ZIPs 226, 227, and 230: cosmetic math formatting improvements.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-02-07 19:18:35 +00:00
Daira-Emma Hopwood 3b98ae5e05 ZIPs 226, 227, and 230: update references and key words to latest ZIP conventions and protocol spec.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-02-07 19:18:35 +00:00
Daira-Emma Hopwood 865469aadb ZIP 226: use `\star` instead of `*` for bit representations.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-02-07 19:18:35 +00:00
Daira-Emma Hopwood a7a9c213db ZIPs 226 and 227: remove trailing spaces.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-02-07 19:18:35 +00:00
Vivek Arte 9eb00eeac3 Clarifying the encoding of `ik` (#46)
This makes it clear that the encoding of `ik` used in the Asset Base
derivation is big-endian, as in the case of the underlying BIP 340
Schnorr signature scheme.

It also adds a clarification about the version byte used in the Asset
Base derivation.
2024-02-07 19:18:35 +00:00
Vivek Arte 0fbded6fbb Updates to Security and Privacy Considerations section (#45)
This adds some details to the ZIP 226 Security and Privacy
Considerations section to address this
[comment](https://github.com/zcash/zips/pull/680#discussion_r1377549364)
2024-02-07 19:18:35 +00:00
Vivek Arte de1235c2ce Rename of Issuance Keys (#44)
This performs a rename of the Issuance keys as follows:

- `imk : Issuance master key` is renamed to `isk: Issuance authorizing
key`
2024-02-07 19:18:35 +00:00
Vivek Arte eed714f30e Suggestions from ZIP review: notation, typographical edits, and update Daira-Emma's name.
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-02-07 19:18:35 +00:00
Vivek Arte 7aff601838 updated burn description
Minor addition to burn mechanism description
2024-02-07 19:18:35 +00:00
Vivek Arte cea341ed7d Switching the issuance authorization scheme to using Bitcoin Schnorr over `secp256k1`, as in BIP 340. (#40)
We switch the `issueAuthSig` scheme from RedPallas without
key re-randomization to the Bitcoin Schnorr signature (as described in
bip340).
We also perform notation changes of `idk` to `imk`, and adjust the
derivation of the issuance keys to fit with the updated Issuance
Authorization Signature scheme.
2024-02-07 19:18:35 +00:00
Vivek Arte 9b1a0c24e5 Move the updated transaction structure from ZIP 226 to ZIP 230 (#42)
This removes the transaction structure fields from ZIP 226 in favour
of adding them to ZIP 230, for the v6 Transaction Format.

Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
Co-authored-by: str4d <thestr4d@gmail.com>
Co-authored-by: Paul <lauxpaul@protonmail.com>
Co-authored-by: Antoine Rondelet <rondelet.antoine@gmail.com>
Co-authored-by: Constance Beguier <constance@qed-it.com>
2024-02-07 19:18:35 +00:00
Vivek Arte 57aaf2948b Renaming `idk` to `imk` throughout ZIP 227 (#41)
This is a consistent renaming of the issuance derivation key to call it the issuance master key.
2024-02-07 19:18:35 +00:00
Constance Beguier 8753f711ba Add enable_zsa flag (#37)
This PR adds enable_zsa flag into ZIP 226.
2024-02-07 19:18:35 +00:00
Vivek Arte 28832be8f0 Burn Mechanism Rearrangement (#35)
This rearranges the positioning of the burn mechanism in order to remove duplication of material between the burn mechanism section and the value balance verification section.
There is also some simplification of the naming convention for the Asset Base variable.
2024-02-07 19:18:35 +00:00
Vivek Arte c70e0fd92b Adding explicit assumption for canonical encodings for the Asset Base. (#33)
This addresses [this comment](https://github.com/zcash/zips/pull/680#discussion_r1268669667).
2024-02-07 19:18:35 +00:00
Vivek Arte 33b23d074f Guidelines to wallets regarding representing Assets to clients (#32)
This adds to the specification to provide wallets instructions on displaying Asset information to users in an unambiguous way.

This addresses [this comment](https://github.com/zcash/zips/pull/680#discussion_r1147019628).
2024-02-07 19:18:35 +00:00
Vivek Arte 3651df5ffc Suggestions from ZIP review: clarifications and typographical edits.
Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>
2024-02-07 19:18:35 +00:00
Constance Beguier e5f03d9bce Update with circuit changes (#31)
- Add the new nullifier equation for split notes
- Add a link to Orchard circuit document
- Add is_native_asset auxiliary witness
- Remove constraint (split_flag=1) => (v_old != 0)
- Add constraint (split_flag=1) => (is_native_asset=0)
2024-02-07 19:18:35 +00:00
Vivek Arte d92ccecb48 Consistency changes for notation and updates to issuance key derivation (#30)
This PR improves the naming of variables to make them consistent with
the broader ZIPs conventions.

It also makes changes to the issuance key derivation and the terms used
for the various keys.
2024-02-07 19:18:35 +00:00
Antoine Rondelet a7f5ffa0e9 Added missing indices over sums (#27)
This PR adds missing indices over sums. It also fixes and makes improvements to the burn mechanism description.

Co-authored-by: Vivek Arte <46618816+vivek-arte@users.noreply.github.com>
2024-02-07 19:18:35 +00:00
Vivek Arte 4ec6bf6505 Changing issue digest hash personalization values to match with implementation (#29)
This makes the changes in ZIP 227 based on [this
comment](https://github.com/QED-it/orchard/pull/66#discussion_r1227395737).
2024-02-07 19:18:35 +00:00
Antoine Rondelet cd55e625c3 Removed redundant terminology in ZIP226, building on ZIP227 (#26)
Removed redundant terminology in ZIP226, building on ZIP227, fixed abstract and used consistent terminology to stick to issuance instead of creation of assets.

Co-authored-by: Vivek Arte <46618816+vivek-arte@users.noreply.github.com>
2024-02-07 19:18:35 +00:00
Vivek Arte f8936acdae Updates to naming conventions and table format (#28)
This makes the naming conventions for variables more consistent, largely with a view to using double backticks for terms that appear in the transaction format and datatype description tables.

These tables have also been reformatted to be consistent with other ZIPs in their rst form.

The `previously_finalized` set is renamed to `finalized_assets`, and this set now stores `AssetDigest` values rather than `AssetId` values for more compactness in the global state.
2024-02-07 19:18:35 +00:00
Antoine Rondelet 709874d76b Fixed math boundary around purpose (#23)
As per the title, this is a tiny fix to adjust the boundary of the
math environment which wasn't properly closed and thus rendered poorly
on the html.
2024-02-07 19:18:35 +00:00
Vivek Arte b76813c018 Updates to issue bundle hash personalizations (#22)
A few of the issue bundle hash personalizations were 15 characters long
instead of the required 16. This is being fixed here.
2024-02-07 19:18:35 +00:00
Vivek Arte 3d26c5a4e0 Adding ZSA Orchard Action Description encoding details (#21)
This adds details of the changes to the Orchard Action encodings and
the changes to the transaction format that occur due to the ZSA
Protocol. It also improves the formatting of existing tables for Asset
Burn.
2024-02-07 19:18:35 +00:00