zecfoundation
/
frost
mirror of https://github.com/ZcashFoundation/frost.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

use BTreeMap for BindingFactorList (#155)

This commit is contained in:
Conrado Gouvea 2022-10-26 11:41:19 -03:00 committed by GitHub
parent eca2101cf8
commit c323cb6861
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
frost-core/src/frost.rs
View File

@ -11,7 +11,7 @@
//! Sharing, where shares are generated using Shamir Secret Sharing.
use std::{
collections::HashMap,
collections::{BTreeMap, HashMap},
convert::TryFrom,
fmt::{self, Debug},
ops::Index,
@ -67,14 +67,14 @@ where
/// A list of binding factors and their associated identifiers.
#[derive(Clone)]
pub struct BindingFactorList<C: Ciphersuite>(Vec<(Identifier<C>, BindingFactor<C>)>);
pub struct BindingFactorList<C: Ciphersuite>(BTreeMap<Identifier<C>, BindingFactor<C>>);
impl<C> BindingFactorList<C>
where
C: Ciphersuite,
{
/// Return iterator through all factors.
pub fn iter(&self) -> impl Iterator<Item = &(Identifier<C>, BindingFactor<C>)> {
pub fn iter(&self) -> impl Iterator<Item = (&Identifier<C>, &BindingFactor<C>)> {
self.0.iter()
}
}
@ -90,15 +90,8 @@ where
// [`binding_factor_for_participant`] in the spec
//
// [`binding_factor_for_participant`]: https://www.ietf.org/archive/id/draft-irtf-cfrg-frost-11.html#section-4.3
// TODO: switch from Vec to BTreeMap, as this can be made more efficient.
fn index(&self, identifier: Identifier<C>) -> &Self::Output {
for (i, factor) in self.0.iter() {
if *i == identifier {
return factor;
}
}
// The protocol should abort here, but can we do something nicer than a panic?
panic!("invalid identifier passed");
&self.0[&identifier]
}
}