From 036667e883ca63a63a133fe71332219676389f24 Mon Sep 17 00:00:00 2001 From: Gustavo Valverde Date: Mon, 29 Jul 2024 18:11:34 +0100 Subject: [PATCH] ref(workflows): align workflows with `zfnd` standards (#4) --- .github/dependabot.yml | 20 +++++++++++++++----- .github/workflows/cd-deploy-to-dev.yml | 3 ++- .github/workflows/chore-clean-dev.yml | 2 +- 3 files changed, 18 insertions(+), 7 deletions(-) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 4741307..f612cfd 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -2,18 +2,28 @@ version: 2 updates: - package-ecosystem: docker directory: /docker + pull-request-branch-name: + separator: "-" schedule: interval: monthly commit-message: - prefix: "deps(docker) " + prefix: "deps(docker): " - package-ecosystem: github-actions - directory: / + directory: "/" + pull-request-branch-name: + separator: "-" schedule: - interval: monthly + interval: weekly commit-message: - prefix: "deps(actions) " + prefix: "deps(actions): " groups: - devops: + docker: + patterns: + - "docker*" + gcp: + patterns: + - "google-github-actions*" + others: patterns: - "*" diff --git a/.github/workflows/cd-deploy-to-dev.yml b/.github/workflows/cd-deploy-to-dev.yml index ae6abdd..59fbd8d 100644 --- a/.github/workflows/cd-deploy-to-dev.yml +++ b/.github/workflows/cd-deploy-to-dev.yml @@ -2,7 +2,7 @@ name: Deploy to dev on: pull_request: - types: [opened, synchronize, reopened, labeled] + types: [ready_for_review, synchronize] paths: - '**/Dockerfile' - 'scripts/**' @@ -36,6 +36,7 @@ permissions: jobs: build: uses: ./.github/workflows/sub-build-docker-image.yml + if: ${{ !github.event.pull_request.draft }} with: environment: dev dockerfile_path: ./docker/Dockerfile diff --git a/.github/workflows/chore-clean-dev.yml b/.github/workflows/chore-clean-dev.yml index 75594c0..a6b88bf 100644 --- a/.github/workflows/chore-clean-dev.yml +++ b/.github/workflows/chore-clean-dev.yml @@ -32,4 +32,4 @@ jobs: - name: Removing CR service run: | - gcloud run services delete ${{ vars.APP_NAME }}-${{ env.GITHUB_HEAD_REF_SLUG || env.GITHUB_REF_SLUG }} --region=${{ vars.GOOGLE_CLOUD_REGION }} --quiet + gcloud run services delete ${{ vars.APP_NAME }}-${{ env.GITHUB_HEAD_REF_SLUG || env.GITHUB_REF_SLUG }} --region=${{ vars.GCP_REGION }} --quiet