From 68a3bb2d3461c28cab719deb102d7cc0f1d2061f Mon Sep 17 00:00:00 2001 From: debris Date: Tue, 8 Nov 2016 16:37:06 +0100 Subject: [PATCH] linting in progress --- Cargo.lock | 130 ++++++++---------------------------- Cargo.toml | 8 --- crypto/Cargo.toml | 8 --- crypto/src/lib.rs | 3 - message/Cargo.toml | 8 --- message/src/lib.rs | 3 - p2p/Cargo.toml | 8 --- p2p/src/lib.rs | 3 - pbtc/main.rs | 3 - primitives/Cargo.toml | 8 --- primitives/src/lib.rs | 3 - serialization/Cargo.toml | 8 --- serialization/src/lib.rs | 3 - serialization/src/reader.rs | 2 +- tools/clippy.sh | 31 +++++++++ tools/test.sh | 8 +-- 16 files changed, 65 insertions(+), 172 deletions(-) create mode 100755 tools/clippy.sh diff --git a/Cargo.lock b/Cargo.lock index 6d18f92f..308775c3 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1,22 +1,18 @@ [root] -name = "pbtc" +name = "verification" version = "0.1.0" dependencies = [ - "app_dirs 1.1.1 (registry+https://github.com/rust-lang/crates.io-index)", + "byteorder 0.5.3 (registry+https://github.com/rust-lang/crates.io-index)", "chain 0.1.0", - "clap 2.17.1 (registry+https://github.com/rust-lang/crates.io-index)", - "clippy 0.0.97 (registry+https://github.com/rust-lang/crates.io-index)", "db 0.1.0", - "env_logger 0.3.5 (registry+https://github.com/rust-lang/crates.io-index)", - "import 0.1.0", - "keys 0.1.0", - "log 0.3.6 (registry+https://github.com/rust-lang/crates.io-index)", - "message 0.1.0", - "miner 0.1.0", - "p2p 0.1.0", + "ethcore-devtools 1.3.0", + "linked-hash-map 0.3.0 (registry+https://github.com/rust-lang/crates.io-index)", + "parking_lot 0.3.6 (registry+https://github.com/rust-lang/crates.io-index)", + "primitives 0.1.0", "script 0.1.0", - "sync 0.1.0", - "verification 0.1.0", + "serialization 0.1.0", + "test-data 0.1.0", + "time 0.1.35 (registry+https://github.com/rust-lang/crates.io-index)", ] [[package]] @@ -76,7 +72,6 @@ source = "registry+https://github.com/rust-lang/crates.io-index" name = "bitcrypto" version = "0.1.0" dependencies = [ - "clippy 0.0.97 (registry+https://github.com/rust-lang/crates.io-index)", "primitives 0.1.0", "rust-crypto 0.2.36 (registry+https://github.com/rust-lang/crates.io-index)", ] @@ -128,28 +123,6 @@ dependencies = [ "yaml-rust 0.3.4 (registry+https://github.com/rust-lang/crates.io-index)", ] -[[package]] -name = "clippy" -version = "0.0.97" -source = "registry+https://github.com/rust-lang/crates.io-index" -dependencies = [ - "clippy_lints 0.0.97 (registry+https://github.com/rust-lang/crates.io-index)", -] - -[[package]] -name = "clippy_lints" -version = "0.0.97" -source = "registry+https://github.com/rust-lang/crates.io-index" -dependencies = [ - "matches 0.1.4 (registry+https://github.com/rust-lang/crates.io-index)", - "quine-mc_cluskey 0.2.4 (registry+https://github.com/rust-lang/crates.io-index)", - "regex-syntax 0.3.9 (registry+https://github.com/rust-lang/crates.io-index)", - "rustc-serialize 0.3.19 (registry+https://github.com/rust-lang/crates.io-index)", - "semver 0.2.3 (registry+https://github.com/rust-lang/crates.io-index)", - "toml 0.1.30 (registry+https://github.com/rust-lang/crates.io-index)", - "unicode-normalization 0.1.2 (registry+https://github.com/rust-lang/crates.io-index)", -] - [[package]] name = "crossbeam" version = "0.2.10" @@ -325,11 +298,6 @@ name = "log" version = "0.3.6" source = "registry+https://github.com/rust-lang/crates.io-index" -[[package]] -name = "matches" -version = "0.1.4" -source = "registry+https://github.com/rust-lang/crates.io-index" - [[package]] name = "memchr" version = "0.1.11" @@ -345,7 +313,6 @@ dependencies = [ "bitcrypto 0.1.0", "byteorder 0.5.3 (registry+https://github.com/rust-lang/crates.io-index)", "chain 0.1.0", - "clippy 0.0.97 (registry+https://github.com/rust-lang/crates.io-index)", "primitives 0.1.0", "serialization 0.1.0", ] @@ -421,11 +388,6 @@ dependencies = [ "odds 0.2.24 (registry+https://github.com/rust-lang/crates.io-index)", ] -[[package]] -name = "nom" -version = "1.2.4" -source = "registry+https://github.com/rust-lang/crates.io-index" - [[package]] name = "ns-dns-tokio" version = "0.1.0" @@ -470,7 +432,6 @@ version = "0.1.0" dependencies = [ "abstract-ns 0.2.1 (registry+https://github.com/rust-lang/crates.io-index)", "bitcrypto 0.1.0", - "clippy 0.0.97 (registry+https://github.com/rust-lang/crates.io-index)", "csv 0.14.7 (registry+https://github.com/rust-lang/crates.io-index)", "futures 0.1.3 (registry+https://github.com/rust-lang/crates.io-index)", "futures-cpupool 0.1.2 (registry+https://github.com/rust-lang/crates.io-index)", @@ -506,11 +467,30 @@ dependencies = [ "winapi 0.2.8 (registry+https://github.com/rust-lang/crates.io-index)", ] +[[package]] +name = "pbtc" +version = "0.1.0" +dependencies = [ + "app_dirs 1.1.1 (registry+https://github.com/rust-lang/crates.io-index)", + "chain 0.1.0", + "clap 2.17.1 (registry+https://github.com/rust-lang/crates.io-index)", + "db 0.1.0", + "env_logger 0.3.5 (registry+https://github.com/rust-lang/crates.io-index)", + "import 0.1.0", + "keys 0.1.0", + "log 0.3.6 (registry+https://github.com/rust-lang/crates.io-index)", + "message 0.1.0", + "miner 0.1.0", + "p2p 0.1.0", + "script 0.1.0", + "sync 0.1.0", + "verification 0.1.0", +] + [[package]] name = "primitives" version = "0.1.0" dependencies = [ - "clippy 0.0.97 (registry+https://github.com/rust-lang/crates.io-index)", "heapsize 0.3.7 (registry+https://github.com/rust-lang/crates.io-index)", "rustc-serialize 0.3.19 (registry+https://github.com/rust-lang/crates.io-index)", ] @@ -520,11 +500,6 @@ name = "quick-error" version = "1.1.0" source = "registry+https://github.com/rust-lang/crates.io-index" -[[package]] -name = "quine-mc_cluskey" -version = "0.2.4" -source = "registry+https://github.com/rust-lang/crates.io-index" - [[package]] name = "rand" version = "0.3.14" @@ -625,20 +600,11 @@ name = "semver" version = "0.1.20" source = "registry+https://github.com/rust-lang/crates.io-index" -[[package]] -name = "semver" -version = "0.2.3" -source = "registry+https://github.com/rust-lang/crates.io-index" -dependencies = [ - "nom 1.2.4 (registry+https://github.com/rust-lang/crates.io-index)", -] - [[package]] name = "serialization" version = "0.1.0" dependencies = [ "byteorder 0.5.3 (registry+https://github.com/rust-lang/crates.io-index)", - "clippy 0.0.97 (registry+https://github.com/rust-lang/crates.io-index)", "primitives 0.1.0", ] @@ -745,19 +711,6 @@ dependencies = [ "slab 0.3.0 (registry+https://github.com/rust-lang/crates.io-index)", ] -[[package]] -name = "toml" -version = "0.1.30" -source = "registry+https://github.com/rust-lang/crates.io-index" -dependencies = [ - "rustc-serialize 0.3.19 (registry+https://github.com/rust-lang/crates.io-index)", -] - -[[package]] -name = "unicode-normalization" -version = "0.1.2" -source = "registry+https://github.com/rust-lang/crates.io-index" - [[package]] name = "unicode-segmentation" version = "0.1.2" @@ -778,23 +731,6 @@ name = "vec_map" version = "0.6.0" source = "registry+https://github.com/rust-lang/crates.io-index" -[[package]] -name = "verification" -version = "0.1.0" -dependencies = [ - "byteorder 0.5.3 (registry+https://github.com/rust-lang/crates.io-index)", - "chain 0.1.0", - "db 0.1.0", - "ethcore-devtools 1.3.0", - "linked-hash-map 0.3.0 (registry+https://github.com/rust-lang/crates.io-index)", - "parking_lot 0.3.6 (registry+https://github.com/rust-lang/crates.io-index)", - "primitives 0.1.0", - "script 0.1.0", - "serialization 0.1.0", - "test-data 0.1.0", - "time 0.1.35 (registry+https://github.com/rust-lang/crates.io-index)", -] - [[package]] name = "void" version = "1.0.2" @@ -842,8 +778,6 @@ source = "registry+https://github.com/rust-lang/crates.io-index" "checksum byteorder 0.5.3 (registry+https://github.com/rust-lang/crates.io-index)" = "0fc10e8cc6b2580fda3f36eb6dc5316657f812a3df879a44a66fc9f0fdbc4855" "checksum cfg-if 0.1.0 (registry+https://github.com/rust-lang/crates.io-index)" = "de1e760d7b6535af4241fca8bd8adf68e2e7edacc6b29f5d399050c5e48cf88c" "checksum clap 2.17.1 (registry+https://github.com/rust-lang/crates.io-index)" = "27dac76762fb56019b04aed3ccb43a770a18f80f9c2eb62ee1a18d9fb4ea2430" -"checksum clippy 0.0.97 (registry+https://github.com/rust-lang/crates.io-index)" = "932afd50f572178f12db751606b7922376bdc3a860fc1611ffb06d7498df17cf" -"checksum clippy_lints 0.0.97 (registry+https://github.com/rust-lang/crates.io-index)" = "36892e8eb217e2119e7c048ceb031f071cc7d7fffeb992f0d3c6ab6a8a0684b0" "checksum crossbeam 0.2.10 (registry+https://github.com/rust-lang/crates.io-index)" = "0c5ea215664ca264da8a9d9c3be80d2eaf30923c259d03e870388eb927508f97" "checksum csv 0.14.7 (registry+https://github.com/rust-lang/crates.io-index)" = "266c1815d7ca63a5bd86284043faf91e8c95e943e55ce05dc0ae08e952de18bc" "checksum deque 0.3.1 (registry+https://github.com/rust-lang/crates.io-index)" = "1614659040e711785ed8ea24219140654da1729f3ec8a47a9719d041112fe7bf" @@ -861,14 +795,12 @@ source = "registry+https://github.com/rust-lang/crates.io-index" "checksum libc 0.2.17 (registry+https://github.com/rust-lang/crates.io-index)" = "044d1360593a78f5c8e5e710beccdc24ab71d1f01bc19a29bcacdba22e8475d8" "checksum linked-hash-map 0.3.0 (registry+https://github.com/rust-lang/crates.io-index)" = "6d262045c5b87c0861b3f004610afd0e2c851e2908d08b6c870cbb9d5f494ecd" "checksum log 0.3.6 (registry+https://github.com/rust-lang/crates.io-index)" = "ab83497bf8bf4ed2a74259c1c802351fcd67a65baa86394b6ba73c36f4838054" -"checksum matches 0.1.4 (registry+https://github.com/rust-lang/crates.io-index)" = "efd7622e3022e1a6eaa602c4cea8912254e5582c9c692e9167714182244801b1" "checksum memchr 0.1.11 (registry+https://github.com/rust-lang/crates.io-index)" = "d8b629fb514376c675b98c1421e80b151d3817ac42d7c667717d282761418d20" "checksum mio 0.6.1 (registry+https://github.com/rust-lang/crates.io-index)" = "410a1a0ff76f5a226f1e4e3ff1756128e65cd30166e39c3892283e2ac09d5b67" "checksum miow 0.1.3 (registry+https://github.com/rust-lang/crates.io-index)" = "d5bfc6782530ac8ace97af10a540054a37126b63b0702ddaaa243b73b5745b9a" "checksum net2 0.2.26 (registry+https://github.com/rust-lang/crates.io-index)" = "5edf9cb6be97212423aed9413dd4729d62b370b5e1c571750e882cebbbc1e3e2" "checksum nix 0.7.0 (registry+https://github.com/rust-lang/crates.io-index)" = "a0d95c5fa8b641c10ad0b8887454ebaafa3c92b5cd5350f8fc693adafd178e7b" "checksum nodrop 0.1.8 (registry+https://github.com/rust-lang/crates.io-index)" = "0dbbadd3f4c98dea0bd3d9b4be4c0cdaf1ab57035cb2e41fce3983db5add7cc5" -"checksum nom 1.2.4 (registry+https://github.com/rust-lang/crates.io-index)" = "a5b8c256fd9471521bcb84c3cdba98921497f1a331cbc15b8030fc63b82050ce" "checksum ns-dns-tokio 0.1.0 (git+https://github.com/debris/abstract-ns)" = "" "checksum num_cpus 1.1.0 (registry+https://github.com/rust-lang/crates.io-index)" = "8890e6084723d57d0df8d2720b0d60c6ee67d6c93e7169630e4371e88765dcad" "checksum odds 0.2.24 (registry+https://github.com/rust-lang/crates.io-index)" = "97b2d7c12734955740d14f7a6723d8dd8ed53cf16770ab38ca6a1aaf3124fc0d" @@ -877,7 +809,6 @@ source = "registry+https://github.com/rust-lang/crates.io-index" "checksum parking_lot 0.3.6 (registry+https://github.com/rust-lang/crates.io-index)" = "e1435e7a2a00dfebededd6c6bdbd54008001e94b4a2aadd6aef0dc4c56317621" "checksum parking_lot_core 0.2.0 (registry+https://github.com/rust-lang/crates.io-index)" = "fb1b97670a2ffadce7c397fb80a3d687c4f3060140b885621ef1653d0e5d5068" "checksum quick-error 1.1.0 (registry+https://github.com/rust-lang/crates.io-index)" = "0aad603e8d7fb67da22dbdf1f4b826ce8829e406124109e73cf1b2454b93a71c" -"checksum quine-mc_cluskey 0.2.4 (registry+https://github.com/rust-lang/crates.io-index)" = "07589615d719a60c8dd8a4622e7946465dfef20d1a428f969e3443e7386d5f45" "checksum rand 0.3.14 (registry+https://github.com/rust-lang/crates.io-index)" = "2791d88c6defac799c3f20d74f094ca33b9332612d9aef9078519c82e4fe04a5" "checksum rayon 0.4.3 (registry+https://github.com/rust-lang/crates.io-index)" = "0f0783f5880c56f5a308e219ac9309dbe781e064741dd5def4c617c440890305" "checksum regex 0.1.80 (registry+https://github.com/rust-lang/crates.io-index)" = "4fd4ace6a8cf7860714a2c2280d6c1f7e6a413486c13298bbc86fd3da019402f" @@ -889,7 +820,6 @@ source = "registry+https://github.com/rust-lang/crates.io-index" "checksum rustc_version 0.1.7 (registry+https://github.com/rust-lang/crates.io-index)" = "c5f5376ea5e30ce23c03eb77cbe4962b988deead10910c372b226388b594c084" "checksum scoped-tls 0.1.0 (registry+https://github.com/rust-lang/crates.io-index)" = "f417c22df063e9450888a7561788e9bd46d3bb3c1466435b4eccb903807f147d" "checksum semver 0.1.20 (registry+https://github.com/rust-lang/crates.io-index)" = "d4f410fedcf71af0345d7607d246e7ad15faaadd49d240ee3b24e5dc21a820ac" -"checksum semver 0.2.3 (registry+https://github.com/rust-lang/crates.io-index)" = "2d5b7638a1f03815d94e88cb3b3c08e87f0db4d683ef499d1836aaf70a45623f" "checksum shell32-sys 0.1.1 (registry+https://github.com/rust-lang/crates.io-index)" = "72f20b8f3c060374edb8046591ba28f62448c369ccbdc7b02075103fb3a9e38d" "checksum slab 0.3.0 (registry+https://github.com/rust-lang/crates.io-index)" = "17b4fcaed89ab08ef143da37bc52adbcc04d4a69014f4c1208d6b51f0c47bc23" "checksum smallvec 0.1.8 (registry+https://github.com/rust-lang/crates.io-index)" = "fcc8d19212aacecf95e4a7a2179b26f7aeb9732a915cf01f05b0d3e044865410" @@ -899,8 +829,6 @@ source = "registry+https://github.com/rust-lang/crates.io-index" "checksum thread_local 0.2.7 (registry+https://github.com/rust-lang/crates.io-index)" = "8576dbbfcaef9641452d5cf0df9b0e7eeab7694956dd33bb61515fb8f18cfdd5" "checksum time 0.1.35 (registry+https://github.com/rust-lang/crates.io-index)" = "3c7ec6d62a20df54e07ab3b78b9a3932972f4b7981de295563686849eb3989af" "checksum tokio-core 0.1.0 (git+https://github.com/debris/tokio-core)" = "" -"checksum toml 0.1.30 (registry+https://github.com/rust-lang/crates.io-index)" = "0590d72182e50e879c4da3b11c6488dae18fccb1ae0c7a3eda18e16795844796" -"checksum unicode-normalization 0.1.2 (registry+https://github.com/rust-lang/crates.io-index)" = "26643a2f83bac55f1976fb716c10234485f9202dcd65cfbdf9da49867b271172" "checksum unicode-segmentation 0.1.2 (registry+https://github.com/rust-lang/crates.io-index)" = "b905d0fc2a1f0befd86b0e72e31d1787944efef9d38b9358a9e92a69757f7e3b" "checksum unicode-width 0.1.3 (registry+https://github.com/rust-lang/crates.io-index)" = "2d6722facc10989f63ee0e20a83cd4e1714a9ae11529403ac7e0afd069abc39e" "checksum utf8-ranges 0.1.3 (registry+https://github.com/rust-lang/crates.io-index)" = "a1ca13c08c41c9c3e04224ed9ff80461d97e121589ff27c753a16cb10830ae0f" diff --git a/Cargo.toml b/Cargo.toml index 7788fe21..fca51d55 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -24,11 +24,3 @@ import = { path = "import" } [[bin]] path = "pbtc/main.rs" name = "pbtc" - -[dependencies.clippy] -optional = true -version = "0.0.97" - -[features] -default = [] -dev = ["clippy", "message/dev", "p2p/dev"] diff --git a/crypto/Cargo.toml b/crypto/Cargo.toml index 7ee7b4d7..75a7d0a1 100644 --- a/crypto/Cargo.toml +++ b/crypto/Cargo.toml @@ -6,11 +6,3 @@ authors = ["debris "] [dependencies] rust-crypto = "0.2.36" primitives = { path = "../primitives" } - -[dependencies.clippy] -optional = true -version = "0.0.97" - -[features] -default = [] -dev = ["clippy", "primitives/dev"] diff --git a/crypto/src/lib.rs b/crypto/src/lib.rs index 23821dd7..be642861 100644 --- a/crypto/src/lib.rs +++ b/crypto/src/lib.rs @@ -1,6 +1,3 @@ -#![cfg_attr(feature="clippy", feature(plugin))] -#![cfg_attr(feature="clippy", plugin(clippy))] - extern crate crypto as rcrypto; extern crate primitives; diff --git a/message/Cargo.toml b/message/Cargo.toml index e6810d06..cfc720c4 100644 --- a/message/Cargo.toml +++ b/message/Cargo.toml @@ -10,11 +10,3 @@ bitcrypto = { path = "../crypto" } chain = { path = "../chain" } primitives = { path = "../primitives" } serialization = { path = "../serialization" } - -[dependencies.clippy] -optional = true -version = "0.0.97" - -[features] -default = [] -dev = ["clippy", "primitives/dev", "serialization/dev"] diff --git a/message/src/lib.rs b/message/src/lib.rs index 51d53140..874cb91c 100644 --- a/message/src/lib.rs +++ b/message/src/lib.rs @@ -1,6 +1,3 @@ -#![cfg_attr(feature="clippy", feature(plugin))] -#![cfg_attr(feature="clippy", plugin(clippy))] - extern crate byteorder; extern crate bitcrypto as crypto; extern crate chain; diff --git a/p2p/Cargo.toml b/p2p/Cargo.toml index 8a85f480..9d48d3c9 100644 --- a/p2p/Cargo.toml +++ b/p2p/Cargo.toml @@ -19,11 +19,3 @@ primitives = { path = "../primitives"} bitcrypto = { path = "../crypto" } message = { path = "../message" } serialization = { path = "../serialization"} - -[dependencies.clippy] -optional = true -version = "0.0.97" - -[features] -default = [] -dev = ["clippy", "primitives/dev", "message/dev", "bitcrypto/dev"] diff --git a/p2p/src/lib.rs b/p2p/src/lib.rs index af571110..2b640099 100644 --- a/p2p/src/lib.rs +++ b/p2p/src/lib.rs @@ -1,6 +1,3 @@ -#![cfg_attr(feature="clippy", feature(plugin))] -#![cfg_attr(feature="clippy", plugin(clippy))] - #[macro_use] extern crate futures; extern crate futures_cpupool; diff --git a/pbtc/main.rs b/pbtc/main.rs index 7cd2c45b..31d2c6a5 100644 --- a/pbtc/main.rs +++ b/pbtc/main.rs @@ -1,8 +1,5 @@ //! Parity bitcoin client. -#![cfg_attr(feature="clippy", feature(plugin))] -#![cfg_attr(feature="clippy", plugin(clippy))] - #[macro_use] extern crate clap; #[macro_use] diff --git a/primitives/Cargo.toml b/primitives/Cargo.toml index 91028c50..0a23c670 100644 --- a/primitives/Cargo.toml +++ b/primitives/Cargo.toml @@ -6,11 +6,3 @@ authors = ["debris "] [dependencies] heapsize = "0.3" rustc-serialize = "0.3" - -[dependencies.clippy] -optional = true -version = "0.0.97" - -[features] -default = [] -dev = ["clippy"] diff --git a/primitives/src/lib.rs b/primitives/src/lib.rs index e18ce6cc..1f45ff3b 100644 --- a/primitives/src/lib.rs +++ b/primitives/src/lib.rs @@ -1,6 +1,3 @@ -#![cfg_attr(feature="clippy", feature(plugin))] -#![cfg_attr(feature="clippy", plugin(clippy))] - extern crate rustc_serialize; #[macro_use] extern crate heapsize; diff --git a/serialization/Cargo.toml b/serialization/Cargo.toml index ce12d9fa..1c77f18d 100644 --- a/serialization/Cargo.toml +++ b/serialization/Cargo.toml @@ -6,11 +6,3 @@ authors = ["debris "] [dependencies] byteorder = "0.5" primitives = { path = "../primitives" } - -[dependencies.clippy] -optional = true -version = "0.0.97" - -[features] -default = [] -dev = ["clippy", "primitives/dev"] diff --git a/serialization/src/lib.rs b/serialization/src/lib.rs index a5139bc3..3227b397 100644 --- a/serialization/src/lib.rs +++ b/serialization/src/lib.rs @@ -1,6 +1,3 @@ -#![cfg_attr(feature="clippy", feature(plugin))] -#![cfg_attr(feature="clippy", plugin(clippy))] - extern crate byteorder; extern crate primitives; diff --git a/serialization/src/reader.rs b/serialization/src/reader.rs index 6ff0aac0..51dacb61 100644 --- a/serialization/src/reader.rs +++ b/serialization/src/reader.rs @@ -114,7 +114,7 @@ impl Reader where R: io::Read { Ok(result) } - #[cfg_attr(feature="clippy", allow(wrong_self_convention))] + #[cfg_attr(feature="cargo-clippy", allow(wrong_self_convention))] pub fn is_finished(&mut self) -> bool { if self.peeked.is_some() { return false; diff --git a/tools/clippy.sh b/tools/clippy.sh new file mode 100755 index 00000000..f1b3b687 --- /dev/null +++ b/tools/clippy.sh @@ -0,0 +1,31 @@ +#!/bin/bash + +# NOTE! +# this script requires nightly version of rustc +# clippy plugin needs to be compiled with the same nigtly version as currently set one +# tested with clippy 0.0.98 + +# temporary workaround for cargo clippy issue #1330 +# https://github.com/Manishearth/rust-clippy/issues/1330 + +# first, let's enter any directory in a workspace with target kind `lib` +# https://github.com/Manishearth/rust-clippy/blob/6a73c8f8e3f513f6a16c6876be3d326633dbc78d/src/main.rs#L186 +cd primitives + +# now let's run clippy +# clippy does not support multiple packages, so let's run them one after another +cargo clippy -p bitcrypto +cargo clippy -p chain +cargo clippy -p db +cargo clippy -p ethcore-devtools +cargo clippy -p import +cargo clippy -p keys +cargo clippy -p message +cargo clippy -p miner +cargo clippy -p p2p +cargo clippy -p primitives +cargo clippy -p script +cargo clippy -p serialization +cargo clippy -p sync +cargo clippy -p verification + diff --git a/tools/test.sh b/tools/test.sh index d724578f..c176934e 100755 --- a/tools/test.sh +++ b/tools/test.sh @@ -1,18 +1,18 @@ #!/bin/bash cargo test\ + -p bitcrypto\ + -p chain\ -p db\ -p ethcore-devtools\ - -p chain\ - -p bitcrypto\ + -p import\ -p keys\ -p message\ -p miner\ + -p pbtc\ -p p2p\ -p primitives\ -p script\ -p serialization\ -p sync\ - -p import\ - -p pbtc\ -p verification