warning: unnecessary hashes around raw string literal
--> tests/test_display.rs:354:12
|
354 | assert(r#"raw brace left {"#, Error::BraceLeft);
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
= note: `-W clippy::needless-raw-string-hashes` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_raw_string_hashes)]`
help: remove all the hashes around the string literal
|
354 - assert(r#"raw brace left {"#, Error::BraceLeft);
354 + assert(r"raw brace left {", Error::BraceLeft);
|
warning: unnecessary hashes around raw string literal
--> tests/test_display.rs:355:12
|
355 | assert(r#"raw brace left 2 \x7B"#, Error::BraceLeft2);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
help: remove all the hashes around the string literal
|
355 - assert(r#"raw brace left 2 \x7B"#, Error::BraceLeft2);
355 + assert(r"raw brace left 2 \x7B", Error::BraceLeft2);
|
warning: unnecessary hashes around raw string literal
--> tests/test_display.rs:356:12
|
356 | assert(r#"raw brace right }"#, Error::BraceRight);
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
help: remove all the hashes around the string literal
|
356 - assert(r#"raw brace right }"#, Error::BraceRight);
356 + assert(r"raw brace right }", Error::BraceRight);
|
warning: unnecessary hashes around raw string literal
--> tests/test_display.rs:357:12
|
357 | assert(r#"raw brace right 2 \x7D"#, Error::BraceRight2);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
help: remove all the hashes around the string literal
|
357 - assert(r#"raw brace right 2 \x7D"#, Error::BraceRight2);
357 + assert(r"raw brace right 2 \x7D", Error::BraceRight2);
|
Compiler is unable to generate as efficient code for `write!(f, "text")` as it does for `f.write_str("text")`. This PR checks if the `#[error("text")]` uses a simple string literal without the `{` and `}` characters, and without arguments, and uses `write_str` if so.
error: variables can be used directly in the `format!` string
--> tests/test_expr.rs:44:43
|
44 | .map_or_else(String::new, |s| format!("; did you mean '{}'?", s)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
44 - .map_or_else(String::new, |s| format!("; did you mean '{}'?", s)),
44 + .map_or_else(String::new, |s| format!("; did you mean '{s}'?")),
|
warning: variables can be used directly in the `format!` string
--> tests/test_generics.rs:93:5
|
93 | assert_eq!(format!("{}", instance), "display only DebugOnly");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
93 - assert_eq!(format!("{}", instance), "display only DebugOnly");
93 + assert_eq!(format!("{instance}"), "display only DebugOnly");
|
warning: variables can be used directly in the `format!` string
--> tests/test_generics.rs:96:5
|
96 | assert_eq!(format!("{}", instance), "display only");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
96 - assert_eq!(format!("{}", instance), "display only");
96 + assert_eq!(format!("{instance}"), "display only");
|
warning: variables can be used directly in the `format!` string
--> tests/test_generics.rs:99:5
|
99 | assert_eq!(format!("{}", instance), "DebugOnly");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
99 - assert_eq!(format!("{}", instance), "DebugOnly");
99 + assert_eq!(format!("{instance}"), "DebugOnly");
|
warning: `thiserror` (test "test_generics") generated 3 warnings (run `cargo clippy --fix --test "test_generics"` to apply 3 suggestions)
warning: variables can be used directly in the `format!` string
--> tests/test_display.rs:129:20
|
129 | Some(n) => format!("error occurred with {}", n),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
129 - Some(n) => format!("error occurred with {}", n),
129 + Some(n) => format!("error occurred with {n}"),
|
warning: variables can be used directly in the `format!` string
--> tests/test_display.rs:153:32
|
153 | Some(n) => write!(formatter, "error occurred with {}", n),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
153 - Some(n) => write!(formatter, "error occurred with {}", n),
153 + Some(n) => write!(formatter, "error occurred with {n}"),
|
Rather than having separate traits implementing as_display method,
replace DisplayAsDisplay and PathAsDisplay traits with a AsDisplay
trait. The difference between those two traits is in the result
returned by the as_display method. With AsDisplay trait this is
captured by an associated type.
The main motivation for the change is making it simpler to support
no_std builds in the future. Previously, PathAsDisplay would have to
be handled specially in such builds on the side of macro expansion.
Now, thiserror-impl doesn’t need to be aware of any complications
around AsDisplay since they are all contained in thiserror crate.
Currently fails with:
error[E0034]: multiple applicable items in scope
--> tests/test_backtrace.rs:165:13
|
165 | x: std::io::Error,
| ^ multiple `provide` found
|
= note: candidate #1 is defined in an impl of the trait `Provider` for the type `E`
= note: candidate #2 is defined in an impl of the trait `std::error::Error` for the type `std::io::Error`
help: disambiguate the associated function for candidate #1
|
165 | Provider::provide(&x, Error): std::io::Error,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
help: disambiguate the associated function for candidate #2
|
165 | std::error::Error::provide(&x, Error): std::io::Error,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Conrado Gouvea
David Tolnay
Yuri Astrakhan
Maarten de Vries
Michal Nazarewicz