From cd20feb4841a04384d20fa83935d60fad2b2b1b0 Mon Sep 17 00:00:00 2001
From: Carl Lerche <me@carllerche.com>
Date: Thu, 26 Oct 2017 14:04:59 -0700
Subject: [PATCH] Misc small fixes (#23)

---
 Cargo.toml                   |  3 ---
 tower-route/Cargo.toml       |  5 ++++-
 tower-route/tests/route.rs   |  9 +++++----
 tower-util/src/service_fn.rs | 30 +-----------------------------
 4 files changed, 10 insertions(+), 37 deletions(-)

diff --git a/Cargo.toml b/Cargo.toml
index 1bff7ef..b94dab8 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -38,6 +38,3 @@ log = "0.3"
 env_logger = "0.4"
 tokio-timer = "0.1"
 futures-cpupool = "0.1"
-
-[replace]
-"futures:0.1.16" = { git = "https://github.com/carllerche/futures-rs", branch = "test-harness" }
diff --git a/tower-route/Cargo.toml b/tower-route/Cargo.toml
index 482ea45..c04de5e 100644
--- a/tower-route/Cargo.toml
+++ b/tower-route/Cargo.toml
@@ -6,4 +6,7 @@ authors = ["Carl Lerche <me@carllerche.com>"]
 [dependencies]
 futures = "0.1"
 tower = { version = "0.1", path = "../" }
-futures-borrow = { git = "https://github.com/carllerche/futures-borrow" }
+futures-borrow = { git = "https://github.com/carllerche/better-future" }
+
+[dev-dependencies]
+futures-test = { git = "https://github.com/carllerche/better-future" }
diff --git a/tower-route/tests/route.rs b/tower-route/tests/route.rs
index 349ed74..542fe7e 100644
--- a/tower-route/tests/route.rs
+++ b/tower-route/tests/route.rs
@@ -1,4 +1,5 @@
 extern crate futures;
+extern crate futures_test;
 extern crate tower;
 extern crate tower_route;
 
@@ -7,14 +8,14 @@ use tower_route::*;
 
 use futures::*;
 use futures::future::FutureResult;
-use futures::executor::TestHarness;
+use futures_test::Harness;
 
 use std::collections::HashMap;
 
 macro_rules! assert_ready {
     ($service:expr) => {{
         let s = $service;
-        let mut t = TestHarness::new(future::poll_fn(|| s.poll_ready()));
+        let mut t = Harness::poll_fn(|| s.poll_ready());
         assert!(t.poll().unwrap().is_ready());
     }};
 }
@@ -22,7 +23,7 @@ macro_rules! assert_ready {
 macro_rules! assert_not_ready {
     ($service:expr) => {{
         let s = $service;
-        let mut t = TestHarness::new(future::poll_fn(|| s.poll_ready()));
+        let mut t = Harness::poll_fn(|| s.poll_ready());
         assert!(!t.poll().unwrap().is_ready());
     }};
 }
@@ -80,7 +81,7 @@ fn inner_service_not_ready() {
     let mut service = Route::new(recognize);
 
     let resp = service.call("two".into());
-    let mut resp = TestHarness::new(resp);
+    let mut resp = Harness::new(resp);
     assert!(!resp.poll().unwrap().is_ready());
 
     assert_not_ready!(&mut service);
diff --git a/tower-util/src/service_fn.rs b/tower-util/src/service_fn.rs
index fb698ce..2511d88 100644
--- a/tower-util/src/service_fn.rs
+++ b/tower-util/src/service_fn.rs
@@ -1,8 +1,6 @@
-use futures::{IntoFuture, Poll};
+use futures::IntoFuture;
 use tower::{Service, NewService};
 
-use std::marker::PhantomData;
-
 /// A `NewService` implemented by a closure.
 pub struct NewServiceFn<T> {
     f: T,
@@ -36,29 +34,3 @@ where T: Fn() -> R,
         (self.f)().into_future()
     }
 }
-
-#[cfg(test)]
-mod test {
-    use super::*;
-    use futures::{future, Future};
-    use std::rc::Rc;
-
-    #[test]
-    fn smoke() {
-        fn f<T>(service: &mut T)
-        where T: Service<Request = u32,
-                        Response = Rc<u32>,
-                        Error = ()> + Sync
-        {
-            let resp = service.call(123);
-            assert_eq!(*resp.wait().unwrap(), 456);
-        }
-
-        let mut service = ServiceFn::new(|request| {
-            assert_eq!(request, 123);
-            future::ok(Rc::new(456))
-        });
-
-        f(&mut service);
-    }
-}