From 4dbea96a3501c548ad04b85d736e4732688d8b9e Mon Sep 17 00:00:00 2001
From: Vamsi Krishna B <vamsi@fastmail.com>
Date: Tue, 20 Jul 2021 19:04:20 +0530
Subject: [PATCH] Few usability improvements - TX confirmations, fix TX inputs
 on mobile view

---
 .../controllers/page_controller.ex            |  4 +++
 .../live/raw_mempool_live.ex                  |  6 +---
 lib/zcash_explorer_web/router.ex              |  1 +
 .../templates/layout/app.html.eex             |  4 +--
 .../templates/page/nodes.html.eex             |  8 +++++
 .../templates/transaction/tx.html.eex         | 34 ++++++++-----------
 6 files changed, 31 insertions(+), 26 deletions(-)
 create mode 100644 lib/zcash_explorer_web/templates/page/nodes.html.eex

diff --git a/lib/zcash_explorer_web/controllers/page_controller.ex b/lib/zcash_explorer_web/controllers/page_controller.ex
index 4412aa9..9774830 100644
--- a/lib/zcash_explorer_web/controllers/page_controller.ex
+++ b/lib/zcash_explorer_web/controllers/page_controller.ex
@@ -74,4 +74,8 @@ defmodule ZcashExplorerWeb.PageController do
   def mempool(conn, _params) do
     render(conn, "mempool.html", page_title: "Zcash Mempool")
   end
+
+  def nodes(conn, _params) do
+    render(conn, "nodes.html", page_title: "Zcash Nodes")
+  end
 end
diff --git a/lib/zcash_explorer_web/live/raw_mempool_live.ex b/lib/zcash_explorer_web/live/raw_mempool_live.ex
index f202a3e..cac56d8 100644
--- a/lib/zcash_explorer_web/live/raw_mempool_live.ex
+++ b/lib/zcash_explorer_web/live/raw_mempool_live.ex
@@ -3,7 +3,7 @@ defmodule ZcashExplorerWeb.RawMempoolLive do
 
   def render(assigns) do
     ~L"""
-  <div class="shadow overflow-hidden border-b border-gray-200 rounded-lg overflow-x-auto">
+    <div class="shadow overflow-hidden border-b border-gray-200 rounded-lg overflow-x-auto">
     <table class="min-w-full divide-y divide-gray-200">
       <thead class="bg-white-500">
       <tr>
@@ -12,7 +12,6 @@ defmodule ZcashExplorerWeb.RawMempoolLive do
           <th scope="col" class="px-4 py-3 text-left text-xs font-medium text-midnight-500 uppercase tracking-wider">Time</th>
           <th scope="col" class="px-4 py-3 text-left text-xs font-medium text-midnight-500 uppercase tracking-wider">Fee</th>
           <th scope="col" class="px-4 py-3 text-left text-xs font-medium text-midnight-500 uppercase tracking-wider">Size</th>
-          <th scope="col" class="px-4 py-3 text-left text-xs font-medium text-midnight-500 uppercase tracking-wider">Currentpriority</th>
         </tr>
        </thead>
        <tbody class="bg-white-500 divide-y divide-gray-200">
@@ -35,9 +34,6 @@ defmodule ZcashExplorerWeb.RawMempoolLive do
         <td class="px-4 py-4 whitespace-nowrap text-sm font-medium text-gray-500 hover:text-gray-600">
           <%= tx["info"]["size"] %>
         </td>
-        <td class="px-4 py-4 whitespace-nowrap text-sm font-medium text-gray-500 hover:text-gray-600">
-         <%= tx["info"]["currentpriority"] %>
-        </td>
        </tr>                                           
       <% end %>
     </tbody>
diff --git a/lib/zcash_explorer_web/router.ex b/lib/zcash_explorer_web/router.ex
index 773ed65..d9feaec 100644
--- a/lib/zcash_explorer_web/router.ex
+++ b/lib/zcash_explorer_web/router.ex
@@ -38,6 +38,7 @@ defmodule ZcashExplorerWeb.Router do
     get "/search", SearchController, :search
     get "/blocks", BlockController, :index
     get "/mempool", PageController, :mempool
+    get "/nodes", PageController, :nodes
   end
 
   # Other scopes may use custom stacks.
diff --git a/lib/zcash_explorer_web/templates/layout/app.html.eex b/lib/zcash_explorer_web/templates/layout/app.html.eex
index 4fc5a85..1c513c3 100644
--- a/lib/zcash_explorer_web/templates/layout/app.html.eex
+++ b/lib/zcash_explorer_web/templates/layout/app.html.eex
@@ -6,12 +6,12 @@
             <div class="flex items-center px-2 lg:px-0 xl:w-64">
               <a href="/">
                 <div class="flex-shrink-0">
-                    <img class="h-8 w-auto" src="<%= Routes.static_path(@conn, "/images/zcash-icon-white.svg") %>" alt="Zcash Explorer">
+                    <img class="h-8 w-auto" src="<%= Routes.static_path(@conn, "/images/zcash-icon-white.svg") %>" alt="Block Explorer">
                 </div>
               </a>
                 <a href="/">
                 <div class="flex-shrink-0 px-1 text-white">
-                    Zcash Explorer
+                    Block Explorer
                 </div>
               </a>
             </div>
diff --git a/lib/zcash_explorer_web/templates/page/nodes.html.eex b/lib/zcash_explorer_web/templates/page/nodes.html.eex
new file mode 100644
index 0000000..254ab31
--- /dev/null
+++ b/lib/zcash_explorer_web/templates/page/nodes.html.eex
@@ -0,0 +1,8 @@
+<main class="py-4">
+<div class="grid grid-cols-1 mx-8">
+ <h3 class="text-lg leading-6 font-medium text-gray-500 py-2">
+        Zcash Nodes
+ </h3>
+    <%= live_render(@conn, ZcashExplorerWeb.RawMempoolLive) %>
+</div>
+</main>
\ No newline at end of file
diff --git a/lib/zcash_explorer_web/templates/transaction/tx.html.eex b/lib/zcash_explorer_web/templates/transaction/tx.html.eex
index 1550b51..4a586d4 100644
--- a/lib/zcash_explorer_web/templates/transaction/tx.html.eex
+++ b/lib/zcash_explorer_web/templates/transaction/tx.html.eex
@@ -11,27 +11,13 @@
           </div>
           <div class="border-t border-gray-200 px-4 py-5 sm:px-6">
             <dl class="grid grid-cols-1 gap-x-4 gap-y-8 sm:grid-cols-3">
-              <div class="sm:col-span-2">
-                <dt class="text-sm font-medium text-gray-500">
-                Hash (txid)
-                </dt>
-                <dd class="mt-1 text-sm text-gray-900 break-words">
-                <%= @tx.txid %>
-                </dd>
-              </div>
-              <div class="sm:col-span-1">
-                <dt class="text-sm font-medium text-gray-500">
-                Time (UTC)
-                </dt>
-                <dd class="mt-1 text-sm text-gray-900">
-                <%= ZcashExplorerWeb.BlockView.mined_time(@tx.time) %>
-                </dd>
-              </div>
+
+
               <div class="sm:col-span-1">
                 <dt class="text-sm font-medium text-gray-500">
                 Confirmations
                 </dt>
-                <dd class="mt-1 text-sm text-gray-900">
+                <dd class="mt-1 text-xl font-black text-gray-900">
                 <%= if @tx.confirmations == nil do %>
                 0
                 <% else %>
@@ -40,6 +26,16 @@
 
                 </dd>
               </div>
+
+              <div class="sm:col-span-1">
+                <dt class="text-sm font-medium text-gray-500">
+                Time (UTC)
+                </dt>
+                <dd class="mt-1 text-sm text-gray-900">
+                <%= ZcashExplorerWeb.BlockView.mined_time(@tx.time) %>
+                </dd>
+              </div>
+
               
               <div class="sm:col-span-1">
                 <dt class="text-sm font-medium text-gray-500">
@@ -106,7 +102,7 @@
               </div>
               <div class="sm:col-span-1">
                 <dt class="text-sm font-medium text-gray-500">
-                size
+                Size (bytes)
                 </dt>
                 <dd class="mt-1 text-sm text-gray-900">
                 <%= @tx.size %>
@@ -149,7 +145,7 @@ Inputs (<%= vin_count(@tx.vin) %>)
           <li class="pl-3 pr-4 py-3 flex items-center justify-between text-sm">
             <div class="w-0 flex-1 flex items-center">
               <a href='/address/<%= input.address %>'>
-            <span class="ml-2 flex-1 w-0 truncate break-all">
+            <span class="flex-1 w-0 break-all">
             <%= input.address %>
             </span>
           </a>