* switch to MSVC, fixes to support it
* fix linking errors
* document how to patch zcash source
* update hash due to nightly breakage; don't use deprecated bindgen function
* update patch with str4d's upstream suggestion
---------
Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com>
* Update dependencies to match zcashd v5.5.0
* Update dependencies to match Zebra main branch
* Update release instructions
* Add module docs for the build script to avoid warnings
* Update bridge file list to match the latest zcashd
* Ignore some emacs temporary files
* Standardise directory include paths in Cargo.toml
* Add extra info to cxx_gen errors
* Add additional Rust dependencies needed to compile
* Ignore some expected clippy lints
* Silence a C compiler macro redefinition warning
* Standardise directory paths in build.rs
* fix cxxbridge code generation
* Update Cargo.lock
* Use include!() for bridge.rs
* Add a changelog entry for the next release
* Fix a warning by adding docs for the crate
* Remove previous depend/zcash
* Squashed 'depend/zcash/' content from commit eb80047476
git-subtree-dir: depend/zcash
git-subtree-split: eb80047476e9c0db3524f647d412faf8d4a584ee
* Update depend/zcash to v5.5.0
```sh
git subtree add -P depend/zcash https://github.com/zcash/zcash.git v5.5.0 --squash
git rm depend/zcash/Cargo.toml
```
---------
Co-authored-by: Conrado Gouvea <conradoplg@gmail.com>
* delete previous version
* Squashed 'depend/zcash/' content from commit f98166f7f5
git-subtree-dir: depend/zcash
git-subtree-split: f98166f7f556ee9b9f597d45275c32843a87b0b6
* update to zcash 5.2.0
* remove Windows support for now, see #38
A helper function to configure the build's language standard and to
automatically enable or disable C++ support. This allows moving some
more code out of `main`, but it is also preparing for running more than
one build, for splitting the `secp256k1` library.
Move some more code out from the `main` function to keep it easier to
read. Also renamed the function so that it better conveys that it's a
check returning a `bool`.
* Squashed 'depend/zcash/' changes from d94fe7678..fa1a57867
fa1a57867 zcash_script: Add API to verify scripts with precomputed tx data
c81adc371 Auto merge of #4979 - nuttycom:upstream_siphash, r=str4d
cfc4ca181 Use SipHash-2-4 for address relay selection
407532d84 Switch CTxMempool::mapTx to use a hash index for txids
ec4196d8c Use SipHash-2-4 for CCoinsCache index
f3b2cdb32 Add SipHash-2-4 primitives to hash
a960e896d Auto merge of #4966 - str4d:zcash-script-lib, r=nuttycom
090e284f5 Auto merge of #4964 - str4d:univalue-update, r=nuttycom
cc5574b81 Auto merge of #4963 - defuse:fix-updatecheck-token, r=nuttycom
b9504dbb3 Auto merge of #4967 - LarryRuane:upstream-lockfixes, r=nuttycom
dc94d7605 Auto merge of #4968 - str4d:design-book, r=str4d
fecde3de1 Link to zips.z.cash for protocol spec
aec304d7a Show README as root of zcashd book
9cee5686b Actions: Add a workflow to deploy the zcashd book
8cfbabd6e Set up an mdbook in which we can document zcashd's architecture design
898226545 Fix unlocked access to vNodes.size()
6da9ecda0 Remove double brackets in addrman
5123af41d Fix AddrMan locking
e78376b4f Make fImporting an std::atomic
e286250ce Make fDisconnect an std::atomic
90232f65a Rename libzcashconsensus.la -> libzcash_script.la
ea8065917 Rename zcashconsensus_* -> zcash_script_* in APIs
c5e7b84e9 Rename src/script/zcashconsensus.* -> src/script/zcash_script.*
308bb1083 Add amount and consensus branch ID to zcashconsensus_verify_script
2e4edc507 Remove crypto/equihash from libzcashconsensus
92da71b0f Document the required .updatecheck-token file in the release docs
ce5d8daae Auto merge of #4961 - str4d:leveldb-1.22-prep, r=str4d
82b40d080 scripted-diff: Use UniValue.pushKV instead of push_back(Pair())
36e86d3c6 Merge commit '9e26ae1c78fe62e23dcca7b22e1cd1a42b45dd25' into univalue-update
7580890dc Auto merge of #4959 - str4d:dependency-updates, r=str4d
45392c221 Move the github API token out of updatecheck.py into an untracked file.
9e26ae1c7 Squashed 'src/univalue/' changes from 9ef5b78c1..98fadc090
3e672a58a Define TARGET_OS when host is android
b2f919213 Auto merge of #4754 - daira:fix-enable-debug, r=str4d
bd61fbf05 Ensure that `CONFIGURE_FLAGS=--enable-debug` correctly uses -O0 for dependencies and main build.
959e7be47 build: add missing leveldb defines
5d8fdbf73 [build] Add NETBSD leveldb target to configure.ac
5304bcd6b build: Updates for OpenBSD
f5d8c9338 Re-instate TARGET_OS=linux in configure.ac. Removed by 351abf9e035.
780e35419 cargo update
177df2c25 depends: Postpone updates that require adding CMake
4c7d17328 depends: ZeroMQ 4.3.4
07449c1a0 QA: Postpone BDB update again
bb242b6a7 QA: Remove unused update postponements
3e35bc8e7 qa: Postpone Boost and native_b2 updates
c996fc1ca Revert "Update boost to 1.75, postpone other updates."
c27870551 Auto merge of #4956 - str4d:clang-11-macos-build, r=str4d
d0902ab76 depends: Ensure the native_clang download path is for the builder
c7df8445d depends: Allow per-host package download paths
2de905ce8 Auto merge of #4951 - str4d:clang-11, r=nuttycom
fa41e9adc depends: Fix Boost warnings under Clang 11
a58d74c6b depends: Move to Clang 11
a0158ce83 Auto merge of #4950 - str4d:boost-build-backports, r=str4d
98ce8f838 depends: boost: Specify cflags+compileflags
cf70d2eb5 depends: boost: Remove unnecessary _archiver_
80205dcad depends: boost: Cleanup toolset selection
7f1598ad1 depends: boost: Cleanup architecture/address-model
44f95d404 depends: boost: Disable all compression
d5dfbe016 depends: boost: Split into non-/native packages
63390e503 depends: boost: Refer to version in URL
5c03db098 depends: Propagate only specific CLI variables to sub-makes
9e997afd8 depends: boost: Use clang toolset if clang in CXX
96cf6da5b depends: boost: Split target-os from toolset
b3fe7d336 depends: boost: Specify toolset to bootstrap.sh
2c1c82f59 depends: Propagate well-known vars into depends
0226ea464 depends: Consistent use of package variable
d64205350 depends: fix boost mac cross build with clang 9+
ee10eb77d build: Add variable printing target to Makefiles
06d234d77 Auto merge of #4934 - oxarbitrage:issue4917, r=nuttycom
4698523c3 Auto merge of #4936 - oxarbitrage:issue4932, r=nuttycom
ada04aa01 Fix pyflakes complaints
93d1aec9f Auto merge of #4935 - LarryRuane:4624-ibd-getheaders, r=nuttycom
e034e2676 Apply suggestions from code review
ab5577618 hide password in -stdin `walletpassphrase` command
e528caf7f Auto merge of #4937 - centromere:freebsd, r=daira
addf0b331 #4624 improve IBD sync by eliminating getheaders requests
8c000ae28 Auto merge of #4944 - nuttycom:ibd_skip_tx_messages, r=str4d
2e36d4208 Use parentheses for defined in windows-unused-variables.diff
feadf83de Auto merge of #4942 - str4d:rust-1.49, r=str4d
a0c1ba16d Set rust_target for all FreeBSD versions
5094a8b63 Auto merge of #4924 - daira:update-updatecheck, r=str4d
0bc90167f Skip "tx" messages during initial block download.
cea97a713 Auto merge of #4938 - sandakersmann:master, r=str4d
1614f1ebd Auto merge of #4913 - str4d:zcashconsensus-fixes, r=nuttycom
674fc8eb6 depends: cargo update
79f531c48 rust: Use renamed broken_intra_doc_links lint
070d4720e depends: Update Rust to 1.49.0
ae4ad8fc4 Update of copyright year to 2021
4660e85dd Update COPYRIGHT_YEAR in clientversion.h to 2021
61955934b Update _COPYRIGHT_YEAR in configure.ac to 2021
eadc3d48f Add support for FreeBSD 12
77db54764 split wallet.py tests
c07007ffc Auto merge of #4931 - rex4539:discord-invite, r=daira
74bd17fb2 Discord invite instead of direct link
b812c3ad9 Auto merge of #4928 - nuttycom:release-v4.2.0, r=daira
993feb59f make-release.py: Updated release notes and changelog for 4.2.0.
a6eb9fc7d make-release.py: Updated manpages for 4.2.0.
c75e663c2 make-release.py: Versioning changes for 4.2.0.
f63bfc5a2 Auto merge of #4927 - daira:mempool-limit-test-fix, r=daira
66fe7a378 Revert changes in #4916 that assumed arguments represent fees, when they are actually number of confirmations.
2c17d1e27 Store inputs and outputs by reference in JSDescriptionInfo
6c280abfa Remove init_and_check_sodium from crypto/common.h
c4ea42382 prevector: Terminate without logging on failed allocation
79ad5984b Remove JSDescription::h_sig
b1aa9365a Add JSDescriptionInfo for constructing JSDescriptions
726c5c8b1 Default to defining endian-conversion DECLs in compat w/o config
9bfcba933 gtest/test_mempoollimit: the test failed to properly ensure that the "low fee penalty" threshold matches the new ZIP 313 fee.
651e7fbfb Auto merge of #4923 - nuttycom:release-v4.2.0-rc1, r=nuttycom
86aa5d387 qa/zcash/updatecheck.py: remove dead code; print instructions to run `cargo outdated` and `cargo update`.
a0dd3e3ce make-release.py: Updated release notes and changelog for 4.2.0-rc1.
0b5b6d518 make-release.py: Updated manpages for 4.2.0-rc1.
f8bb085d8 make-release.py: Versioning changes for 4.2.0-rc1.
6fbf180b3 Auto merge of #4921 - nuttycom:fix_stdout_logging, r=str4d
8cdac686e Don't log to stdout if a file logger is configured.
c854ff774 Auto merge of #4919 - rex4539:old-boost, r=daira
2c0f6df16 Auto merge of #4916 - daira:reduce-fee, r=nuttycom
c2c69a12e Remove workaround affecting old Boost version
6771bef6d Auto merge of #4918 - str4d:update-deps, r=daira
e6a44ff83 Always allow transactions paying at least DEFAULT_FEE to be relayed, and do not rate-limit them. In other words, make sure that the "minimum relay fee" is no greater than DEFAULT_FEE.
8f4dd4460 Update boost to 1.75, postpone other updates.
5dce316f1 tracing: Simplify init logic using optional layers
c97665f39 tracing: Remove unnecessary tracing_init_inner internal function
bdf44b1cf cargo update
5e8436270 Reduce the default fee for z_* operations, and the "low fee penalty" threshold for mempool limiting, to 1000 zatoshis.
844ef48b4 Auto merge of #4912 - daira:daira-partial-revert-4904, r=daira
4fedb3244 Fix a typo introduced in #4904.
7a97e48cb Auto merge of #4909 - str4d:improve-logging, r=str4d
dea50714f Auto merge of #4892 - str4d:boosted, r=str4d
2840790f6 Partial revert of "Update links". See #4904
a05819614 Auto merge of #4603 - nuttycom:ff/no_global_params, r=daira
a8bcd46b8 test: Fix test_bitcoin compilation on macOS High Sierra
5b97cd27f Auto merge of #4904 - rex4539:https, r=nuttycom
bce1da684 Remove vestigial OSX_SDK_VERSION from darwin build.
f201e1e02 build: set minimum supported macOS to 10.14
8a1803b21 lint: Remove boost::variant and boost::optional from allowed includes
db17aae4d Finish migrating to std::optional
d8d091895 scripted-diff: Migrate from boost::optional to std::optional
521eb81a9 Add <optional> header to files that will need it
d9928926f Migrate from boost::optional::get to boost::optional::value
ae4551004 Finish migrating to std::variant
b521cb893 scripted-diff: Migrate from boost::variant to std::variant
f68c79554 Add <variant> header to files that will need it
83a4ae49b Auto merge of #4886 - LarryRuane:getblocktemplate-shielded, r=str4d
8239c756b mempool: Log all accepted txids at INFO level
a5736aad9 rpc: Log the new filter when we set it
b517be433 rpc: Reload CNode spans after reloading the log filter
42c38b00c net: Rework CNode spans
e9b5d8370 Prefer explicit passing of CChainParams to the Params() global.
5f68253e5 improve getblocktemplate performance for shielded coinbase
f459e43dc Update links
e9cc9b4ee Auto merge of #4896 - nuttycom:document_nsequence, r=daira
e7b425298 Auto merge of #4893 - str4d:ed25519-zebra-consensus, r=daira
ceccb10e4 Update minimum chain work and set activation block hashes for testnet
28e01d67f Update minimum chain work and set activation block hashes for mainnet
4ca2b2049 test: Use ed25519_verify in ConsensusTests
5ab69760c Auto merge of #4891 - zquestz:add_hex_to_getblock, r=daira
2e9bdc678 Write down the folklore about nSequence
7dbd969b1 Auto merge of #4882 - rex4539:fix-readelf, r=daira
307dd8837 Fix readelf configuration
36838ef60 Auto merge of #4889 - LarryRuane:getinfo-add-build-version, r=LarryRuane
c3a91be47 Switch to ed25519-zebra for consensus signature checks
77c2a5f81 Auto merge of #4877 - str4d:boost-backports, r=str4d
4cb31e5a1 Fix Hungarian notation nit from Daira
efb603557 Include transaction hex in verbose getblock output
18775308f add more version information to getinfo rpc
c8896f990 Auto merge of #4874 - str4d:rpc-tests-py, r=str4d
a7370b112 test: Run shielding-heavy RPC tests in serial
3a91bcfac test: Silence pyflakes unused import warning
21bfa3a0e readelf is Linux only
e03667b60 lint: Remove boost/foreach.hpp from allowed includes
ed5c647b4 refactor: Drop boost::this_thread::interruption_point and boost::thread_interrupted in main thread
8e2d9a78f gui: get special folder in unicode
1ffd2d5fa util: Replace boost::signals2 with std::function
df3b6684f clang-format: Delete ForEachMacros
c3983ccb1 scripted-diff: Remove #include <boost/foreach.hpp>
62114cff9 scripted-diff: Remove BOOST_REVERSE_FOREACH
e8b5d36ee Fix const_reverse_iterator constructor (pass const ptr)
46509b99f Introduce src/reverse_iterator.hpp and include it...
f5e98e0fb scripted-diff: Remove PAIRTYPE
92a867feb scripted-diff: Fully remove BOOST_FOREACH
32433c2ba Small preparations for Q_FOREACH, PAIRTYPE and #include <boost/foreach.hpp> removal
5a82dd081 Add autocomplete to bitcoin-qt's console window.
21a7ec8bf test: Run rpc-tests.py in full_test_suite.py
891fbff5b test: Adjust some Zcash RPC tests to work with parallel runner
01449d8a3 qa: Set correct path for binaries in rpc tests
bc644280b Add exclude option to rpc-tests.py
32249fb5b [qa][doc] Correct rpc test options in readme
b18c43746 [trivial] Add tests_config.ini to .gitignore
4f4f8d5ad Various review markups for rpc-tests.py improvements
6aad43b63 Refactor rpc-tests.py
cc099b3b7 Improve rpc-tests.py arguments
389b70caf Use argparse in rpc_tests.py
41c2bc1e0 Use configparser in rpc-tests.py
2eab4f750 remove obsolete run-bitcoind-for-test.sh
3accdb2fc Reorder RPC tests for running time
8b3c39ea8 [qa] rpc-tests: Apply random offset to portseed
0a73a0fbd [qa] test_framework: Exit when tmpdir exists
d014a3056 [qa] pull-tester: Only print output when failed
bcbf03ebe [qa] Refactor RPCTestHandler to prevent TimeoutExpired
352f2dc54 [qa] create_cache: Delete temp dir when done
2d90c8f0d [doc] - clarify statement about parallel jobs in rpc-tests.py
4500a7534 [qa] pull-tester: Don't mute zmq ImportError
e4d1dcc75 [qa] Remove unused code
b25a63593 [qa] Use single cache dir for chains
dbb41d108 [qa] Adjust timeouts for micro-optimization of run time
1b3866fd0 [qa]: enable rpcbind_test
3c7f4ca80 [qa]: add parsing for '<host>:<port>' argument form to rpc_url()
2fc450d94 [doc] Add OS X ZMQ requirement to QA readme
7366e8137 [qa] pull-tester: Start longest test first
fd7689ff0 [qa] pull-tester: Fix assertion and check for run_parallel
63a3c9ace [qa] test_framework: Use different rpc_auth_pair for each node
ecf9d8eb2 build: a few ugly hacks to get the rpc tests working out-of-tree
2399cfc7b Tests: add timeout to sync_blocks() and sync_mempools()
17caf1ddd [qa] test_framework: Append portseed to tmpdir
818d2de39 [qa] Remove hardcoded "4 nodes" from test_framework
5a12bc9d8 [qa] Add option --portseed to test_framework
cbe91ea85 [qa] pull-tester: Run rpc test in parallel
0d8a62925 [qa] pull-tester: Adjust comment
5f13446de [qa] Stop other nodes, even when one fails to stop
065255d3c [qa] Update README.md
08256c9ec [qa] Refactor test_framework and pull tester
15721275d [qa] Switch to py3
d362b632b [qa] rpc-tests: Fix link in comment and label error msg
cc4436831 [qa] pull-tester: Exit early when no tests are run
e7a6c49c0 [qa] pull-tester: Don't mute zmq ImportError
db761077e [qa] mininode: Catch exceptions in got_data
7108d6aaa [qa] rpc-tests: Properly use integers, floats
65a6249d4 [qa] Use python2/3 syntax
845b31a76 Check if zmq is installed in tests, update docs
239857d7d test: don't override BITCOIND and BITCOINCLI if they're set
fb1f76f33 [qa] pull-tester: Cleanup (run keypool, tidy stdout)
db27db2e4 [qa] keypool: DRY: Use test framework
fa44509d6 [qa] keypool: Fix white space to prepare transition to test framework
01c36295c [qa] Extend README.md
80b2274dd [qa] Split README.md to /qa and /qa/rpc-tests
800bf0a45 Remove unmaintained example test script_test.py
eaf4dfe28 Add basic coverage reporting for RPC tests
583263553 build: don't distribute tests_config.py
760e50081 [rpc-tests] Check return code
6aa4f19e8 [rpc-tests] fundrawtransaction: Update fee after minRelayTxFee increase
480f1bf43 Add tests for gettxoutsetinfo, CLevelDBBatch, CLevelDBIterator
8e58eddab [doc] trivial: fix markdown syntax in qa/rpc-tests/README.md
661858019 qa/pull-tester/rpc-tests.py: chmod 0755
772d78073 Migrated rpc-tests.sh to all python rpc-tests.py
4761c9f2b Add p2p-fullblocktest.py
95d1f887c Fix crash when mining with empty keypool.
877212414 Auto merge of #4745 - nathan-at-least:autoconf-require-prog, r=str4d
da081de35 configure.ac: Introduce macros to simplify requiring tools.
bf70e357c Auto merge of #4553 - oxarbitrage:issue4356, r=daira
9a5f9bf5e Merge branch 'master' into issue4356
10b09d483 Auto merge of #4793 - str4d:faster-rpc-tests, r=str4d
949fdca3a Auto merge of #4873 - str4d:rpc-test-blocks, r=str4d
2cc836680 Auto merge of #4843 - furszy:2020_improving_sendmany_redudant_loops_first_round, r=daira
044ff5716 test: Re-enable regtest difficulty adjustment for unit tests that use it
e3974db2d Auto merge of #4870 - mdr0id:canopy_smoke_tests_update, r=str4d
a7f9365fb test: Set hashFinalSaplingRoot default correctly in create_block
030a68539 test: Fix SignatureHash RPC test helper
bbed3ecc3 test: Remove FindAndDelete from RPC test framework
8bc0a591a Revert "remove SignatureHash from python rpc tests"
aead91419 [doc][trivial] no retargeting in regtest mode
03f1d38e0 Added fPowNoRetargeting field to Consensus::Params that disables nBits recalculation.
20dd32fe9 Auto merge of #4871 - rex4539:typos, r=str4d
31e220a31 Fix typo
4dc94c954 Update expected fails for Sprout txns flows on Canopy
33fdb1b4b Auto merge of #4868 - daira:clean-removes-lib, r=str4d
6d856869e Auto merge of #4869 - zcash:release-v4.1.1, r=nuttycom
251405491 Add notable changes to release notes for v4.1.1
7ec8a9c5f make-release.py: Updated release notes and changelog for 4.1.1.
092829cf5 make-release.py: Updated manpages for 4.1.1.
142328b06 make-release.py: Versioning changes for 4.1.1.
f6fc97f35 Windows cross-build generates .lib files, which should be ignored by git and removed by clean.
9248cd743 Auto merge of #4864 - daira:go-faster, r=daira
61ebef409 Auto merge of #4865 - nuttycom:fix/shielded_coinbase_fr_rpc_fields, r=str4d
c8a90d9b9 Update getblocktemplate documentation.
1a8916794 Document how to get block subsidy information in getblocktemplate.
d107cf13b Correctly report founder's reward amount in getblocktemplate prior to Canopy
a0a87ab41 Set release CFLAGS/CXXFLAGS to use -O3.
0ccc88537 Auto merge of #4863 - nuttycom:fix/ibd_flag_check_order, r=daira
b5ad4cfc5 Change order of checks to skip IsInitialBlockDownload check if flag is unset.
2be143a20 sendmany::find_unspent_notes removing an unneeded recursive lock, GetFilteredNotes is already locking cs_main and cs_wallet.
b4e6353f2 asyncOp sendmany: moved inputs total amount check inside load_utxo before the dust validation.
ca9fc49fc rpc_wallet_tests: changed "Insufficient funds" error message to a proper "Insufficient transparent funds". This is because we are now throwing the insufficient transparent balance rpc error inside load_utxo.
3a1b51900 Improving asyncoperation_sendmany, removing another redundant for loop over all of the available utxos.
2c7b08029 sendmany operation: Creating TxValues struct to store the transaction values in a more organized manner.
a9f331587 move-only: asyncOp_sendmany, target amount calculation moved before find inputs (utxos and notes).
88eef5658 sendmany: removing now unused SendManyInputUTXO class.
726daeee4 asyncRPCOperation_sendmany:find_utxos, removing a redundant loop over all of the available utxo in the wallet.
c84390279 COutput: implemented Value() method.
d8e154ebf wallet:COutput adding fIsCoinbase member.
a1b7cd4b0 sendmany::find_utxo removing an unneeded recursive lock, AvailableCoins is already locking cs_main and cs_wallet.
359a05d6a wallet:AvailableCoins filter by destination/s feature implemented + connected to sendmany async operation.
4007e24ed asyncrpcoperation_sendmany::find_utxos removing a redundant coinbase check, coinbases are already being filtered by the AvailableCoins flag.
fbfb2c033 wallet:AvailableCoins nMinDepth filter implemented + connected to sendmany async operation.
e4e9712d0 wallet:AvailableCoins fOnlySpendable filtering flag implemented + connected to sendmany async operation.
ac792a394 Auto merge of #4860 - daira:clarify-meantarget, r=daira
4d16bfd18 GetNextWorkRequired: clarify why this computation is equivalent to that in the protocol spec. refs https://github.com/zcash/zips/pull/418
6c43a57e7 test: Use default shielded address in RPC tests where the type is irrelevant
5c47b9bb0 Auto merge of #4852 - str4d:cargo-update, r=str4d
120b184d8 cargo update
091f5d781 Auto merge of #4851 - adityapk00:mining_fix, r=str4d
7732b9aff Don't compile ehHashState::* if mining is disabled
60331b9e8 Auto merge of #4574 - oxarbitrage:issue4475, r=daira
5701095c2 Wording improvements to getrawtransaction RPC documentation
caed4adf5 Auto merge of #4849 - str4d:lint-fixes, r=str4d
e531d7233 doc: Adjust subtree developer notes to refer to Zcash
399ab8afa lint: Fix minor shellcheck lints
6b63fdd65 lint: s/trim/lenTrim in src/crypto/equihash.[cpp,h]
25dafc387 lint: Apply include guard style to src/rust/include
e6b1d4417 lint: Re-exclude subtrees from lint-include-guards.sh
dbfb3565d lint: Opt out of locale dependence in Zcash shell scripts
7c4b19fa4 lint: Use consistent shebangs
337e528d3 python: Explicitly set encoding to utf8 when opening text files
1944eb1c8 lint: Fix duplicate includes
d0a5343da lint: Fix missing or inconsistent include guards
c0c05ebb3 doc: improve subtree check instructions
9069364e5 [linter] Strip trailing / in path for git-subtree-check
cff7e776b Revert "Remove unused variable in shell script"
eb074fdb2 Improve git-subtree-check.sh
52d985403 Remove unused variables in shell scripts.
92633fdc3 uint256: replace sprintf with HexStr and reverse-iterator
5295079b2 test: Explicitly set encoding to utf8 when opening text files
ccf31edf6 [copyright] add MIT license headers to .sh scripts where missing
84a5830aa Auto merge of #4829 - str4d:backport-lints, r=str4d
1e6d1837a lint: Remove some subtrees from exclusion
5b543b15e lint: Allow stoi in src/rpc/blockchain.cpp
bd5ff7c88 Auto merge of #4835 - str4d:bctest-backports, r=str4d
95ad6fc6b test: Fix pyflakes warning in bitcoin-util-test.py
9dbf53544 lints: Add a missing copyright header
4b69b94bb Small documentation fixes
80a658fbd Auto merge of #4844 - ebfull:release-v4.1.0, r=daira
08fd678be Update approximate release height
90493623a Fix a comment about postponement of Clang upgrade
4f331d0f7 Update doc/release-notes/release-notes-4.1.0.md
f8c9a1f2d Update doc/release-notes/release-notes-4.1.0.md
fe681d2cc make-release.py: Updated release notes and changelog for 4.1.0.
453dacccf make-release.py: Updated manpages for 4.1.0.
75a8a6c25 make-release.py: Versioning changes for 4.1.0.
34c2a4b38 Postpone clang and libc++ dependency updates until after the 4.1.0 release.
2a78e3517 Auto merge of #4837 - daira:fix-gitian, r=daira
6cbaa65b5 Gitian builds: Remove manual CFLAGS and CXXFLAGS from descriptor.
e289f812d Improve logging in bctest.py if there is a formatting mismatch
abd7840c2 Clean up bctest.py and bitcoin-util-test.py
5508f1443 Add logging to bitcoin-util-test.py
3e2460b6f test: Add format-dependent comparison to bctest
2079d495f add verbose mode to bitcoin-util-test.py
e9c1703ba bitcoin-util-test.py should fail if the output file is empty
cbce715c0 Add option to run bitcoin-util-test.py manually
25193f0fa Add bitcoin-tx JSON tests
7c42009dd lints: Match `export LC_ALL="C"` in lint-shell-locale
69d3d3844 Follow-up to #13454: Fix broken build by exporting LC_ALL=C
32fe88362 lints: Update expected Boost imports
f318ab377 lints: Use Zcash-specific include guards for new files
d89f31dc4 Make lint-includes.sh work from any directory
bdaccd0f0 Run all lint scripts
1be9fa9ae Remove no longer needed shellcheck suppressions
68393a4b7 Fix warnings introduced in shellcheck v0.6.0
8ed37f5f4 Remove repeated suppression. Fix indentation.
37604a199 refactor/lint: Add ignored suggestions to an array
653f6dc7e qa: Ignore shellcheck warning SC2236
27f924108 Scripts and tools & Docs: Used #!/usr/bin/env bash instead of obsolete #!/bin/bash, added linting for .sh files shebang and updated the Developer Notes.
5b11b94d2 macOS fix: Add excludes for checks added in the newer shellcheck version installed by brew
73a6c29bc macOS fix: Work around empty (sub)expression error when using BSD grep
52f45ad9a use export LC_ALL=C.UTF-8
b90433afd fix locale for lint-shell
be186b811 Obsolete #!/bin/bash shebang
f98ced2ab Add linter: Make sure we explicitly open all text files using UTF-8 or ASCII encoding in Python
0eef155a4 Explicitly specify encoding when opening text files in Python code
1b32acdd5 Add linter: Make sure all shell scripts opt out of locale dependence using "export LC_ALL=C"
745ac0ae6 Add "export LC_ALL=C" to all shell scripts
aade01b18 docs: Mention lint-locale-dependence.sh in developer-notes.md
40316e935 build: Add linter for checking accidental locale dependence
9174ccaf0 build: Guard against accidental introduction of new Boost dependencies
c2848070b test: Move linters to test/lint, add readme
2788e3371 [contrib] convert test-security-check to python3
5d0affeaf add lint tool to check python3 shebang
eab2490ea Add shell script linting: Check for shellcheck warnings in shell scripts
5747638ec Refine travis check for duplicate includes
a3afa2a17 Add Travis check for duplicate includes
87bc7fc83 Add lint-include-guards.sh which checks include guard consistency
4ddfb216e Fix missing or inconsistent include guards
653846b0a Document include guard convention
b2d56059f [script] lint-whitespace: improve print linenumber
87f4e1c48 devtools: Exclude patches from lint-whitespace
c1683a142 [scripts] lint-whitespace: check last N commits or unstaged changes
034fe80a7 [scripts] lint-whitespace: use perl instead of grep -P
b77da1fd0 contrib: Ignore historical release notes for whitespace check
378d6d04a Add tab char lint check and exclude imported dependencies
5da5d5421 Add a lint check for trailing whitespace.
36463d42c Fix header guards using reserved identifiers
70e1e116a [Trivial] ensure minimal header conventions
75f1a4602 Auto merge of #4832 - therealyingtong:release-v4.1.0-rc1, r=daira
d66cabf8c Update release-notes-4.1.0-rc1.md
3cdef42bc make-release.py: Updated release notes and changelog for 4.1.0-rc1.
1f731e835 make-release.py: Updated manpages for 4.1.0-rc1.
f10cf663b make-release.py: Versioning changes for 4.1.0-rc1.
b61a7e2e8 Auto merge of #4831 - str4d:shell-cleanups, r=daira
ab5fdb7c7 Use bash instead of POSIX sh. POSIX sh does not support arrays.
8cd66cf69 Add error handling: exit if cd fails
5009f219e Auto merge of #4830 - daira:rename-bp-funding-stream, r=daira
d54dda736 Rename the FS_ZIP214_ECC funding stream to FS_ZIP214_BP. See also https://github.com/zcash/zips/pull/412 .
d6012677e Auto merge of #4826 - str4d:4823-static-assert, r=daira
d476537d8 scripted-diff: Remove BOOST_STATIC_ASSERT
1d5ed8fa2 Auto merge of #4744 - LarryRuane:4721-treestate, r=daira
a91a7d37c add z_gettreestate rpc
b9a4f291e Auto merge of #4812 - str4d:shielded-reqs-reject-reasons, r=str4d
311a079dd Auto merge of #4827 - str4d:commit-script-check, r=str4d
1b42734b9 tests: Update chained_joinsplits test for HaveShieldedRequirements API change
8aadc745c Use HTTPS in script license headers
e9b836d61 Update example scripted-diff comit in doc/developer-notes.md
1b01bd942 test/lint: Check for working changes before checking scripted diffs
001e803b9 test: Mention commit id in scripted diff error
1d3af1714 Enable ShellCheck rules
ccd074a59 scripted-diff: Run scripted-diff in subshell
3b1bf4b4a Add "export LC_ALL=C" to all shell scripts
6506fbacf test: Move linters to test/lint, add readme
9645ae5be [docs] document scripted-diff
6b6f3b564 Fail on commit with VERIFY SCRIPT but no scripted-diff
553c9e685 devtools: add script to verify scriptable changes
8f5630635 Add txid to "shielded requirements not met" messages
360540635 Auto merge of #4815 - daira:fix-checksum-message, r=daira
e86f83c62 Fix an error reporting bug in "Checksum missing or mismatched ..."
40d5f0aa5 Auto merge of #4805 - str4d:fs-abstraction, r=str4d
d7c80e760 utils: Remove unnecessary GetTempPath()
fef4b911d Auto merge of #4804 - str4d:update-secp256k1-again, r=daira
6fa2d1b73 Add logging to CCoinsViewCache::HaveShieldedRequirements
47c0c6532 Improve reject reasons for unmet shielded requirements
a4b6aaa33 Auto merge of #4810 - daira:fix-death-tests, r=daira
693def7ba Auto merge of #4733 - nathan-at-least:download-stamp-native_rust-fix, r=daira
f23528ddd Fix death gtests on macOS by switching to the threadsafe style.
888039caf Auto merge of #4808 - nuttycom:fix_release_notes, r=daira
4567e6f5f Replace invalid characters in log message decoding.
d264471f2 Auto merge of #4807 - nuttycom:release-fix-updatecheck, r=nuttycom
b28c5353e Fix invocation of updatecheck.py in make-release.py
94fa87385 depends: fix a logging bug for multi-archive packages.
3cf87df03 Remove unused Boost includes
e2273f101 [Trivial] Add BITCOIN_FS_H endif footer in fs.h
0d3bba071 Remove `namespace fs=fs`
532a0c5c5 torcontrol: Use fs::path instead of std::string for private key path
c0603a9fa Use fsbridge for fopen and freopen
73bc7a068 Replace uses of boost::filesystem with fs
7044e39a5 Replace includes of boost/filesystem.h with fs.h
082f530d6 Add fs.cpp/h
dafc0d35e Move GetTempPath() to testutil.
42929fae9 Add a source file for unit test utils.
0522f6f0d build: Update secp256k1 configure flags
eec9e2dca Update libsecp256k1 subtree to latest master
52ac87242 Squashed 'src/secp256k1/' changes from 8ab24e8da..c6b6b8f1b
afe85096c Auto merge of #4803 - therealyingtong:postpone-ccache, r=therealyingtong
cafc622a2 Auto merge of #4757 - str4d:update-secp256k1, r=str4d
d8f20860d Postpone native_ccache 4.0
990f77b4c build: Use the endomorphism optimization for secp256k1
53ba8172c Update src/secp256k1 subtree to upstream libsecp256k1
2fa8a70c1 Squashed 'src/secp256k1/' changes from 6ad5cdb42..8ab24e8da
1f06621e3 add myblockhash parameter to getrawtransaction
be9aec60f add address to z_importviewingkey error
REVERT: d94fe7678 zcash_script: Add API to verify scripts with precomputed tx data
REVERT: 2178e309d Rename libzcashconsensus.la -> libzcash_script.la
REVERT: 515b37aa2 Rename zcashconsensus_* -> zcash_script_* in APIs
REVERT: 021e8050d Rename src/script/zcashconsensus.* -> src/script/zcash_script.*
REVERT: 06d6b7d8b Add amount and consensus branch ID to zcashconsensus_verify_script
REVERT: 1f3b27427 Remove crypto/equihash from libzcashconsensus
REVERT: dc8ac9107 prevector: Terminate without logging on failed allocation
REVERT: 1075096bb Remove init_and_check_sodium from crypto/common.h
REVERT: 09e423ccc Remove JSDescription::h_sig
REVERT: bc2f687ca Add JSDescriptionInfo for constructing JSDescriptions
REVERT: 28c01c2b5 Default to defining endian-conversion DECLs in compat w/o config
REVERT: bd1166814 Replace boost::optional with std::optional
REVERT: 04bd26523 Replace boost::variant with std::variant
git-subtree-dir: depend/zcash
git-subtree-split: fa1a57867b742b0c44a9e96624e6bc58ef3912cf
* fix compiler errors related to building c code as cpp
The relevant patents have now expired:
- US7110538B2 expired 2020-09-25.
- US7995752B2 expired 2020-09-15.
Co-authored-by: Jane Lusby <jlusby42@gmail.com>
* remove color-eyre from build dependencies
* looks like we can remove this from the dev deps too
* (cargo-release) version 0.1.2-rc.1
* (cargo-release) version 0.1.2
* (cargo-release) start next development iteration 0.1.3-alpha.0
* initial working version on cc
* add basic actions automation
* checkout submodules
* don't require bindgen generation
* use newest zcash changes
* pause work on ripping out sodium
* push hacks to some version of the repo
* fix path in build.rs
* add job for testing different OSs
* str4d is the fucking greatest
* cleanup unused code
* remove symlink
* cleanup cruft
* remove old automation files
* Apply suggestions from code review
Co-authored-by: Saleem Rashid <dev@saleemrashid.com>
* add failure case test
* always generate bindings
* install llvm dep on windows
* cleanup unused bindings
* try messing with CI
* use actual branch name
* use correct remote for gitmodules
* Update build.rs
Co-authored-by: Saleem Rashid <dev@saleemrashid.com>
* rename to zcash_script
* cleanup last mentions
* Prepare zcash_script for release (#2)
* cleanup last mentions
* add files that need to be included
Co-authored-by: Saleem Rashid <dev@saleemrashid.com>
* initial working version on cc
* add basic actions automation
* checkout submodules
* don't require bindgen generation
* use newest zcash changes
* pause work on ripping out sodium
* push hacks to some version of the repo
* fix path in build.rs
* add job for testing different OSs
* str4d is the fucking greatest
* cleanup unused code
* remove symlink
* cleanup cruft
* remove old automation files
* Apply suggestions from code review
Co-authored-by: Saleem Rashid <dev@saleemrashid.com>
* add failure case test
* always generate bindings
* install llvm dep on windows
* cleanup unused bindings
* try messing with CI
* use actual branch name
* use correct remote for gitmodules
* Update build.rs
Co-authored-by: Saleem Rashid <dev@saleemrashid.com>
Co-authored-by: Saleem Rashid <dev@saleemrashid.com>
* Relax cc dependency requirements, bump secp256k1 to 0.13 and bump version to 0.16.5
* Update travis and appveyor to use minimum rustc version 1.22.0 required by secp256k1 0.13
* Add WIN32 define for Windows target, remove endianness decls.
* Relax cc requirements, bump secp256k1 to 0.15 and bump version to 0.17.0
Conrado Gouvea
Alfredo Garcia
Arya
teor
Janito Vaqueiro Ferreira Filho
Jane Lusby
str4d
Dimitris Apostolou
Elichai Turkel
Jonas Nick
Aleksey Sidorov
Tamas Blummer